[Bug 4815] Review request: vcmi - Heroes of Might and Magic 3 game engine

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4815

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4815] Review request: vcmi - Heroes of Might and Magic 3 game engine

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4815

--- Comment #12 from Miro Hrončok  ---
Done. Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4815] Review request: vcmi - Heroes of Might and Magic 3 game engine

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4815

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Blocks|2   |4
   Assignee|rpmfusion-package-review@rp |zebo...@gmail.com
   |mfusion.org |
  Flags||fedora-review+

--- Comment #11 from Robert-André Mauchin  ---
Remove the * to own thes directory too:

%{_libdir}/%{name}/*


Package otherwise approved.


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4
[Bug 4] Tracker: Accepted packages.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4815] Review request: vcmi - Heroes of Might and Magic 3 game engine

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4815

--- Comment #10 from Miro Hrončok  ---
Awesome!

Spec URL: https://churchyard.fedorapeople.org/SRPMS/vcmi.spec
SRPM URL: https://churchyard.fedorapeople.org/SRPMS/vcmi-0.99-2.fc27.src.rpm

- Split noarch data into a subpackage 
- Own /usr/share/vcmi/ (spotted this one when doing the above)

F27 scratch build in progress:
http://koji.rpmfusion.org/koji/taskinfo?taskID=207645

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4815] Review request: vcmi - Heroes of Might and Magic 3 game engine

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4815

--- Comment #9 from Robert-André Mauchin  ---
So I launched a virtualization thingie with a live of Fedora 28 and I was able
to successfully launch and start a new game. So I guess it means the patch work
as intended.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4815] Review request: vcmi - Heroes of Might and Magic 3 game engine

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4815

--- Comment #8 from Robert-André Mauchin  ---
Are you sure you wanna use this? It compiles but I haven't tested if it works
because I don't have a Fedora 28 or Heroes 3 around. Maybe it will crash the
game?


I'd recommend a noarch -data subpackage:

[!]: Large data in /usr/share should live in a noarch subpackage if package
 is arched.
 Note: Arch-ed rpms have a total of 7157760 bytes in /usr/share



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3)", "CC by-sa (v4.0)", "Unknown or generated", "MIT/X11
 (BSD like)", "BSL (v1.0)", "zlib/libpng", "*No copyright* CC by-sa",
 "LGPL (v3 or later)", "BSD (3 clause)", "GPL (v2 or later)", "*No
 copyright* GPL (v2 or later)", "*No copyright* Apache LGPL (v3.0)".
 834 files have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/vcmi/review-vcmi/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/vcmi, /usr/lib64/vcmi
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/vcmi,
 /usr/share/vcmi
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 71680 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package 

[Bug 4815] Review request: vcmi - Heroes of Might and Magic 3 game engine

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4815

--- Comment #7 from Miro Hrončok  ---
It builds on my machine.

Here are some scratch builds:

f29: http://koji.rpmfusion.org/koji/taskinfo?taskID=206289
f28: http://koji.rpmfusion.org/koji/taskinfo?taskID=206282
f27: http://koji.rpmfusion.org/koji/taskinfo?taskID=206297

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4815] Review request: vcmi - Heroes of Might and Magic 3 game engine

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4815

--- Comment #6 from Miro Hrončok  ---
\o/ Thank you!

Spec URL: https://churchyard.fedorapeople.org/SRPMS/vcmi.spec
SRPM URL: https://churchyard.fedorapeople.org/SRPMS/vcmi-0.99-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4815] Review request: vcmi - Heroes of Might and Magic 3 game engine

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4815

--- Comment #5 from Robert-André Mauchin  ---
Created attachment 1882
  --> https://bugzilla.rpmfusion.org/attachment.cgi?id=1882=edit
Patch for compatibility with Boost 1.66

Absolutely disgusting and untested patch for compatibility with 1.66

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4815] Review request: vcmi - Heroes of Might and Magic 3 game engine

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4815

--- Comment #4 from Miro Hrončok  ---
Upstream bug report: https://bugs.vcmi.eu/view.php?id=2844

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4815] Review request: vcmi - Heroes of Might and Magic 3 game engine

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4815

--- Comment #3 from Miro Hrončok  ---
Oh, my bad, I was confident I've tried rawhide as well. Let me re-check.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4815] Review request: vcmi - Heroes of Might and Magic 3 game engine

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4815

--- Comment #2 from Robert-André Mauchin  ---
Both basic_socket_acceptor and basic_socket_streambuf have changed in 1.66, so
the current code is not working.

http://www.boost.org/doc/libs/1_66_0/doc/html/boost_asio/reference/basic_socket_acceptor.html
http://www.boost.org/doc/libs/1_66_0/doc/html/boost_asio/reference/basic_socket_streambuf.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4815] Review request: vcmi - Heroes of Might and Magic 3 game engine

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4815

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com

--- Comment #1 from Robert-André Mauchin  ---
It doesn't seem to like Boost 1.66 or something else in Rawhide:


BUILDSTDERR: In file included from /usr/include/boost/asio.hpp:30,
BUILDSTDERR:  from
/builddir/build/BUILD/vcmi-0.99/lib/serializer/Connection.cpp:8:
BUILDSTDERR: /usr/include/boost/asio/basic_socket_acceptor.hpp:73:7: error:
redeclared with 1 template parameter
BUILDSTDERR:  class basic_socket_acceptor
BUILDSTDERR:^
BUILDSTDERR: In file included from
/builddir/build/BUILD/vcmi-0.99/lib/serializer/Connection.cpp:2:
BUILDSTDERR: /builddir/build/BUILD/vcmi-0.99/lib/serializer/Connection.h:35:9:
note: previous declaration 'template class boost::asio::basic_socket_acceptor' used 2
template parameters
BUILDSTDERR:class basic_socket_acceptor;
BUILDSTDERR:  ^
BUILDSTDERR: In file included from
/usr/include/boost/asio/basic_socket_streambuf.hpp:25,
BUILDSTDERR:  from
/usr/include/boost/asio/basic_socket_iostream.hpp:24,
BUILDSTDERR:  from /usr/include/boost/asio.hpp:31,
BUILDSTDERR:  from
/builddir/build/BUILD/vcmi-0.99/lib/serializer/Connection.cpp:8:
BUILDSTDERR: /usr/include/boost/asio/basic_stream_socket.hpp:49:7: error:
redeclared with 1 template parameter
BUILDSTDERR:  class basic_stream_socket
BUILDSTDERR:^~~
BUILDSTDERR: In file included from
/builddir/build/BUILD/vcmi-0.99/lib/serializer/Connection.cpp:2:
BUILDSTDERR: /builddir/build/BUILD/vcmi-0.99/lib/serializer/Connection.h:31:9:
note: previous declaration 'template
class boost::asio::basic_stream_socket' used 2 template parameters
BUILDSTDERR:class basic_stream_socket;
BUILDSTDERR:  ^~~
BUILDSTDERR: In file included from
/usr/include/boost/asio/basic_socket_iostream.hpp:24,
BUILDSTDERR:  from /usr/include/boost/asio.hpp:31,
BUILDSTDERR:  from
/builddir/build/BUILD/vcmi-0.99/lib/serializer/Connection.cpp:8:
BUILDSTDERR: /usr/include/boost/asio/basic_socket_streambuf.hpp:210:68: error:
wrong number of template arguments (1, should be 2)
BUILDSTDERR:explicit
basic_socket_streambuf(basic_stream_socket s)
BUILDSTDERR:   
 ^
BUILDSTDERR: In file included from
/builddir/build/BUILD/vcmi-0.99/lib/serializer/Connection.cpp:2:
BUILDSTDERR: /builddir/build/BUILD/vcmi-0.99/lib/serializer/Connection.h:31:9:
note: provided for 'template class
boost::asio::basic_stream_socket'
BUILDSTDERR:class basic_stream_socket;
BUILDSTDERR:  ^~~
BUILDSTDERR: In file included from /usr/include/boost/asio.hpp:31,
BUILDSTDERR:  from
/builddir/build/BUILD/vcmi-0.99/lib/serializer/Connection.cpp:8:
BUILDSTDERR: /usr/include/boost/asio/basic_socket_iostream.hpp:104:52: error:
wrong number of template arguments (1, should be 2)
BUILDSTDERR:socket_iostream_base(basic_stream_socket s)
BUILDSTDERR: ^
BUILDSTDERR: In file included from
/builddir/build/BUILD/vcmi-0.99/lib/serializer/Connection.cpp:2:
BUILDSTDERR: /builddir/build/BUILD/vcmi-0.99/lib/serializer/Connection.h:31:9:
note: provided for 'template class
boost::asio::basic_stream_socket'
BUILDSTDERR:class basic_stream_socket;
BUILDSTDERR:  ^~~
BUILDSTDERR: In file included from /usr/include/boost/asio.hpp:31,
BUILDSTDERR:  from
/builddir/build/BUILD/vcmi-0.99/lib/serializer/Connection.cpp:8:
BUILDSTDERR: /usr/include/boost/asio/basic_socket_iostream.hpp:207:67: error:
wrong number of template arguments (1, should be 2)
BUILDSTDERR:explicit
basic_socket_iostream(basic_stream_socket s)
BUILDSTDERR:   
^
BUILDSTDERR: In file included from
/builddir/build/BUILD/vcmi-0.99/lib/serializer/Connection.cpp:2:
BUILDSTDERR: /builddir/build/BUILD/vcmi-0.99/lib/serializer/Connection.h:31:9:
note: provided for 'template class
boost::asio::basic_stream_socket'
BUILDSTDERR:class basic_stream_socket;
BUILDSTDERR:  ^~~
BUILDSTDERR: In file included from /usr/include/boost/asio.hpp:61,
BUILDSTDERR:  from
/builddir/build/BUILD/vcmi-0.99/lib/serializer/Connection.cpp:8:
BUILDSTDERR: /usr/include/boost/asio/generic/stream_protocol.hpp:111:46: error:
wrong number of template arguments (1, should be 2)
BUILDSTDERR:typedef basic_stream_socket socket;
BUILDSTDERR:   ^
BUILDSTDERR: In file included from