[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 Nicolas Chauvet changed: What|Removed |Added Blocks|3 | Referenced Bugs: https://bugzilla.rpmfusion.org/show_bug.cgi?id=3 [Bug 3] Tracker: Packages under review. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 Richard changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 Richard changed: What|Removed |Added See Also||https://bugzilla.rpmfusion. ||org/show_bug.cgi?id=5030 -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 --- Comment #23 from Richard --- Closing in favor of: https://bugzilla.rpmfusion.org/show_bug.cgi?id=5030 That has been updated to 390.87. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 --- Comment #22 from FeRD (Frank Dana) --- (In reply to leigh scott from comment #19) > (In reply to FeRD (Frank Dana) from comment #15) > > Yeah, sorry. I would help out, but my GT 710 is (barely) a Kepler card. > > Sounds perfect to me for 390xx support > > https://download.nvidia.com/XFree86/Linux-x86_64/390.87/README/ > supportedchips.html Maybe I misunderstood kwizart's comment about Fermi. My Kepler will definitely WORK with 390.87, but because it's also compatible with the newer 396.54, that's what I'm currently running day-to-day, and I plan to move to the 400-series drivers (looks like 410.57 is the current latest?) when we have them packaged. I figured we were looking for someone with a Fermi chip to maintain, because they'd also be using the 390xx series, not any later releases. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 --- Comment #21 from Wolfgang Ulbrich --- My old notebook have a 425m GPU which needs 390.xxx driver. If i get latest 390.87 successful running for testing hybrid graphic, i am happy to help out as co-maintainer for testing, etc. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 --- Comment #20 from leigh scott --- (In reply to Richard from comment #18) > (In reply to Nicolas Chauvet from comment #17) > > It means that the 390xx serie can still be relevant from el6 to any recent > > fedora. > > As a side note, el7.6 plans to enable libglvnd support, so I expect to keep > > a version that will work with both glvnd and non-glvnd until rhel 7.6 > > launched. > > By RHEL 7.6 GA, we might clean-up support for non-glvnd in the 390xx serie > > and keep el6 as a fork. > > > > @Richard > > Any issue with that ? > > Sound good to me. If leigh is good with helping with the kernel patches when > needed I'll try to work on the review this weekend. I'm good with doing the patching. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 --- Comment #19 from leigh scott --- (In reply to FeRD (Frank Dana) from comment #15) > Yeah, sorry. I would help out, but my GT 710 is (barely) a Kepler card. Sounds perfect to me for 390xx support https://download.nvidia.com/XFree86/Linux-x86_64/390.87/README/supportedchips.html -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 --- Comment #18 from Richard --- (In reply to Nicolas Chauvet from comment #17) > It means that the 390xx serie can still be relevant from el6 to any recent > fedora. > As a side note, el7.6 plans to enable libglvnd support, so I expect to keep > a version that will work with both glvnd and non-glvnd until rhel 7.6 > launched. > By RHEL 7.6 GA, we might clean-up support for non-glvnd in the 390xx serie > and keep el6 as a fork. > > @Richard > Any issue with that ? Sound good to me. If leigh is good with helping with the kernel patches when needed I'll try to work on the review this weekend. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 --- Comment #17 from Nicolas Chauvet --- (In reply to FeRD (Frank Dana) from comment #16) ... > updates only through January 2019, at which point they're orphaned > completely. The date was updated to 2022 https://devtalk.nvidia.com/default/topic/1032650/linux/unix-graphics-feature-deprecation-schedule/ It means that the 390xx serie can still be relevant from el6 to any recent fedora. As a side note, el7.6 plans to enable libglvnd support, so I expect to keep a version that will work with both glvnd and non-glvnd until rhel 7.6 launched. By RHEL 7.6 GA, we might clean-up support for non-glvnd in the 390xx serie and keep el6 as a fork. @Richard Any issue with that ? -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 --- Comment #16 from FeRD (Frank Dana) --- BTW, if anyone needs to know where they stand driver-wise, Fermi cards have been left behind as of April 2018. (That's when future support for new-feature updates — starting from the 400.xx driver release — was limited to Kepler, Maxwell, and Pascal series GPUs.) Fermi will be getting security updates only through January 2019, at which point they're orphaned completely. Nvidia's official list of the affected cards can be found here: https://nvidia.custhelp.com/app/answers/detail/a_id/4656 And the (incredibly brief) Support Plan announcement regarding that change, which honestly contains nothing I didn't cover in this comment: https://nvidia.custhelp.com/app/answers/detail/a_id/4654 -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 FeRD (Frank Dana) changed: What|Removed |Added CC||ferd...@gmail.com --- Comment #15 from FeRD (Frank Dana) --- Yeah, sorry. I would help out, but my GT 710 is (barely) a Kepler card. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 --- Comment #14 from Richard --- I have a GTS 450 which per google is a Fermi2... -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 --- Comment #13 from Nicolas Chauvet --- (In reply to Richard from comment #12) > If most of the work is kernel patching I'm definitely not qualified :) I'm > willing to co-maintain though. Thx for your help in this area. We really need to have someone using a NVIDIA Fermi GPU to use and maintain this serie. Please have a look on the reviewer comments, you need to create another review and update to 390.87 which is the latest of the serie. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 --- Comment #12 from Richard --- If most of the work is kernel patching I'm definitely not qualified :) I'm willing to co-maintain though. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 --- Comment #11 from leigh scott --- (In reply to Richard from comment #10) > I would really like to see this supported but I don't think I can keep up > with the frequency of kernel releases. It isn't that much work keeping up with the kernel, see https://pkgs.rpmfusion.org/cgit/nonfree/nvidia-kmod.git/log/?qt=grep=Patch+for It's a lot easier than it used to be now it's akmod only. P.S I could assist with kernel patching. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 Richard changed: What|Removed |Added CC||hobbes1...@gmail.com --- Comment #10 from Richard --- I would really like to see this supported but I don't think I can keep up with the frequency of kernel releases. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 --- Comment #9 from Nicolas Chauvet --- Still no volunteer to maintain the 390xx driver in RPM Fusion ? -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 --- Comment #8 from Nicolas Chauvet --- @Vaclav, Thx for your offer. You just need to create another review with the previous remarks from Robert-André Fixed to finish the review. Once done you will have to maintain the driver in RPM Fusion. This means: - Updating and fixing the driver if any issue are reported in our bugzilla. - Verify that the kmod still build on recent Fedora - Sync packaging features from the main driver if relevant. (such as the nvidia-fallback). There is a "Nice to have" todo list: - Make the driver parallele installable with the main serie (Ubuntu did something like this IIRC) - Build nvidia-settings and others tools from source and have them parallel installable (they can be bundled in the main package the first step). - Maintain the driver in EL6/EL7 branches. Hopefully there will be others maintainer to help to co-maintain. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 --- Comment #7 from Vaclav Danek --- Nicolas, I could probably help to maintain 390xx as I have GPU requiring this driver version. Please provide more info what do you need from me. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 --- Comment #6 from Nicolas Chauvet --- If any volunteer with the hardware can help to maintain the 390xx serie, please rise your hand. I don't plan to maintain the 390xx serie myslef. Thx for the review Robert, any future maintainer should take your remark into account. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928
--- Comment #5 from Robert-André Mauchin ---
Hi no other issue besides the appdata → metainfo recommendation.
I can approve it since it's minor.
(In reply to leigh scott from comment #4)
> This missing tar file error from
>
> https://bugzilla.rpmfusion.org/show_bug.cgi?id=4929
>
> (In reply to Robert-André Mauchin from comment #1)
> > + tar --use-compress-program xz -xf
> > /usr/share/nvidia-390xx-kmod-390.67/nvidia-390xx-kmod-390.67-x86_64.tar.xz
> > BUILDSTDERR: tar (child):
> > /usr/share/nvidia-390xx-kmod-390.67/nvidia-390xx-kmod-390.67-x86_64.tar.xz:
> > Cannot open: No such file or directory
> > BUILDSTDERR: tar (child): Error is not recoverable: exiting now
> > BUILDSTDERR: tar: Child returned status 2
> > BUILDSTDERR: tar: Error is not recoverable: exiting now
> >
> > The name of the archive starts with nvidia-kmod, not nvidia-390xx-kmod.
> > Use:
> >
> > tar --use-compress-program xz -xf
> > %{_datadir}/nvidia-kmod-%{version}/nvidia-kmod-%{version}-%{_target_cpu}.tar.
> > xz
>
>
>
> is caused by this review, see
>
> #Install the nvidia kernel modules sources archive
> mkdir -p %{buildroot}%{_datadir}/nvidia-kmod-%{version}
> tar Jcf
> %{buildroot}%{_datadir}/nvidia-kmod-%{version}/nvidia-kmod-%{version}-
> %{_target_cpu}.tar.xz kernel
Yes either fix it here or in the other package.
--
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928
--- Comment #4 from leigh scott ---
This missing tar file error from
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4929
(In reply to Robert-André Mauchin from comment #1)
> + tar --use-compress-program xz -xf
> /usr/share/nvidia-390xx-kmod-390.67/nvidia-390xx-kmod-390.67-x86_64.tar.xz
> BUILDSTDERR: tar (child):
> /usr/share/nvidia-390xx-kmod-390.67/nvidia-390xx-kmod-390.67-x86_64.tar.xz:
> Cannot open: No such file or directory
> BUILDSTDERR: tar (child): Error is not recoverable: exiting now
> BUILDSTDERR: tar: Child returned status 2
> BUILDSTDERR: tar: Error is not recoverable: exiting now
>
> The name of the archive starts with nvidia-kmod, not nvidia-390xx-kmod.
> Use:
>
> tar --use-compress-program xz -xf
> %{_datadir}/nvidia-kmod-%{version}/nvidia-kmod-%{version}-%{_target_cpu}.tar.
> xz
is caused by this review, see
#Install the nvidia kernel modules sources archive
mkdir -p %{buildroot}%{_datadir}/nvidia-kmod-%{version}
tar Jcf
%{buildroot}%{_datadir}/nvidia-kmod-%{version}/nvidia-kmod-%{version}-%{_target_cpu}.tar.xz
kernel
--
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 --- Comment #3 from leigh scott --- (In reply to Robert-André Mauchin from comment #1) The service is started by a conditional, missing nvidia.ko triggers it https://pkgs.rpmfusion.org/cgit/nonfree/xorg-x11-drv-nvidia.git/tree/nvidia-fallback.service#n6 > Shouldn't you run the systemd scriptlets for this service file? > > %post > %systemd_post nvidia-fallback.service > > %preun > %systemd_preun nvidia-fallback.service > > %postun > %systemd_postun_with_restart nvidia-fallback.service Is there anything else that needs fixing so it passes review? -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 leigh scott changed: What|Removed |Added CC||leigh123li...@gmail.com --- Comment #2 from leigh scott --- (In reply to Nicolas Chauvet from comment #0) > TODO: > Restore either builtin tools (nvidia-xconfig/nvidia-settings/others?) > At this step we can assume the same can be used from the 396+ serie. Maybe consider stripping vulkan support as this driver is intended for Fermi cards. People that want vulkan support can use nvidia main. P.S vulkan-filesystem has been replaced by vulkan-loader package. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Blocks||3
Assignee|rpmfusion-package-review@rp |zebo...@gmail.com
|mfusion.org |
--- Comment #1 from Robert-André Mauchin ---
# install AppData and add modalias provides
mkdir -p %{buildroot}%{_datadir}/appdata/
install -pm 0644 %{SOURCE12} %{buildroot}%{_datadir}/appdata/
/usr/share/appdata is deprecated in favour of /usr/share/metainfo
See:
https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html
and: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html
install -p -m 0644 %{SOURCE21} %{buildroot}%{_unitdir}
Shouldn't you run the systemd scriptlets for this service file?
%post
%systemd_post nvidia-fallback.service
%preun
%systemd_preun nvidia-fallback.service
%postun
%systemd_postun_with_restart nvidia-fallback.service
- xorg-x11-drv-nvidia-390xx.src:16: W: mixed-use-of-spaces-and-tabs (spaces:
line 1, tab: line 16)
Line 16, 19, 33, 34: replace the tabs with spaces
- Would be nice to escape all the macros in comment
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
- systemd_post is invoked in %post, systemd_preun in %preun, and
systemd_postun in %postun for Systemd service files.
Note: Systemd service file(s) in xorg-x11-drv-nvidia-390xx
See: https://fedoraproject.org/wiki/Packaging:Scriptlets#Scriptlets
- Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files directly in %_libdir.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 1699840 bytes in 53 files.
See:
http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
= MUST items =
C/C++:
[-]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[-]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL", "MIT/X11 (BSD like)", "SGI Free Software License B
(v1.1)", "Unknown or generated", "BSD (3 clause)". 257 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/xorg-x11-drv-nvidia-390xx/review-xorg-x11
-drv-nvidia-390xx/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/udev,
/usr/share/glvnd/egl_vendor.d, /usr/share/glvnd, /usr/lib/modprobe.d,
/usr/lib/udev/rules.d, /usr/lib/dracut/dracut.conf.d, /usr/lib/dracut
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /etc/nvidia(xorg-x11-drv-
nvidia), /usr/lib/nvidia(xorg-x11-drv-nvidia-libs, xorg-x11-drv-
nvidia), /usr/include/nvidia(xorg-x11-drv-nvidia-devel),
/usr/include/nvidia/GL(xorg-x11-drv-nvidia-devel),
/usr/share/nvidia(xorg-x11-drv-nvidia)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[-]: Sources contain only permissible code or content.
[x]: %config files are marked noreplace or the reason is justified.
Note: No (noreplace) in %config /etc/OpenCL/vendors/nvidia.icd
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 Nicolas Chauvet changed: What|Removed |Added Blocks||4929 Referenced Bugs: https://bugzilla.rpmfusion.org/show_bug.cgi?id=4929 [Bug 4929] Review nvidia-390xx-kmod - NVIDIA 390xx display driver kernel module -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4928] Review Request: xorg-x11-drv-nvidia-390xx - NVIDIA's 390xx series proprietary display driver for NVIDIA graphic cards
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928 Nicolas Chauvet changed: What|Removed |Added Group|Package Reviews | CC list accessible|1 |0 Reporter|1 |0 accessible|| -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
