https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #28 from Nicolas Chauvet ---
Does %package_name really works in the freeworld case ?
Since you have defined %{p_suffix} after defining package name as
%{appname}%{p_suffix}.
Anyway, It should be easier to use Name:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #27 from Artem ---
(In reply to Vitaly Zaitsev from comment #20)
> Issues:
>
> 1. Man pages are not renamed.
> 2. Icon file conflicts with regular version.
> 3. Desktop file should be patched to use retroarch-freeworld.svg icon.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
Nicolas Chauvet changed:
What|Removed |Added
Flags|fedora-review? |
--- Comment #26 from Nicolas
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #25 from Artem ---
(In reply to Nicolas Chauvet from comment #23)
> For example, you have picked a design where retroarch and
> retroarch-freeworld can be co-installed. This is fine. But why not to move
> the icons and others to a
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #24 from Vitaly Zaitsev ---
> But why not to move the icons and others to a common sub-package (such as the
> assets) instead of renaming them ?
Because you asked him to do this:
> I would prefer a fully separate package (like
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
Nicolas Chauvet changed:
What|Removed |Added
Flags|fedora-review+ |fedora-review?
--- Comment #23 from
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
Vitaly Zaitsev changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #22 from
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #21 from Vitaly Zaitsev ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #20 from Vitaly Zaitsev ---
Issues:
1. Man pages are not renamed.
2. Icon file conflicts with regular version.
3. Desktop file should be patched to use retroarch-freeworld.svg icon.
--
You are receiving this mail because:
You are
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #19 from Vitaly Zaitsev ---
Oops, sorry. LGTM now. I will post review soon.
--
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #18 from Artem ---
(In reply to Vitaly Zaitsev from comment #17)
> Subpackages -filters and -assets will conflict with Fedora versions due to
> providing the same files in the same locations.
This is weird. Please check again, i
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #17 from Vitaly Zaitsev ---
Subpackages -filters and -assets will conflict with Fedora versions due to
providing the same files in the same locations.
--
You are receiving this mail because:
You are on the CC list for the
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #16 from Artem ---
Now fully standalone package. Even config tree in $HOME have -freeworld suffix.
Config files MUST been different in this case for RetroArch.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #15 from Nicolas Chauvet ---
(In reply to FeRD (Frank Dana) from comment #14)
...
> Obviously Qt is an extreme case, as I said right at the start. But if
> retroarch-freeworld is going to be standalone, consider whether there would
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
FeRD (Frank Dana) changed:
What|Removed |Added
CC||ferd...@gmail.com
--- Comment #14
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #13 from Artem ---
(In reply to Nicolas Chauvet from comment #12)
> Well, that's a problem when there is a version change, because we will yet
> have a package that will need to be in sync between fedora and break on one
> side or
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #12 from Nicolas Chauvet ---
(In reply to Vitaly Zaitsev from comment #11)
...
> retroarch-freeworld contains only binary file (with enabled ffmpeg). It will
> share assets with Fedora.
Well, that's a problem when there is a version
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #11 from Vitaly Zaitsev ---
> What do you mean by that ? is there a fedora review ? please mention the
> review here.
Approved review for Fedora:
https://bugzilla.redhat.com/show_bug.cgi?id=1778299#c23
> Please provide the
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #10 from Vitaly Zaitsev ---
Cannot run fedora-review tool with rpmfusion-free enabled repositories. It
crashes.
--
You are receiving this mail because:
You are on the CC list for the
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #9 from Nicolas Chauvet ---
(In reply to Vitaly Zaitsev from comment #8)
> Fedora's side approved. Will check RPM Fusion's part now.
What do you mean by that ? is there a fedora review ? please mention the review
here. So we are
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #8 from Vitaly Zaitsev ---
Fedora's side approved. Will check RPM Fusion's part now.
--
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #7 from Artem ---
New fixes:
https://raw.githubusercontent.com/tim77/fedora/master/rpmbuild/SPECS/retroarch.spec
https://atim.fedorapeople.org/for-review/retroarch-freeworld-1.8.1-12.fc31.src.rpm
--
You are receiving this mail
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #6 from Artem ---
Sorry, raw Spec:
https://raw.githubusercontent.com/tim77/fedora/master/rpmbuild/SPECS/retroarch.spec
https://atim.fedorapeople.org/for-review/retroarch-freeworld-1.8.1-11.fc31.src.rpm
--
You are receiving this
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
Artem changed:
What|Removed |Added
namespace|nonfree |free
--- Comment #5 from Artem ---
Some
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #4 from Nicolas Chauvet ---
(In reply to Artem from comment #3)
> (In reply to Nicolas Chauvet from comment #2)
> > Can you confirm that retroarch will only be found in the rpmfusion nonfree
> > section and no content will be
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
--- Comment #2 from Nicolas Chauvet ---
Please use the with_freeworld keyword only with content found in the free
section.
When using content related to the nonfree section, please retains with_nonfree.
Can you confirm that retroarch will only
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5478
Vitaly Zaitsev changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC|
27 matches
Mail list logo
