[Bug 6469] Review request: intel-ipu6-kmod - The driver for Intel IPU6 MIPI camera
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6469 Nicolas Chauvet changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 6469] Review request: intel-ipu6-kmod - The driver for Intel IPU6 MIPI camera
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6469 --- Comment #14 from Kate Hsuan --- Thank you for reviewing it. (In reply to Nicolas Chauvet from comment #13) > This package itself is good as is. But some package (icamerasrc or > intel-ipu6 ?) needs to have: > > Provides: intel-ipu6-kmod-common ipu6-camera-bins already provided "intel-ipu6-kmod-common". > Requires: intel-ipu6-kmod All the packages are necessary for the IPU6 camera. The dependency looks like this: gstreamer1-plugins-icamerasrc (requires)-> ipu6-camera-hal (requires)-> ipu6-camera-bins ipu6-camera-bins provides the basic libraries for plugins and applications. We could only place the kmod provide/reqiure setting in this package. > > Eventually you can enforce a version (if ever relevant) with >= > > Let's defer that question to > https://bugzilla.rpmfusion.org/show_bug.cgi?id=6468 Okay. Let's discuss it there. > > This package is APPROVED I'll submit the new package. Thank you :) > > But please only import it when the solution is found. Okay. Could I import the kmod package first? (rfpkg import) -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 6469] Review request: intel-ipu6-kmod - The driver for Intel IPU6 MIPI camera
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6469 Nicolas Chauvet changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|rpmfusion-package-review@rp |kwiz...@gmail.com |mfusion.org | Flags||fedora-review+ --- Comment #13 from Nicolas Chauvet --- This package itself is good as is. But some package (icamerasrc or intel-ipu6 ?) needs to have: Provides: intel-ipu6-kmod-common Requires: intel-ipu6-kmod Eventually you can enforce a version (if ever relevant) with >= Let's defer that question to https://bugzilla.rpmfusion.org/show_bug.cgi?id=6468 This package is APPROVED But please only import it when the solution is found. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 6469] Review request: intel-ipu6-kmod - The driver for Intel IPU6 MIPI camera
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6469 --- Comment #12 from Kate Hsuan --- Hi Folks, Thank you for reviewing. The updated for akmod are shown as follows. SPEC: https://raw.githubusercontent.com/smallorange/intel-ipu6-akmod/main/intel-ipu6-kmod.spec SRPM: https://github.com/smallorange/intel-ipu6-akmod/releases/download/0.0-3/intel-ipu6-kmod-0.0-3.20230117gitf83b074.fc37.src.rpm The fixes include: 1. typo 2. update patches Next, I'll update "Requires:" in ipu6-camera-bins package. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 6469] Review request: intel-ipu6-kmod - The driver for Intel IPU6 MIPI camera
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6469
--- Comment #11 from Hans de Goede ---
Nicolas,
Thank you for your help with reviewing this.
Yes, I will take care of the userspace packages. It might be helpful for me to
explain what the entire stack looks like:
1. A set of out of tree open-source drivers (this review request)
2. ipu6-camera-bins-firmware, firmware for 1. (review bug 6474)
3. ivsc-firmware, more firmware for 1. (review bug 6491)
4. ipu6-camera-bins set of binary only x86_64 libraries talking to 1. (review
bug 6474)
5. ipu6-camera-hal opensource (apache-2.0) library layer over ipu6-camera-bins
(review bug 6508)
6. gstreamer1-plugins-icamerasrc gstreamer plugin building on top of 5. (review
bug 6534)
This is the minimum stack after this the camera can be tested with gst-launch.
But to actually get it to work we need another program on top called
v4l2-relayd which uses the v4l2-loopback kernel module. This will listen for
userspace opening the loopback /dev/video0 device and then it will start a
gstreamer pipeline for this
(review bug 6529).
We want users to be able to just do a "sudo dnf install akmod-intel-ipu6" and
then get a fully working stack.
Nicolas, so I guess this means that we need to add the following Requires to
ipu6-camera-bins since that provides intel-ipu6-kmod-common ? :
Requires: ipu6-camera-bins-firmware
Requires: ivsc-firmware
Requires: gstreamer1-plugins-icamerasrc
Requires: v4l2-relayd
(note gstreamer1-plugins-icamerasrc will bring in ipu6-camera-hal).
Having these there feels a bit weird which is why I suggested a stub
intel-ipu6-kmod-common package to Kate, but if the usual way for kmods is to
just put these inside ipu6-camera-bins then that is fine with me too.
> So this package should have:
> Requires:intel-ipu6-kmod >= %{?epoch}:%{version}
I agree on the "Requires: intel-ipu6-kmod" but I think it should be unversioned
there is no tight version coupling here and there actually is nothing
resembling proper versioning from upstream at all. So I think we want just:
Requires: intel-ipu6-kmod
added on top of the Requires I mentioned above.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 6469] Review request: intel-ipu6-kmod - The driver for Intel IPU6 MIPI camera
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6469
--- Comment #10 from Nicolas Chauvet ---
(In reply to Kate Hsuan from comment #9)
> (In reply to Nicolas Chauvet from comment #8)
> > Can you point me to the package that provides the %{name}-kmod-common ?
...
> https://github.com/smallorange/ipu6-bin-firmware/raw/main/ipu6-camera-bins.
> spec
So this package should have:
Requires:intel-ipu6-kmod >= %{?epoch}:%{version}
So it can fetch the appropriate kmod.
Usually there is a need to review them all and introduce them at the same time.
It would have probably been easier to start the review from the firmwares
part...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 6469] Review request: intel-ipu6-kmod - The driver for Intel IPU6 MIPI camera
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6469
--- Comment #9 from Kate Hsuan ---
(In reply to Nicolas Chauvet from comment #8)
> Nitpick: patch16 is not capitalized.
>
> Can you point me to the package that provides the %{name}-kmod-common ?
Sorry about that
The virtual provide is implemented in ipu6-camera-bins package.
You can find it here
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6474
https://github.com/smallorange/ipu6-bin-firmware/raw/main/ipu6-camera-bins.spec
https://koji.rpmfusion.org/koji/buildinfo?buildID=24734
Thank you
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 6469] Review request: intel-ipu6-kmod - The driver for Intel IPU6 MIPI camera
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6469
--- Comment #8 from Nicolas Chauvet ---
Nitpick: patch16 is not capitalized.
Can you point me to the package that provides the %{name}-kmod-common ?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 6469] Review request: intel-ipu6-kmod - The driver for Intel IPU6 MIPI camera
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6469 --- Comment #7 from Kate Hsuan --- Update spec file: SPEC: https://raw.githubusercontent.com/smallorange/intel-ipu6-akmod/main/intel-ipu6-kmod.spec SRPM: https://github.com/smallorange/intel-ipu6-akmod/releases/download/0.0-2/intel-ipu6-kmod-0.0-2.20230117gitf83b074.fc38.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 6469] Review request: intel-ipu6-kmod - The driver for Intel IPU6 MIPI camera
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6469 Hans de Goede changed: What|Removed |Added CC||h...@hansg.org --- Comment #6 from Hans de Goede --- (In reply to Kate Hsuan from comment #0) > - Mention that you are seeking a sponsor if you are not a Fedora sponsored > packager or an RPM Fusion sponsored packager. > > Yes, I'm seeking a reviewer. The question is about needing a sponsor, since you are already in the Fedora packager group: https://accounts.fedoraproject.org/user/smallorange/ You do *not* need a rpmfusion sponsor. The only thing which is necessary is for your packages to go through the regular review process. Note to other rpmfusion devs. I'm not very experienced with reviewing kmods. I plan to review the userspace bits, see bug 6474 (which is just the first of a set of userspace pkgs) but I/we could really use some help with reviewing the kmod parts. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 6469] Review request: intel-ipu6-kmod - The driver for Intel IPU6 MIPI camera
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6469 --- Comment #5 from Kate Hsuan --- Update the URL information SPEC: https://github.com/smallorange/intel-ipu6-akmod/blob/main/intel-ipu6-kmod.spec SRPM: https://github.com/smallorange/intel-ipu6-akmod/releases/download/0.0.1/intel-ipu6-kmod-0.0.1-3.fc38.src.rpm Description: This enables the intel IPU6 image processor. This akmod package includes Intel IPU6 and Intel iVSC drivers. Rpmfusion Account System Username: smallorange -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 6469] Review request: intel-ipu6-kmod - The driver for Intel IPU6 MIPI camera
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6469
leigh scott changed:
What|Removed |Added
CC||leigh123li...@gmail.com
--- Comment #4 from leigh scott ---
(In reply to Kate Hsuan from comment #3)
> (In reply to Nicolas Chauvet from comment #1)
> > > - The output rpmlint gives on both the source and binary packages.
> > > Explain for > each message why you've chosen to ignore it.
> >
> > > intel-ipu6-kmod.spec: W: invalid-url Source1:
> > > ${url}/ipu6-drivers/releases/download
> > Switch ${url} to %{url} ;)
> >
> >
> > It looks fine at first sigh. Looking forward for anyone to do a proper
> > review.
> >
> > Also it would be fine if you can send the full url of a spec file and
> > src.rpm (even from github) so review tool can parse automatically the
> > content for review...
>
> Do you mean to put the spec file and srpm URL to the comment?
We expect reviews to use this format.
Spec URL:
SRPM URL:
Description:
Rpmfusion Account System Username:
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 6469] Review request: intel-ipu6-kmod - The driver for Intel IPU6 MIPI camera
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6469
--- Comment #3 from Kate Hsuan ---
(In reply to Nicolas Chauvet from comment #1)
> > - The output rpmlint gives on both the source and binary packages. Explain
> > for > each message why you've chosen to ignore it.
>
> > intel-ipu6-kmod.spec: W: invalid-url Source1:
> > ${url}/ipu6-drivers/releases/download
> Switch ${url} to %{url} ;)
>
>
> It looks fine at first sigh. Looking forward for anyone to do a proper
> review.
>
> Also it would be fine if you can send the full url of a spec file and
> src.rpm (even from github) so review tool can parse automatically the
> content for review...
Do you mean to put the spec file and srpm URL to the comment?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 6469] Review request: intel-ipu6-kmod - The driver for Intel IPU6 MIPI camera
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6469 --- Comment #2 from Kate Hsuan --- Thank you :) I've fixed it and pushed it to the repository. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 6469] Review request: intel-ipu6-kmod - The driver for Intel IPU6 MIPI camera
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6469
Nicolas Chauvet changed:
What|Removed |Added
Summary|Review request: |Review request:
|akmod-intel-ipu6 - The |intel-ipu6-kmod - The
|driver for Intel IPU6 MIPI |driver for Intel IPU6 MIPI
|camera |camera
--- Comment #1 from Nicolas Chauvet ---
> - The output rpmlint gives on both the source and binary packages. Explain
> for > each message why you've chosen to ignore it.
> intel-ipu6-kmod.spec: W: invalid-url Source1:
> ${url}/ipu6-drivers/releases/download
Switch ${url} to %{url} ;)
It looks fine at first sigh. Looking forward for anyone to do a proper review.
Also it would be fine if you can send the full url of a spec file and src.rpm
(even from github) so review tool can parse automatically the content for
review...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
