Re: [rrd-developers] Possible race conditions / data loss in rrdcached?

2009-07-14 Thread kevin brintnall
Imho, it's rather the contrary: Since new nodes are added only very rarely, the overhead of adding new nodes is rather irrelevant and, thus, it's not sensible to _not_ fix that bug. OK.. I agree with this. Anyway, this should be easy to fix. See the patch, I'll send in a minute. Beware,

Re: [rrd-developers] Possible race conditions / data loss in rrdcached?

2009-07-14 Thread Tobias Oetiker
Today kevin brintnall wrote: Anyway, this should be easy to fix. See the patch, I'll send in a minute. Beware, though, that I do not have a RRDCacheD setup, so the patch is mostly untested - it compiles though ;-) Your patch doesn't address the problem. I will email another shortly.

Re: [rrd-developers] Possible race conditions / data loss in rrdcached?

2009-07-14 Thread Sebastian Harl
Hi Kevin, On Tue, Jul 14, 2009 at 07:01:38AM -0500, kevin brintnall wrote: Anyway, this should be easy to fix. See the patch, I'll send in a minute. Beware, though, that I do not have a RRDCacheD setup, so the patch is mostly untested - it compiles though ;-) Your patch doesn't