Re: [rspec-users] issues with the trunk of rspec-rails

2009-02-12 Thread Nathan Wilmes
Thanks for making the other fixes! I don't have a 'have_tag' example handy (replaced all the instances with more compact with_tag syntax).. I'll try to get to it later today and send it to you personally. =N On Feb 11, 8:40 pm, David Chelimsky wrote: > On Wed, Feb 11, 2009 at 2:52 PM, nat...@piv

Re: [rspec-users] issues with the trunk of rspec-rails

2009-02-11 Thread David Chelimsky
On Wed, Feb 11, 2009 at 2:52 PM, nat...@pivotalsf.com wrote: > On Feb 10, 8:49 pm, David Chelimsky wrote: >> On Tue, Feb 10, 2009 at 2:02 PM, Nathan Wilmes >> wrote: >> > (4) assigns(:xxx) will give really bad errors if your class doesn't happen >> > to define == in such a way that it can equat

Re: [rspec-users] issues with the trunk of rspec-rails

2009-02-11 Thread David Chelimsky
On Wed, Feb 11, 2009 at 2:52 PM, nat...@pivotalsf.com wrote: > On Feb 10, 8:49 pm, David Chelimsky wrote: >> On Tue, Feb 10, 2009 at 2:02 PM, Nathan Wilmes >> wrote: >> > (2) The render override for RSpec controllers only takes one argument. >> > This >> > means that any controller using two

Re: [rspec-users] issues with the trunk of rspec-rails

2009-02-11 Thread David Chelimsky
On Wed, Feb 11, 2009 at 2:52 PM, nat...@pivotalsf.com wrote: > On Feb 10, 8:49 pm, David Chelimsky wrote: >> On Tue, Feb 10, 2009 at 2:02 PM, Nathan Wilmes >> wrote: >> > (3) with_tag is completely broken, as it tries to use the outer class as >> > the >> > subject of 'with_tag', rather than t

Re: [rspec-users] issues with the trunk of rspec-rails

2009-02-11 Thread nat...@pivotalsf.com
Snipping down to relevant questions: On Feb 10, 8:49 pm, David Chelimsky wrote: > On Tue, Feb 10, 2009 at 2:02 PM, Nathan Wilmes wrote: > > (2) The render override for RSpec controllers only takes one argument.  This > > means that any controller using two argument forms will fail. > > > Our b

Re: [rspec-users] issues with the trunk of rspec-rails

2009-02-10 Thread David Chelimsky
On Tue, Feb 10, 2009 at 10:49 PM, David Chelimsky wrote: > On Tue, Feb 10, 2009 at 2:02 PM, Nathan Wilmes wrote: >> Hi folks, >> >> I'm currently in the process of upgrading an old Rails project to the Rails >> 2.2.2 and the trunk of RSpec, and ran into several issues with rspec-rails. >> I've co

Re: [rspec-users] issues with the trunk of rspec-rails

2009-02-10 Thread Josh Knowles
On Tue, Feb 10, 2009 at 3:02 PM, Nathan Wilmes wrote: > Hi folks, > > I'm currently in the process of upgrading an old Rails project to the Rails > 2.2.2 and the trunk of RSpec, and ran into several issues with rspec-rails. > I've come up with workarounds for all of them, but I wanted to report th

Re: [rspec-users] issues with the trunk of rspec-rails

2009-02-10 Thread David Chelimsky
On Tue, Feb 10, 2009 at 2:02 PM, Nathan Wilmes wrote: > Hi folks, > > I'm currently in the process of upgrading an old Rails project to the Rails > 2.2.2 and the trunk of RSpec, and ran into several issues with rspec-rails. > I've come up with workarounds for all of them, but I wanted to report th

Re: [rspec-users] issues with the trunk of rspec-rails

2009-02-10 Thread Pat Nakajima
> > (3) with_tag is completely broken, as it tries to use the outer class as > the subject of 'with_tag', rather than the have_tag matcher that it lives > inside. > If you're testing markup (view tests or whatever), take a look at my elementor project[1]. I've found that it makes view testing a lo