[Bug 11588] better handling for --preallocate with --sparse

2016-10-09 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #23 from Wayne Davison --- > Continuing to think aloud. It's not really a hole, it's already reserved > space. Exactly, and it's impossible to punch holes in that allocation. I'm changing my patch to give the file a

[Bug 11588] better handling for --preallocate with --sparse

2016-10-09 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #22 from Andrey Gursky --- (In reply to Andrey Gursky from comment #21) Continuing to think aloud. It's not really a hole, it's already reserved space. -- You are receiving this mail because: You are the QA

[Bug 11588] better handling for --preallocate with --sparse

2016-10-09 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #21 from Andrey Gursky --- (In reply to Andrey Gursky from comment #20) Sorry, it is indeed preallocated. Other still holds: hole-punch doesn't fail because the file already consists of only hole. Such file I

[Bug 11588] better handling for --preallocate with --sparse

2016-10-09 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #20 from Andrey Gursky --- (In reply to Wayne Davison from comment #17) From what I see, it doesn't fail, since the file is not preallocated at all with FALLOC_FL_KEEP_SIZE, but just a fully sparse file is