Re: Rsync shouldn't display a meaningless speedup on a dry run

2007-11-07 Thread Paul Slootman
On Tue 06 Nov 2007, Matt McCutchen wrote: Or maybe just have it report a speedup of 1.00 instead? Still misleading, but it preserves the output format and is trivial to write (but still, alas, confusing for the user, so this doesn't fill me with glee). That lie would be no

Re: Rsync shouldn't display a meaningless speedup on a dry run

2007-11-07 Thread Wayne Davison
On Wed, Nov 07, 2007 at 06:54:38AM -0800, Wayne Davison wrote: I'm inclined to just leave it alone rather than tweak it (e.g. force it to 0). One thing that might be nice is a mention in the footer that it is a dry-run: sent 359 bytes received 14 bytes 746.00 bytes/sec total size is 96600

Re: Rsync shouldn't display a meaningless speedup on a dry run

2007-11-07 Thread Wayne Davison
On Tue, Nov 06, 2007 at 10:22:56PM -0500, [EMAIL PROTECTED] wrote: I worry about those trying to write things that parse rsync's output; I had a similar reaction, and will not be eliminating the speedup from the output. If there is nothing to transfer, the speedup number in dry-run mode is even

Re: Rsync shouldn't display a meaningless speedup on a dry run

2007-11-07 Thread Matt McCutchen
On Wed, 2007-11-07 at 00:08 -0500, [EMAIL PROTECTED] wrote: Then how about this: If your patch winds up in rsync, it requires a patch to the manpage entry for -n that says, essentially, You can't trust the actual information emitted when running with -n to match what gets emitted if you

Re: Rsync shouldn't display a meaningless speedup on a dry run

2007-11-07 Thread Matt McCutchen
On Wed, 2007-11-07 at 06:54 -0800, Wayne Davison wrote: On Tue, Nov 06, 2007 at 10:22:56PM -0500, [EMAIL PROTECTED] wrote: I worry about those trying to write things that parse rsync's output; I had a similar reaction, and will not be eliminating the speedup from the output. If there is

Re: Rsync shouldn't display a meaningless speedup on a dry run

2007-11-07 Thread Matt McCutchen
On Thu, 2007-11-08 at 00:06 +, Wayne Davison committed: [...] and the speedup value is equivalent to a run where no file transfers are needed. Do you not accept that the speedup printed on a dry run is meaningless? Come on. My bank's online bill payment system knows better than to

Rsync shouldn't display a meaningless speedup on a dry run

2007-11-06 Thread foner-rsync
Date: Mon, 05 Nov 2007 13:17:32 -0500 From: Matt McCutchen [EMAIL PROTECTED] I think rsync should omit the speedup on a dry run. The attached patch makes it do so. I worry about those trying to write things that parse rsync's output; if -n changes the output format, such

Re: Rsync shouldn't display a meaningless speedup on a dry run

2007-11-06 Thread Matt McCutchen
On Tue, 2007-11-06 at 22:22 -0500, [EMAIL PROTECTED] wrote: I worry about those trying to write things that parse rsync's output; if -n changes the output format, such things will have to be tested on live data. No, just run rsync's output through a sed script that adds the desired speedup to

Rsync shouldn't display a meaningless speedup on a dry run

2007-11-06 Thread foner-rsync
Date: Tue, 06 Nov 2007 23:18:08 -0500 From: Matt McCutchen [EMAIL PROTECTED] On Tue, 2007-11-06 at 22:22 -0500, [EMAIL PROTECTED] wrote: I worry about those trying to write things that parse rsync's output; if -n changes the output format, such things will have to be tested

Rsync shouldn't display a meaningless speedup on a dry run

2007-11-05 Thread Matt McCutchen
On a dry run, rsync displays a speedup value calculated from the total size of the source file data and the amount of data sent over the connection, but this value is meaningless and grossly misleading because the file data is not sent over the connection. Example: [EMAIL PROTECTED] test]$ rsync