Re: Unhelpful error message when matching hosts in access list[PATCH]

2003-07-07 Thread Thorild Selen
Ah yes, I recall thinking that your patch should go in, but I thereafter forgot about it. I've gone ahead and committed your change since it was very simple and similar to what we used to do in 2.5.5, only with a better heuristic. I'm planning to look into Thorild Selen's patch as--text

Re: Unhelpful error message when matching hosts in access list[PATCH]

2003-07-07 Thread Wayne Davison
On Mon, Jul 07, 2003 at 06:29:58PM +0200, Thorild Selen wrote: It's not enough just checking the last char to see whether something is an address: [...] Yeah, good point. I've checked in an improved version of the test based on your suggestions (which I finally got around to looking at in

Re: Unhelpful error message when matching hosts in access list[PATCH]

2003-07-07 Thread Thorild Selen
Wayne Davison writes: My patch leaves out the IPv6 logic if INET6 is not configured into rsync. Sounds reasonable. I've checked-in the appended patch. See if you like it. Looks good to me. I'll report to the Debian bug tracking system that these issues are now fixed in CVS upstream.

Re: Unhelpful error message when matching hosts in access list[PATCH]

2003-07-05 Thread Wayne Davison
On Fri, Jul 04, 2003 at 11:07:02PM -0500, John Van Essen wrote: I had submitted a similar bug report and small patch on April 10: There were no followups to it at the time. Ah yes, I recall thinking that your patch should go in, but I thereafter forgot about it. I've gone ahead and committed

Unhelpful error message when matching hosts in access list [PATCH]

2003-07-04 Thread Thorild Selen
Greetings, As previously reported by me to the Debian bug tracking system: -- An access list in rsyncd.conf may contain hostnames as well as addresses. It may contain several patterns to match against. address_match (in

Unhelpful error message when matching hosts in access list [PATCH]

2003-07-04 Thread Thorild Selen
Sorry, I missed that an address should be able to contain a slash (used with netmask) and a % and some more stuff too if it's a scoped IPv6 address. Here's a new patch. Thorild Selén Datorföreningen Update / Update Computer Club, Uppsala, SE

Re: Unhelpful error message when matching hosts in access list[PATCH]

2003-07-04 Thread John Van Essen
On Sat, 5 Jul 2003, Thorild Selen [EMAIL PROTECTED] wrote: Greetings, As previously reported by me to the Debian bug tracking system: -- An access list in rsyncd.conf may contain hostnames as well as addresses. It may contain