Re: possible typo/bug in receiver.c

2003-01-20 Thread Dave Dykstra
On Sat, Jan 18, 2003 at 12:25:05AM -0800, Wayne Davison wrote: > On Fri, Jan 17, 2003 at 11:39:31PM -0800, Craig Barratt wrote: > > If mkstemp() fails (for various reasons, including the directory not > > existing) then fd == -1. So the first if () executes, which flushes > > the data and does a c

Re: possible typo/bug in receiver.c

2003-01-18 Thread Wayne Davison
On Fri, Jan 17, 2003 at 11:39:31PM -0800, Craig Barratt wrote: > If mkstemp() fails (for various reasons, including the directory not > existing) then fd == -1. So the first if () executes, which flushes > the data and does a continue. So the next two if () statements will > never execute. Good

possible typo/bug in receiver.c

2003-01-17 Thread Craig Barratt
The following code in receiver.c around line 421 (2.5.6pre1) contains some dead code: /* we initially set the perms without the setuid/setgid bits to ensure that there is no race condition. They are then correctly updated after the lchown. Thanks to [EMAIL