Here's a better patch; rsync should now no longer dump core if called with
insufficient arguments. write_batch_argvs_file() is still ugly though, not
sure how to clean this up.
Index: batch.c
===
RCS file: /cvsroot/rsync/batch.c,v
)
Subject:rsync-2.5.1pre1 with -F option
Classification:
I compiled and tried rsync 2.5.1pre1.
RSYNC with -F option dumps a core.
% gdb ./rsync
GNU gdb 5.1
(gdb) r -F
Starting program: /work/rsync-2.5.1pre1/./rsync -F
Program received signal SIGSEGV, Segmentation fault
I compiled and tried rsync 2.5.1pre1.
RSYNC with -F option dumps a core.
% gdb ./rsync
GNU gdb 5.1
(gdb) r -F
Starting program: /work/rsync-2.5.1pre1/./rsync -F
Program received signal SIGSEGV, Segmentation fault.
write_batch_argvs_file (orig_argc=-2, argc=0, argv=0x0) at batch.c:153
153