[Code study]should we remove if (motd *motd) section?

2009-04-27 Thread Daniel.Li
Dear List, I'm confused when we will run into if (motd *motd)? As I have found that Globals is set 0 during initialization, and I didn't find anywhere else assign the value. If so, should we remove this section? Or there might be some where I missed? Please correct me, if I'm wrong. Thanks

rsync: writefd_unbuffered failed to write 4 bytes on mounted share

2009-04-27 Thread Stefan-Michael Guenther
Hello, we are using rsync to backup data to a NAS share. The share is mounted with the following command: mount -t nfs 192.168.1.101:/nas/NASDisk-3/public /media/nas -o timeo=5,rsize=8096,wsize=8096,soft rsync is called by rsnapshot with the command: rsync -a --stats --delete

Re: [Code study]should we remove if (motd *motd) section?

2009-04-27 Thread Paul Slootman
On Mon 27 Apr 2009, Daniel.Li wrote: I'm confused when we will run into if (motd *motd)? As I have found that Globals is set 0 during initialization, and I didn't find anywhere else assign the value. clientserver.c #line 147~160 if (!am_client) { motd =

Re: [Code study]should we remove if (motd *motd) section?

2009-04-27 Thread Daniel.Li
On Mon, 2009-04-27 at 12:41 +0200, Paul Slootman wrote: On Mon 27 Apr 2009, Daniel.Li wrote: I'm confused when we will run into if (motd *motd)? As I have found that Globals is set 0 during initialization, and I didn't find anywhere else assign the value. clientserver.c #line

Re: [Code study]should we remove if (motd *motd) section?

2009-04-27 Thread Petr Uzel
On Mon, Apr 27, 2009 at 07:27:38PM +0800, Daniel.Li wrote: On Mon, 2009-04-27 at 19:21 +0800, Daniel.Li wrote: On Mon, 2009-04-27 at 12:41 +0200, Paul Slootman wrote: On Mon 27 Apr 2009, Daniel.Li wrote: I'm confused when we will run into if (motd *motd)? As I have found

Re: [Code study]should we remove if (motd *motd) section?

2009-04-27 Thread Daniel.Li
On Mon, 2009-04-27 at 19:21 +0800, Daniel.Li wrote: On Mon, 2009-04-27 at 12:41 +0200, Paul Slootman wrote: On Mon 27 Apr 2009, Daniel.Li wrote: I'm confused when we will run into if (motd *motd)? As I have found that Globals is set 0 during initialization, and I didn't find

Re: [Code study]should we remove if (motd *motd) section?

2009-04-27 Thread Daniel.Li
On Mon, 2009-04-27 at 13:34 +0200, Petr Uzel wrote: On Mon, Apr 27, 2009 at 07:27:38PM +0800, Daniel.Li wrote: On Mon, 2009-04-27 at 19:21 +0800, Daniel.Li wrote: On Mon, 2009-04-27 at 12:41 +0200, Paul Slootman wrote: On Mon 27 Apr 2009, Daniel.Li wrote: I'm confused when we

Re: [Code study]append_mode definitions

2009-04-27 Thread Wayne Davison
On Mon, Apr 27, 2009 at 10:33:02AM +0800, Daniel.Li wrote: Can anyone help to explain definitions of variable append_mode? There are two different type of appending (see the man page) depending on how new rsync is and how much of the file should be checksummed. The option is also disabled if a

Re: rsync: writefd_unbuffered failed to write 4 bytes on mounted share

2009-04-27 Thread Wayne Davison
On Mon, Apr 27, 2009 at 12:19:10PM +0200, Stefan-Michael Guenther wrote: rsync: close failed on /media/nas/daily.0/samba/Bereiche/Auslieferung/Software/NT2/2012/2012-69-RA-1L.0968 (XY_I)/2006-11-16/XY_app.968/Logdb/.XYlog.mdb.REP380: Input/output error (5) That's an OS error when rsync

Re: [Code study]append_mode definitions

2009-04-27 Thread Daniel.Li
On Mon, 2009-04-27 at 06:44 -0700, Wayne Davison wrote: On Mon, Apr 27, 2009 at 10:33:02AM +0800, Daniel.Li wrote: Can anyone help to explain definitions of variable append_mode? There are two different type of appending (see the man page) depending on how new rsync is and how much of the

Re: purge-empty-dirs and max-file-size confusion

2009-04-27 Thread Wayne Davison
On Fri, Apr 24, 2009 at 02:19:42PM -0400, Ian! D. Allen wrote: There is no mention of the concept of transfer rule in the rsync man page. I offer some proposed man page wording changes, below. Thanks. I have committed some manpage changes that clarify this unexpected behavior. At some point

Re: [PATCH] allow to disable SLP with runtime option

2009-04-27 Thread Wayne Davison
On Wed, Apr 22, 2009 at 04:14:23PM +0200, Petr Uzel wrote: It adds a new global boolean option, 'disable slp', which can be used to disable SLP advertisements at runtime. I've taken your patch and changed the boolean into a use slp global daemon parameter (default: enabled). I also made sure

Rsync (cwrsync) log file

2009-04-27 Thread Jeff Boyce
Greetings - There is probably a simple answer to this, but I can't seem to figure it out. I would like to have a clean log file of each rsync operation; in other words I don't want to have rsync append to the existing log file, but instead create a new one each time after deleting the old

[SCM] The rsync repository. branch, master, updated. v3.0.3-188-gfd2b604

2009-04-27 Thread rsync-cvs
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project The rsync repository.. The branch, master has been updated via fd2b6046cb0afc960da8cbd2c1dab40c786f8097 (commit) from

[SCM] The rsync repository. branch, b3.0.x, updated. v3.0.6pre1-3-g40b3a59

2009-04-27 Thread rsync-cvs
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project The rsync repository.. The branch, b3.0.x has been updated via 40b3a59fc836de5319826bb4793060fafdba12d7 (commit) from