[Bug 11588] better handling for --preallocate with --sparse

[samba-bugs]

https://bugzilla.samba.org/show_bug.cgi?id=11588

--- Comment #23 from Wayne Davison  ---
> Continuing to think aloud. It's not really a hole, it's already reserved 
> space.

Exactly, and it's impossible to punch holes in that allocation. I'm changing my
patch to give the file a size to deal with this anomaly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

[Bug 11588] better handling for --preallocate with --sparse

[samba-bugs]

https://bugzilla.samba.org/show_bug.cgi?id=11588

--- Comment #22 from Andrey Gursky  ---
(In reply to Andrey Gursky from comment #21)

Continuing to think aloud. It's not really a hole, it's already reserved space.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

[Bug 11588] better handling for --preallocate with --sparse

[samba-bugs]

https://bugzilla.samba.org/show_bug.cgi?id=11588

--- Comment #21 from Andrey Gursky  ---
(In reply to Andrey Gursky from comment #20)

Sorry, it is indeed preallocated. Other still holds: hole-punch doesn't fail
because the file already consists of only hole. Such file I would call a
preallocated data-sparse. In opposite to the usual not preallocated
space-sparse with truncate:

$ truncate -s 1048576 test-sparse

$ ls -ls test-sparse
0 -rw-r--r-- 1 andrey andrey 1048576 Oct  9 15:34 test-sparse

$ /usr/sbin/filefrag -v test-sparse
Filesystem type is: ef53
File size of test-sparse is 1048576 (256 blocks of 4096 bytes)
test-sparse: 0 extents found

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

[Bug 11588] better handling for --preallocate with --sparse

[samba-bugs]

https://bugzilla.samba.org/show_bug.cgi?id=11588

--- Comment #20 from Andrey Gursky  ---
(In reply to Wayne Davison from comment #17)

From what I see, it doesn't fail, since the file is not preallocated at all
with FALLOC_FL_KEEP_SIZE, but just a fully sparse file is created (consisting
of only one big hole):

$ ls -ls test-file
1024 -rwx-- 1 andrey andrey 0 Oct  9 14:47 test-file

$ /usr/sbin/filefrag -v test-file 
Filesystem type is: ef53
File size of test-file is 0 (0 blocks of 4096 bytes)
 ext: logical_offset:physical_offset: length:   expected: flags:
   0:0.. 255:   14828800..  14829055:256:
last,unwritten,eof
test-file: 1 extent found

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html