[Bug 12819] [PATCH] sync() on receiving side for data consistency

2017-06-13 Thread just subscribed for rsync-qa from bugzilla via rsync
https://bugzilla.samba.org/show_bug.cgi?id=12819

--- Comment #1 from Brian K. White  ---
This seems wrong to me. If the OS is failing to manage write buffers and file
access between processes, you would have a lot bigger problems in every process
all through the system, and this wouldn't fix it.

Similarly, if rsync were corrupting data, a lot of people would already know
about it. It gets used way too much and too heavily for anything like this to
go unnoticed for more than a day, let alone 15 or more years.

It's almost axiomatic: No matter what problem you think you have, no matter
what language or OS or platform, if you think it's fixed by either sleep() or
sync(), it's not.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


[Bug 12838] [PATCH] Log sent/received bytes even in case of error

2017-06-13 Thread just subscribed for rsync-qa from bugzilla via rsync
https://bugzilla.samba.org/show_bug.cgi?id=12838

--- Comment #1 from Ben RUBSON  ---
Mmmmh unfortunately numbers are not correct.

# Sender side (which interrupts the transfer receiving SIGUSR2) :
Total file size: 16­.85G bytes 
Total transferred file size: 183­.38M bytes 
Literal data: 182­.32M bytes 

# Receiver side : 
rsyncd: rsync: connection unexpectedly closed (202529 bytes received so far)
[generator]
rsyncd: sent 24749 bytes  received 202529 bytes  total size 16845198594

Perhaps related to bug #10738 where stats are also not correctly calculated.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


[Bug 12838] New: [PATCH] Log sent/received bytes even in case of error

2017-06-13 Thread just subscribed for rsync-qa from bugzilla via rsync
https://bugzilla.samba.org/show_bug.cgi?id=12838

Bug ID: 12838
   Summary: [PATCH] Log sent/received bytes even in case of error
   Product: rsync
   Version: 3.1.2
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5
 Component: core
  Assignee: way...@samba.org
  Reporter: ben.rub...@gmail.com
QA Contact: rsync...@samba.org

Created attachment 13271
  --> https://bugzilla.samba.org/attachment.cgi?id=13271=edit
rsync_log_daemon

Hello,

This patch allows the daemon to log data sent/received even in case of error,
which can be interesting to have when the transfer has been interrupted by the
client.

Thank you !

Ben

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html