Re: 4.4BSD chflags support for rsync

2002-04-26 Thread Dave Dykstra

On Fri, Apr 26, 2002 at 03:11:59AM +0200, Rolf Grossmann wrote:
 Hi Dave,
 
 on Thu, 25 Apr 2002 15:52:56 -0500 Dave Dykstra wrote 
 concerning Re: 4.4BSD chflags support for rsync something like this:
 
  I think the --flags patch is probably fine, except that that the short
  description should at least say preserve file flags instead of just
  preserve flags since most people wouldn't know what flags means.
 
 Sure, changed that (found 3 occurrences).
 
 However, I just recently found that I missed a case where I need to clear
 change flags: when (hard)linking to a file, that file may not have flags
 that prevent modification. Unfortunately, I didn't have time to look into
 that issue, yet.
 
 I also noticed, that you've been changing quite a few bits lately. E.g.
 there are rules to build texinfo documentation in the Makefile (but no
 texinfo files) and there is SGML documentation, but no rules for
 formatting. So I decided to wait some more before updating the patch
 to the current release (probably updating the new documentation then).
 So if you'd rather wait for me to update the patch (which is against 2.5.2),
 I'll probably get back to you either after the next release or in a
 week or two. Of course I'll be happy if you'll add the patch anyway ;)

Actually it will be up to the primary maintainer Martin Pool who has been
making those changes and it will be up to him to make the final decision on
if/when to put your patch in; I've just given my opinion as a former
primary maintainer.  Martin, what do you think?


  I don't like --ignore-existing, though.  What's the point of using rsync
  if you're not updating existing files?
 
 It's not my work. I was only saying that by building the manpage,
 the documentation for --ignore-existing also showed up. So unless it
 was explicitly removed for the release, it was simply forgotten to
 rebuild the manpage after the change.

Oops, sorry I didn't catch that.

- Dave Dykstra

-- 
To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html



Re: 4.4BSD chflags support for rsync

2002-04-25 Thread Dave Dykstra

I'm sorry for the long delay in replying.  I'm cleaning up my rsync mailbox
now after a one week vacation and about a month of not having time to look
at it.

I think the --flags patch is probably fine, except that that the short
description should at least say preserve file flags instead of just
preserve flags since most people wouldn't know what flags means.

I don't like --ignore-existing, though.  What's the point of using rsync
if you're not updating existing files?

- Dave



On Fri, Mar 08, 2002 at 08:18:11PM +0100, Rolf Grossmann wrote:
 Hi Dave,
 
 on Fri, 8 Mar 2002 11:55:10 -0600 Dave Dykstra wrote 
 concerning Re: 4.4BSD chflags support for rsync something like this:
 
  New options are usually handled by just letting the remote side fail when
  it doesn't understand the option, as you're doing.  Perhaps you just
  shouldn't include it with -a.
 
 Ok, changed that. I also put a note in the manpage.
 
  At a minimum, you'd need to update the rsync.yo and rsync.1 versions of
  the man page before it could be accepted.
 
 Heh, I knew I forgot something. ;) I've updated the patch. When building
 the new rsync.1 manpage, an entry about --ignore-existing was also included
 and is contained in my patch.
 
 Please let me know what you think.
 
 Thanks, Rolf
 
  On Fri, Mar 01, 2002 at 07:12:47PM +0100, [EMAIL PROTECTED] wrote:
  Hi,
  
  I've changed rsync to support the BSD change file flags. However, this
  raises some compatibility problems, especially when including it with
  the -a option. If the remote host does not understand the new option
  for updating file flags, the user gets an error message about an
  unknown option. How should I handle this?
  
  If you'd like to look at the patch (and preferably integrate it with the
  main source ;)) you can get it at http://www.progtech.net/rsync.flags-patch
  All comments are welcome, but please CC me directly as I'm not on the list.
  
  Thanks and bye,
  Rolf
 
 -- 
 To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync
 Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html

-- 
To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html



Re: 4.4BSD chflags support for rsync

2002-04-25 Thread Rolf Grossmann

Hi Dave,

on Thu, 25 Apr 2002 15:52:56 -0500 Dave Dykstra wrote 
concerning Re: 4.4BSD chflags support for rsync something like this:

 I think the --flags patch is probably fine, except that that the short
 description should at least say preserve file flags instead of just
 preserve flags since most people wouldn't know what flags means.

Sure, changed that (found 3 occurrences).

However, I just recently found that I missed a case where I need to clear
change flags: when (hard)linking to a file, that file may not have flags
that prevent modification. Unfortunately, I didn't have time to look into
that issue, yet.

I also noticed, that you've been changing quite a few bits lately. E.g.
there are rules to build texinfo documentation in the Makefile (but no
texinfo files) and there is SGML documentation, but no rules for
formatting. So I decided to wait some more before updating the patch
to the current release (probably updating the new documentation then).
So if you'd rather wait for me to update the patch (which is against 2.5.2),
I'll probably get back to you either after the next release or in a
week or two. Of course I'll be happy if you'll add the patch anyway ;)

 I don't like --ignore-existing, though.  What's the point of using rsync
 if you're not updating existing files?

It's not my work. I was only saying that by building the manpage,
the documentation for --ignore-existing also showed up. So unless it
was explicitly removed for the release, it was simply forgotten to
rebuild the manpage after the change.

Bye, Rolf

-- 
To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html



Re: 4.4BSD chflags support for rsync

2002-03-08 Thread Dave Dykstra

New options are usually handled by just letting the remote side fail when
it doesn't understand the option, as you're doing.  Perhaps you just
shouldn't include it with -a.

At a minimum, you'd need to update the rsync.yo and rsync.1 versions of
the man page before it could be accepted.

- Dave Dykstra

On Fri, Mar 01, 2002 at 07:12:47PM +0100, [EMAIL PROTECTED] wrote:
 Hi,
 
 I've changed rsync to support the BSD change file flags. However, this
 raises some compatibility problems, especially when including it with
 the -a option. If the remote host does not understand the new option
 for updating file flags, the user gets an error message about an
 unknown option. How should I handle this?
 
 If you'd like to look at the patch (and preferably integrate it with the
 main source ;)) you can get it at http://www.progtech.net/rsync.flags-patch
 All comments are welcome, but please CC me directly as I'm not on the list.
 
 Thanks and bye,
 Rolf
 
 -- 
 To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync
 Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html

-- 
To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html



4.4BSD chflags support for rsync

2002-03-01 Thread rg

Hi,

I've changed rsync to support the BSD change file flags However, this
raises some compatibility problems, especially when including it with
the -a option If the remote host does not understand the new option
for updating file flags, the user gets an error message about an
unknown option How should I handle this?

If you'd like to look at the patch (and preferably integrate it with the
main source ;)) you can get it at http://wwwprogtechnet/rsyncflags-patch
All comments are welcome, but please CC me directly as I'm not on the list

Thanks and bye,
Rolf

-- 
To unsubscribe or change options: http://listssambaorg/mailman/listinfo/rsync
Before posting, read: http://wwwtuxedoorg/~esr/faqs/smart-questionshtml