Re: Daemon tests broken when running as root

2009-11-13 Thread Wayne Davison
On Thu, Nov 12, 2009 at 9:11 PM, Matt McCutchen m...@mattmccutchen.netwrote:

 I'm guessing the uid = 0 and gid = 0 in the test daemon
 configuration were disabled so that the daemon tests could run for
 unprivileged users.


Right.  I've checked in a fix that ensures that uid  gid are specified when
the test is run as root.

..wayne..
-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

Daemon tests broken when running as root

2009-11-12 Thread Matt McCutchen
On Thu, 2009-11-12 at 23:56 -0500, Matt McCutchen wrote:
 Ah.  You ran the testsuite as root, and the daemon tests are not set up
 to cope with that.  The testsuite should pass if you run it as an
 unprivileged user.

The breakage was introduced in commit
7f367bb1b4348ba1edb863ee13f8281471785e09 , which added support for
supplementary groups.  It also made the daemon attempt to honor uid
and gid parameters even if not root and abort the run upon failure.

I'm guessing the uid = 0 and gid = 0 in the test daemon
configuration were disabled so that the daemon tests could run for
unprivileged users.  But that breaks running as root, because the daemon
drops privileges to nobody.  The proper fix is to emit the uid and
gid parameters only when running as root.

-- 
Matt

-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html