Re: configure --with-rsh=CMD and default blocking-IO support

2002-02-07 Thread Dave Dykstra
On Wed, Feb 06, 2002 at 06:25:05PM -0800, Wayne Davison wrote: > On Thu, 7 Feb 2002, Martin Pool wrote: > > A general-purpose RSYNC_OPTS variable would be more tasteful. I think > > popt makes supporting this fairly straightforward. > > That's a nice idea. One area we'll want to be careful of i

Re: configure --with-rsh=CMD and default blocking-IO support

2002-02-07 Thread Dave Dykstra
On Wed, Feb 06, 2002 at 02:56:38PM -0800, Wayne Davison wrote: > On Wed, 6 Feb 2002, Dave Dykstra wrote: > > Of the proposed alternatives, I like this latter the best, changing > > --non-blocking-io to --no-blocking-io. > > Cool. I like that one as well. Here's an implementation. This patch >

Re: configure --with-rsh=CMD and default blocking-IO support

2002-02-06 Thread Wayne Davison
On Thu, 7 Feb 2002, Martin Pool wrote: > A general-purpose RSYNC_OPTS variable would be more tasteful. I think > popt makes supporting this fairly straightforward. That's a nice idea. One area we'll want to be careful of is how the two options interact. For instance, we want to support old scr

Re: configure --with-rsh=CMD and default blocking-IO support

2002-02-06 Thread Martin Pool
On 6 Feb 2002, Wayne Davison <[EMAIL PROTECTED]> wrote: > Cool. I like that one as well. Here's an implementation. This patch > adds the configure option --with(out)-blocking-io and defines a new > variable that gets put into config.h: DEFAULT_BLOCKING_IO. OK, that's good. Thanks. > The c

Re: configure --with-rsh=CMD and default blocking-IO support

2002-02-06 Thread Wayne Davison
On Wed, 6 Feb 2002, Dave Dykstra wrote: > Of the proposed alternatives, I like this latter the best, changing > --non-blocking-io to --no-blocking-io. Cool. I like that one as well. Here's an implementation. This patch adds the configure option --with(out)-blocking-io and defines a new variabl

Re: configure --with-rsh=CMD and default blocking-IO support

2002-02-06 Thread Dave Dykstra
On Tue, Feb 05, 2002 at 09:38:04PM -0800, Wayne Davison wrote: > On Wed, 6 Feb 2002, Martin Pool wrote: > > OK, I agree --with-rsh should go in, but I think putting magic > > characters into it is needlessly confusing. I would feel much better > > about a separate configure option to set the defa

Re: configure --with-rsh=CMD and default blocking-IO support

2002-02-06 Thread Wayne Davison
On Wed, 6 Feb 2002, Martin Pool wrote: > OK, I agree --with-rsh should go in, but I think putting magic > characters into it is needlessly confusing. I would feel much better > about a separate configure option to set the default O_NONBLOCK mode. The complicating factor then becomes: how does th

Re: configure --with-rsh=CMD and default blocking-IO support

2002-02-05 Thread Martin Pool
On 30 Jan 2002, Wayne Davison <[EMAIL PROTECTED]> wrote: > A while back I argued for adding a --with-rsh=CMD option to configure > and got some general agreement that it would be a good thing (especially > for systems that don't have rsh at all). However, the changes were > never integrated into

Re: configure --with-rsh=CMD and default blocking-IO support

2002-01-31 Thread Dave Dykstra
I see that Martin agreed to put it in: http://lists.samba.org/pipermail/rsync/2001-July/004554.html but it must have dropped off his priority list. - Dave Dykstra On Wed, Jan 30, 2002 at 11:11:50AM -0800, Wayne Davison wrote: > A while back I argued for adding a --with-rsh=CMD option to co

configure --with-rsh=CMD and default blocking-IO support

2002-01-30 Thread Wayne Davison
A while back I argued for adding a --with-rsh=CMD option to configure and got some general agreement that it would be a good thing (especially for systems that don't have rsh at all). However, the changes were never integrated into rsync. This patch adds the --with-rsh=CMD option to configure an