Re: install-strip issue

2004-05-02 Thread Wayne Davison
On Sat, May 01, 2004 at 10:59:23PM +, Christian Weisgerber wrote:
 Renaming the variable will take care of this.

Seems like a reasonable change.  Thanks -- I've checked it in.

..wayne..
-- 
To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


install-strip issue

2004-05-01 Thread Christian Weisgerber
From 2.6.2's Makefile:

install: all
...
${INSTALLCMD} ${STRIP} -m 755 rsync$(EXEEXT) ${DESTDIR}${bindir}
...
install-strip:
$(MAKE) STRIP='-s' install

This doesn't work (at least) on OpenBSD, because install(1) there
will use the value of the environment variable STRIP as the command
to run for stripping the executable.

Renaming the variable will take care of this.

--- Makefile.in.orig2004-05-02 00:55:04.0 +0200
+++ Makefile.in 2004-05-02 00:55:24.0 +0200
@@ -62,14 +62,14 @@ man: rsync.1 rsyncd.conf.5
 
 install: all
-mkdir -p ${DESTDIR}${bindir}
-   ${INSTALLCMD} ${STRIP} -m 755 rsync$(EXEEXT) ${DESTDIR}${bindir}
+   ${INSTALLCMD} ${INSTALL_STRIP} -m 755 rsync$(EXEEXT) ${DESTDIR}${bindir}
-mkdir -p ${DESTDIR}${mandir}/man1
-mkdir -p ${DESTDIR}${mandir}/man5
${INSTALLMAN} -m 644 $(srcdir)/rsync.1 ${DESTDIR}${mandir}/man1
${INSTALLMAN} -m 644 $(srcdir)/rsyncd.conf.5 ${DESTDIR}${mandir}/man5
 
 install-strip:
-   $(MAKE) STRIP='-s' install
+   $(MAKE) INSTALL_STRIP='-s' install
 
 rsync$(EXEEXT): $(OBJS)
$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $(OBJS) $(LIBS)
-- 
Christian naddy Weisgerber  [EMAIL PROTECTED]
-- 
To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html