Wayne Davison wrote:
http://rsync.samba.org/ftp/unpacked/rsync/patches/dynamic_hash.diff
A line of credit would have been nice :-)
One thing this patch does is to (1) leave the array allocated to its
largest size, (2) use realloc() if we need to make it bigger, (3) make
the minimum
On Sun, Feb 26, 2006 at 10:34:25AM +0200, Shachar Shemesh wrote:
A line of credit would have been nice :-)
Sure 'nuff.
I think we can save the memory when handling smaller files.
Yeah, I've been leaning the same way, so I like your change here. I
also like your reason for realloc() being the
On Sun, 2006-02-26 at 18:52 -0800, Wayne Davison wrote:
This would be such an improvement for really large files
If the new hash table can handle really large numbers of blocks really
well, it might actually be practical for rsync to load all files in the
transfer into the hash table at the
Date: Sun Feb 26 15:48:01 2006
Author: wayned
Update of /data/cvs/rsync/patches
In directory dp.samba.org:/tmp/cvs-serv27277
Modified Files:
dynamic_hash.diff
Log Message:
Incorporated some feedback from Shachar Shemesh.
Revisions:
dynamic_hash.diff 1.2 = 1.3
Date: Mon Feb 27 02:48:41 2006
Author: wayned
Update of /data/cvs/rsync/patches
In directory dp.samba.org:/tmp/cvs-serv8346
Modified Files:
dynamic_hash.diff
Log Message:
Make sure that the hash-table index can't overflow its variable.
Revisions:
dynamic_hash.diff 1.3
Date: Mon Feb 27 02:55:55 2006
Author: wayned
Update of /data/cvs/rsync/patches
In directory dp.samba.org:/tmp/cvs-serv12919
Modified Files:
dynamic_hash.diff
Log Message:
No need to initialize the chain var of a checksum struct since
it will get set when it is inserted into the hash
Date: Mon Feb 27 03:12:26 2006
Author: wayned
Update of /data/cvs/rsync
In directory dp.samba.org:/tmp/cvs-serv27507
Modified Files:
io.c
Log Message:
In read_sum_head(): if we read a negative checksum count, die
with an error.
Revisions:
io.c1.183 = 1.184
Date: Mon Feb 27 03:28:04 2006
Author: wayned
Update of /data/cvs/rsync/patches
In directory dp.samba.org:/tmp/cvs-serv10986
Modified Files:
dynamic_hash.diff
Log Message:
Improved a few minor things.
Revisions:
dynamic_hash.diff 1.5 = 1.6