Hi Wayne,
Thank you for your detailed answer and links.
Gratefully,
Mark Esler
On Wed, Aug 17, 2022 at 6:52 PM Wayne Davison wrote:
>
> On Wed, Aug 17, 2022 at 9:30 AM Mark Esler wrote:
>>
>> I am curious if CVE-2022-29154 affects rsync 3.2.3 or rrsync 3.2.3 and
>> earlier.
>
>
> The security
[Resending because the rsync mailing list rejected my email earlier.]
On 8/17/22 23:58, Khem Raj wrote:
rsync which add -pedantic-errors option to cflags during configure
OK, that's the problem then. 'configure' should not use flags like
-pedantic-errors. This has long been a property of
On 8/18/22 09:38, Khem Raj wrote:
I think the autoconf patch should be good on its own merits regardless
It partly depends on how much we care about compatibility. Putting the
'void' in there will break pre-C89 compilers, as well as C++ compilers
pretending (badly) to be C compilers. I doubt
On Thu, Aug 18, 2022 at 8:22 AM Paul Eggert wrote:
>
> On 8/17/22 23:58, Khem Raj wrote:
> > rsync which add -pedantic-errors option to cflags during configure
>
> OK, that's the problem then. 'configure' should not use flags like
> -pedantic-errors. This has long been a property of
On Thu, Aug 18, 2022 at 9:27 AM Paul Eggert wrote:
> But if rsync must add -pedantic-errors for some reason, it should do so at
> the very end of 'configure'
I think I'll just get rid of it except for some private builds.
perhaps it'd be better for rsync to also add -pedantic-errors only for
On 8/18/22 19:31, Wayne Davison wrote:
Maybe Clang 15 broke the testing idiom that sets $GCC?
I think Clang has always pretended to be GCC well enough to fool
Autoconf so that 'configure' sets GCC. What's new in Clang 15 is that it
starts being pedantic about empty arglists, apparently.
The branch, master has been updated
via 9a3449a3 Stop enabling -pedantic-errors.
via 3258534e Change name_num_obj struct to use a name_num_item pointer.
via b94bba40 Fix typos on manpage (#358)
via a182507b Fix issue when the files-from list isn't nl terminated.
