Re: OSX and HFS+ filesystem compression
Hi Robert: My apologies, that "if (fnamecmp)" should be commented out as you discovered. Did you read the updated man page to see the new arguments available for supporting HFS+ compression? It isn't on by default, you need to use --protect-decmpfs, for example, to preserve those xattrs.I crafted a new diff and tested it again against 3.0.6. These steps work for me:cd ~/Desktopcurl -Ohttp://rsync.samba.org/ftp/rsync/src/rsync-3.0.6.tar.gztar -xzvf rsync-3.0.6.tar.gzrm rsync-3.0.6.tar.gzcurl -Ohttp://rsync.samba.org/ftp/rsync/src/rsync-patches-3.0.6.tar.gztar -xzvf rsync-patches-3.0.6.tar.gzrm rsync-patches-3.0.6.tar.gzcd rsync-3.0.6patch -p1 patches/fileflags.diffpatch -p1 patches/crtimes.diffpatch -p1 (path to the attached file)echo "#define EXTRA_ROUNDING 0" rounding.h./prepare-source./configuremakesudo./rsync -aHANXx --force-change --protect-decmpfs --fileflags /Volumes/Source/ /Volumes/Target/sudobbouncer verify -d /Volumes/Source /Volumes/TargetVerifying: hfs-compression ... Sub-test:decmpfs xattr ... preserved Sub-test: UF_COMPRESSED flag ... set Sub-test:file contents ... match Sub-test:creation time ... ok Sub-test: modification time ... ok Sub-test: hard link inode ... ok Sub-test: hard link decmpfs xattr ... preserved Sub-test: hard link UF_COMPRESSED flag ... set Sub-test: hard link modification time ... okokVerifying: hfs-compression_large ... Sub-test:decmpfs xattr ... preserved Sub-test: UF_COMPRESSED flag ... set Sub-test:file contents ... match Sub-test:creation time ... ok Sub-test: modification time ... ok Sub-test: hard link inode ... ok Sub-test: hard link decmpfs xattr ... preserved Sub-test: hard link UF_COMPRESSED flag ... set Sub-test: hard link modification time ... okokMike rsync_3.0.6-hfs-compression_20091027.diff Description: Binary data On May 18, 2010, at 10:04 PM, Robert DuToit wrote:Hi Mike,I guess I did something wrong or removing that line 283 in proto.h was criticalI ran fileflags and crtimes patches first and then rsync_3.0.6-hfs-compression_20091027.diff but the test shows no go. Sub-test: decmpfs xattr ... not preservedSub-test: UF_COMPRESSED flag ... not setThanks, rob-- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: OSX and HFS+ filesystem compression
Hi Mike, Just got in I did discover the --protect-decmpfs and got it working! Great news. Thanks for keeping this alive and well for us OSX folks. I'll rebuild with the new diff you sent today. Thanks again, Rob On May 19, 2010, at 12:19 PM, Mike Bombich wrote: Hi Robert: My apologies, that if (fnamecmp) should be commented out as you discovered. Did you read the updated man page to see the new arguments available for supporting HFS+ compression? It isn't on by default, you need to use --protect-decmpfs, for example, to preserve those xattrs. I crafted a new diff and tested it again against 3.0.6. These steps work for me: cd ~/Desktop curl -O http://rsync.samba.org/ftp/rsync/src/rsync-3.0.6.tar.gz tar -xzvf rsync-3.0.6.tar.gz rm rsync-3.0.6.tar.gz curl -O http://rsync.samba.org/ftp/rsync/src/rsync-patches-3.0.6.tar.gz tar -xzvf rsync-patches-3.0.6.tar.gz rm rsync-patches-3.0.6.tar.gz cd rsync-3.0.6 patch -p1 patches/fileflags.diff patch -p1 patches/crtimes.diff patch -p1 (path to the attached file) echo #define EXTRA_ROUNDING 0 rounding.h ./prepare-source ./configure make sudo ./rsync -aHANXx --force-change --protect-decmpfs --fileflags /Volumes/Source/ /Volumes/Target/ sudo bbouncer verify -d /Volumes/Source /Volumes/Target Verifying: hfs-compression ... Sub-test:decmpfs xattr ... preserved Sub-test: UF_COMPRESSED flag ... set Sub-test:file contents ... match Sub-test:creation time ... ok Sub-test:modification time ... ok Sub-test: hard link inode ... ok Sub-test: hard link decmpfs xattr ... preserved Sub-test: hard link UF_COMPRESSED flag ... set Sub-test: hard link modification time ... ok ok Verifying: hfs-compression_large ... Sub-test:decmpfs xattr ... preserved Sub-test: UF_COMPRESSED flag ... set Sub-test:file contents ... match Sub-test:creation time ... ok Sub-test:modification time ... ok Sub-test: hard link inode ... ok Sub-test: hard link decmpfs xattr ... preserved Sub-test: hard link UF_COMPRESSED flag ... set Sub-test: hard link modification time ... ok ok Mike rsync_3.0.6-hfs-compression_20091027.diff On May 18, 2010, at 10:04 PM, Robert DuToit wrote: Hi Mike, I guess I did something wrong or removing that line 283 in proto.h was critical I ran fileflags and crtimes patches first and then rsync_3.0.6-hfs-compression_20091027.diff but the test shows no go. Sub-test: decmpfs xattr ... not preserved Sub-test: UF_COMPRESSED flag ... not set Thanks, rob -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
OSX and HFS+ filesystem compression
Hi All, I have been reading about the HFS+ filesystem compression on Snow Leopard and how copying or cloning over system files with rsync and other tools results in them being expanded on destination. I was wondering if there was any thoughts on updating rsync to accommodate this? It is kind of a shame to the lose the benefits of the new compression. Thanks, Rob -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: OSX and HFS+ filesystem compression
Robert DuToit wrote: I have been reading about the HFS+ filesystem compression on Snow Leopard and how copying or cloning over system files with rsync and other tools results in them being expanded on destination. I was wondering if there was any thoughts on updating rsync to accommodate this? It is kind of a shame to the lose the benefits of the new compression. Any compression that happens within the filesystem layer itself is not visible to client applications. If you use any file copying tool to synchronize a source and destination, and the source is on a compressed filesystem, the solution to preserving the compression is to enable compression on the destination filesystem. --Kyle -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: OSX and HFS+ filesystem compression
Hi Rob: I posted a patch several months ago (October 28, to be specific) that offers HFS+ compression support for rsync. It's OS-specific, so I don't expect the rsync team to maintain the patch, but I'll be keeping it as up to date as I can. Right now it's built and tested against rsync 3.0.6. Mike On May 18, 2010, at 6:59 PM, Robert DuToit wrote: Hi All, I have been reading about the HFS+ filesystem compression on Snow Leopard and how copying or cloning over system files with rsync and other tools results in them being expanded on destination. I was wondering if there was any thoughts on updating rsync to accommodate this? It is kind of a shame to the lose the benefits of the new compression. Thanks, Rob -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: OSX and HFS+ filesystem compression
Hi Mike, Thanks so much After some searching I just found the patch and built on 3.0.6 but got an error on make after running fileflags.diff, crtimes.diff and your patch perl ./mkproto.pl ./*.c ./lib/compat.c In file included from ./rsync.h:971, from ./rounding.c:20: ./proto.h:283: error: expected identifier or ‘(’ before ‘if’ Failed to create rounding.h! make: *** [rounding.h] Error 1 I wasn't sure what to do with line 283 if (fnamecmp); seems to be stuck in there so I removed it and it builds but is this ok now? Thanks, Rob -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: OSX and HFS+ filesystem compression
Hi Mike, I guess I did something wrong or removing that line 283 in proto.h was critical I ran fileflags and crtimes patches first and then rsync_3.0.6-hfs-compression_20091027.diff but the test shows no go. Sub-test: decmpfs xattr ... not preserved Sub-test: UF_COMPRESSED flag ... not set Thanks, rob -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html