Re: [rt-users] attachment improvements

2012-01-23 Thread Ruslan Zakirov
2012/1/23 BÁLINT Bekény balint.bek...@docca.hu: Patch for master branch is attached. IMPORTANT: I'm unable to test it but I hope it works well on this branch. Slightly misguided you. Mentioned change is not yet on master, it's in 4.2/web-attachs-processing branch. Took a look at the

Re: [rt-users] attachment improvements

2012-01-23 Thread BÁLINT Bekény
Hi Chris, I attached the two Callback files for attachment forward. I hope it will help you. -- Bekeny Docca OutSource IT Ltd. On Sun, Jan 22, 2012 at 3:57 PM, Christian Loos cl...@netsandbox.de wrote: Hi, can you please send your changes for 1. Attachment forward. I also have to

Re: [rt-users] attachment improvements

2012-01-22 Thread Ruslan Zakirov
2012/1/21 BÁLINT Bekény balint.bek...@docca.hu: Hi list, Hello, I've made some attachment improvements in our company's RT 3.8 in the last few years. If you are interested in it I can try to create 4.0 compatible Plugins for these features (now I could only send patches for 3.8.x files).

Re: [rt-users] attachment improvements

2012-01-22 Thread Christian Loos
Hi, can you please send your changes for 1. Attachment forward. I also have to implement this for your company RT (3.8.6) within the next weeks and would implement this in our internal RT plugin or would release a separate plugin on github.com for this change if it would be ok for you. Thanks!

Re: [rt-users] attachment improvements

2012-01-22 Thread BÁLINT Bekény
Hi Ruslan, 2. Unique attachment session: RT temporary stores attachments in $session{'Attachments'} and deletes this on Display.html, Update.html, Create.html, ModifyAll.html and Bulk.html. The problem is that if you start a comment, attach a file and you open a ticket or start another

Re: [rt-users] attachment improvements

2012-01-22 Thread Ruslan Zakirov
2012/1/23 BÁLINT Bekény balint.bek...@docca.hu: Do you care to send a patch against master branch? Note that because of above change (2), code around attachments upload is different, but actually it's better as we concentrated it in one place. Patch for master branch is attached.

Re: [rt-users] attachment improvements

2012-01-22 Thread BÁLINT Bekény
Patch for master branch is attached. IMPORTANT: I'm unable to test it but I hope it works well on this branch. Slightly misguided you. Mentioned change is not yet on master, it's in 4.2/web-attachs-processing branch. Took a look at the changes. Looks good and simple. I think patch for