Re: [rt-users] attachment improvements
2012/1/21 BÁLINT Bekény balint.bek...@docca.hu:
Hi list,
Hello,
I've made some attachment improvements in our company's RT 3.8 in the last
few years.
If you are interested in it I can try to create 4.0 compatible Plugins for
these features (now I could only send patches for 3.8.x files).
1. Attachment forward: previously attached files are listed on Update.html
and you can check them to attach to the outgoing mail. (I don't understand
why this kind of feature isn't in vanilla RT. Everybody downloads and then
reuploads attachments if he or she wants to send it to an email address?).
I think in cages we have something like this. It's ok as Plugin and good plugin.
2. Unique attachment session: RT temporary stores attachments
in $session{'Attachments'} and deletes this on Display.html, Update.html,
Create.html, ModifyAll.html and Bulk.html. The problem is that if you start
a comment, attach a file and you open a ticket or start another comment,
etc.in another browser window or tab, your uploaded attachment will be
deleted from session. So later when you submit your comment there won't be
your previously attached file. This is annoying for a lot of users that's
why I create unique session variable in every related page to store the
attachments.
Note: I think it is impossible to implement this with Callbacks only. It
needs patching or overlaying some files.
This is implemented in the repo and aimed at 4.2.
3. Multiple attach: there are flash solutions for multi-attach file but I
don't like flash. Fortunately in HTML5 you can create input type=file
with multiple attribute. Modern browsers support it and allow users to
select more than one file at once. I implement this feature on Update,
Create and ModifyAll pages. Users like this more than I previously supposed
and it was only a 20 minute work to implement. :)
Note: this will be another reason for IE users to change their browser :)
What happens with browsers that don't support this feature? If those
don't have problems and just allow users to upload one file then we
can consider this for core. Do you care to send a patch against master
branch? Note that because of above change (2), code around attachments
upload is different, but actually it's better as we concentrated it in
one place.
4. Attachment coloring and ordering: you can define categories in SiteConfig
and also colors for these categories. On Display page you can set category
for every file with one click. Files get the color of their categories. You
can also order attachments list by category (color), filename, creator, size
and date. There is a predefined category hidden. With this you can hide an
attachment.
It's not my favorite improvement but this is very useful for companies work
on long projects with lot of files.
Sounds like useful @Plugin.
If you need new callbacks for any code then you can send patches.
--
Bekeny
Docca OutSource IT Ltd.
RT Training Sessions (http://bestpractical.com/services/training.html)
* Boston — March 5 6, 2012
--
Best regards, Ruslan.
RT Training Sessions (http://bestpractical.com/services/training.html)
* Boston March 5 6, 2012
Re: [rt-users] attachment improvements
Hi, can you please send your changes for 1. Attachment forward. I also have to implement this for your company RT (3.8.6) within the next weeks and would implement this in our internal RT plugin or would release a separate plugin on github.com for this change if it would be ok for you. Thanks! -Chris Am 21.01.2012 15:52, schrieb BÁLINT Bekény: 1. Attachment forward: previously attached files are listed on Update.html and you can check them to attach to the outgoing mail. (I don't understand why this kind of feature isn't in vanilla RT. Everybody downloads and then reuploads attachments if he or she wants to send it to an email address?). RT Training Sessions (http://bestpractical.com/services/training.html) * Boston March 5 6, 2012
Re: [rt-users] attachment improvements
Hi Ruslan,
2. Unique attachment session: RT temporary stores attachments
in $session{'Attachments'} and deletes this on Display.html, Update.html,
Create.html, ModifyAll.html and Bulk.html. The problem is that if you
start
a comment, attach a file and you open a ticket or start another comment,
etc.in another browser window or tab, your uploaded attachment will be
deleted from session. So later when you submit your comment there won't
be
your previously attached file. This is annoying for a lot of users that's
why I create unique session variable in every related page to store the
attachments.
Note: I think it is impossible to implement this with Callbacks only. It
needs patching or overlaying some files.
This is implemented in the repo and aimed at 4.2.
Good news. In that case I won't work on creating patches for this.
3. Multiple attach: there are flash solutions for multi-attach file but
I
don't like flash. Fortunately in HTML5 you can create input type=file
with multiple attribute. Modern browsers support it and allow users to
select more than one file at once. I implement this feature on Update,
Create and ModifyAll pages. Users like this more than I previously
supposed
and it was only a 20 minute work to implement. :)
Note: this will be another reason for IE users to change their browser :)
What happens with browsers that don't support this feature? If those
don't have problems and just allow users to upload one file then we
can consider this for core.
It is backward compatible so you can upload one file without any problem
with IE or older FF, Safari, Chrome, etc.
Do you care to send a patch against master branch?
Note that because of above change (2), code around attachments
upload is different, but actually it's better as we concentrated it in
one place.
Patch for master branch is attached.
IMPORTANT: I'm unable to test it but I hope it works well on this branch.
4. Attachment coloring and ordering: you can define categories in
SiteConfig
and also colors for these categories. On Display page you can set
category
for every file with one click. Files get the color of their categories.
You
can also order attachments list by category (color), filename, creator,
size
and date. There is a predefined category hidden. With this you can
hide an
attachment.
It's not my favorite improvement but this is very useful for companies
work
on long projects with lot of files.
Sounds like useful @Plugin.
If you need new callbacks for any code then you can send patches.
Thanks, I think it will help me a lot to create Plugins.
--
Bekeny
Docca OutSource IT Ltd.
From ab86ab8277fa9ed49a4a791180558d4c1b0364ae Mon Sep 17 00:00:00 2001
From: Balint Bekeny balint.bek...@docca.hu
Date: Sun, 22 Jan 2012 20:54:15 +0100
Subject: [PATCH 1/2] multiple attribute added to input type=file
---
share/html/Ticket/Elements/AddAttachments |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/share/html/Ticket/Elements/AddAttachments b/share/html/Ticket/Elements/AddAttachments
index 0086858..8021bcb 100644
--- a/share/html/Ticket/Elements/AddAttachments
+++ b/share/html/Ticket/Elements/AddAttachments
@@ -56,6 +56,6 @@
/tr
% } # end of if
-trtd class=label|/lAttach/:/tdtdinput name=Attach type=file /input type=submit class=button name=AddMoreAttach value=|/lAdd More Files/ /input type=hidden class=hidden name=UpdateAttach value=1 /
+trtd class=label|/lAttach/:/tdtdinput name=Attach type=file multiple=multiple /input type=submit class=button name=AddMoreAttach value=|/lAdd More Files/ /input type=hidden class=hidden name=UpdateAttach value=1 /
/td/tr
% $m-callback( %ARGS, CallbackName = 'End' );
--
1.7.2.5
From b421c45d917a41e8d98ae79bc6c9a26665fd0c81 Mon Sep 17 00:00:00 2001
From: Balint Bekeny balint.bek...@docca.hu
Date: Sun, 22 Jan 2012 21:30:12 +0100
Subject: [PATCH 2/2] handle multiple files attached
---
lib/RT/Interface/Web.pm | 17 +
share/html/Search/Bulk.html | 21 +
share/html/Ticket/Create.html| 23 ++-
share/html/Ticket/ModifyAll.html | 23 ++-
share/html/Ticket/Update.html| 23 ++-
5 files changed, 64 insertions(+), 43 deletions(-)
diff --git a/lib/RT/Interface/Web.pm b/lib/RT/Interface/Web.pm
index eefaab5..9c1c7cf 100644
--- a/lib/RT/Interface/Web.pm
+++ b/lib/RT/Interface/Web.pm
@@ -1678,12 +1678,13 @@ sub MakeMIMEEntity {
#TODO document what else this takes.
my %args = (
-Subject = undef,
-From= undef,
-Cc = undef,
-Body= undef,
-AttachmentFieldName = undef,
-Type= undef,
+Subject = undef,
+From = undef,
+Cc = undef,
+Body = undef,
+
Re: [rt-users] attachment improvements
2012/1/23 BÁLINT Bekény balint.bek...@docca.hu: Do you care to send a patch against master branch? Note that because of above change (2), code around attachments upload is different, but actually it's better as we concentrated it in one place. Patch for master branch is attached. IMPORTANT: I'm unable to test it but I hope it works well on this branch. Slightly misguided you. Mentioned change is not yet on master, it's in 4.2/web-attachs-processing branch. Took a look at the changes. Looks good and simple. -- Best regards, Ruslan. RT Training Sessions (http://bestpractical.com/services/training.html) * Boston March 5 6, 2012
Re: [rt-users] attachment improvements
Patch for master branch is attached. IMPORTANT: I'm unable to test it but I hope it works well on this branch. Slightly misguided you. Mentioned change is not yet on master, it's in 4.2/web-attachs-processing branch. Took a look at the changes. Looks good and simple. I think patch for this branch is more simple because it is not require to modify Create.html, etc. pages only the ProcessAttachments function in Web.pm. Should I create a patch for this branch also? -- Bekeny Docca OutSource IT Ltd. RT Training Sessions (http://bestpractical.com/services/training.html) * Boston March 5 6, 2012
Re: [rt-users] cannot get result of search Chinese character - centos 5.4
I had same problem Japanese Character ( RT3.8.11 ) Please check DBIx::SearchBuilder version. DBIx::SearchBuilder version 1.56 or 1.59, i can get result of search Japanese character. Howerver, DBIx::SearchBuilder version over 1.6.0, i can not ger result of search Japanese character. 2012/1/21 sunnavy sunn...@bestpractical.com: I failed to reproduce this on centos 5.7 with shipped perl5.8.8, and I tried both stardalone server and apache+mod_fastcgi. It would be great if there are more details of the configuration. sunnavy On 12-01-20 22:11, sunnavy wrote: If you run RT with standalone server, is the problem still there? standalone server, I mean you start RT with something like `/path/to/rt/sbin/rt-server --port 8080` sunnavy On 11-12-29 08:53, nectar wrote: Sir, Looks like can search Chinese character when use Perl 5.10 instead of Perl 5.8.8 on CentOS 5. -- Jia RT Training Sessions (http://bestpractical.com/services/training.html) * Boston March 5 6, 2012 RT Training Sessions (http://bestpractical.com/services/training.html) * Boston March 5 6, 2012 RT Training Sessions (http://bestpractical.com/services/training.html) * Boston March 5 6, 2012 -- --- ryo.og...@gmail.com RT Training Sessions (http://bestpractical.com/services/training.html) * Boston March 5 6, 2012
