Re: [rt-users] Minor patch

[Jesse Vincent]

Ok. Applied :)
On Oct 9, 2007, at 1:35 AM, Brian Gallew wrote:


Jesse Vincent wrote:
Thanks for the patch. That looks like a kind of strange place to  
put that skip. Is there a reason it's not at the start of the loop?


Because I backtracked to the first place that looked reasonable.   
8-)


I have no preferences here, as long as it works!
___
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users

Community help: http://wiki.bestpractical.com
Commercial support: [EMAIL PROTECTED]


Discover RT's hidden secrets with RT Essentials from O'Reilly  
Media. Buy a copy at http://rtbook.bestpractical.com






PGP.sig
Description: This is a digitally signed message part
___
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users

Community help: http://wiki.bestpractical.com
Commercial support: [EMAIL PROTECTED]


Discover RT's hidden secrets with RT Essentials from O'Reilly Media. 
Buy a copy at http://rtbook.bestpractical.com

Re: [rt-users] Minor patch

[Brian Gallew]

Jesse Vincent wrote:
Thanks for the patch. That looks like a kind of strange place to put 
that skip. Is there a reason it's not at the start of the loop?


Because I backtracked to the first place that looked reasonable.  8-)

I have no preferences here, as long as it works!
___
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users

Community help: http://wiki.bestpractical.com
Commercial support: [EMAIL PROTECTED]


Discover RT's hidden secrets with RT Essentials from O'Reilly Media. 
Buy a copy at http://rtbook.bestpractical.com

[rt-users] Minor patch

[Brian Gallew]

The following patch prevents an error message about Unknown update 
type on my RT installation whenever I try to update a multi-choice 
custom field with categories.


--- lib/RT/Interface/Web.pm 2007-07-19 22:30:01.0 +0300
+++ local/lib/RT/Interface/Web.pm   2007-10-07 15:10:17.0 +0300
@@ -1281,6 +1281,7 @@
s/\r//g foreach @values;
}
@values = grep defined  $_ ne '', @values;
+next if $arg =~ /Category$/;

if ( $arg eq 'AddValue' || $arg eq 'Value' ) {
foreach my $value (@values) {

___
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users

Community help: http://wiki.bestpractical.com
Commercial support: [EMAIL PROTECTED]


Discover RT's hidden secrets with RT Essentials from O'Reilly Media. 
Buy a copy at http://rtbook.bestpractical.com

Re: [rt-users] Minor patch

[Jesse Vincent]

Thanks for the patch. That looks like a kind of strange place to put  
that skip. Is there a reason it's not at the start of the loop?


-jesse

On Oct 8, 2007, at 4:03 AM, Brian Gallew wrote:

The following patch prevents an error message about Unknown update  
type on my RT installation whenever I try to update a multi-choice  
custom field with categories.


--- lib/RT/Interface/Web.pm 2007-07-19 22:30:01.0 +0300
+++ local/lib/RT/Interface/Web.pm   2007-10-07  
15:10:17.0 +0300

@@ -1281,6 +1281,7 @@
s/\r//g foreach @values;
}
@values = grep defined  $_ ne '', @values;
+next if $arg =~ /Category$/;
if ( $arg eq 'AddValue' || $arg eq 'Value' ) {
foreach my $value (@values) {

___
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users

Community help: http://wiki.bestpractical.com
Commercial support: [EMAIL PROTECTED]


Discover RT's hidden secrets with RT Essentials from O'Reilly  
Media. Buy a copy at http://rtbook.bestpractical.com






PGP.sig
Description: This is a digitally signed message part
___
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users

Community help: http://wiki.bestpractical.com
Commercial support: [EMAIL PROTECTED]


Discover RT's hidden secrets with RT Essentials from O'Reilly Media. 
Buy a copy at http://rtbook.bestpractical.com