[rtc-linux] Re: [PATCH v2 3/4] rtc: cros-ec: add cros-ec-rtc driver.

2017-02-14 Thread Enric Balletbo i Serra
Hi Lee, On 23/01/17 13:14, Lee Jones wrote: > On Mon, 23 Jan 2017, Alexandre Belloni wrote: > >> On 19/01/2017 at 13:30:31 +0100, Enric Balletbo i Serra wrote : >>> From: Stephen Barber <smbar...@chromium.org> >>> >>> On platforms with a Chrome OS EC,

[rtc-linux] Re: [PATCH v2 3/4] rtc: cros-ec: add cros-ec-rtc driver.

2017-02-14 Thread Enric Balletbo i Serra
On 14/02/17 16:26, Lee Jones wrote: > On Tue, 14 Feb 2017, Enric Balletbo i Serra wrote: > >> Hi Lee, >> >> On 23/01/17 13:14, Lee Jones wrote: >>> On Mon, 23 Jan 2017, Alexandre Belloni wrote: >>> >>>> On 19/01/2017 at 13:30:31 +0100, Enr

[rtc-linux] [PATCH v3 1/4] mfd: cros_ec: Add helper for event notifier.

2017-02-14 Thread Enric Balletbo i Serra
From: Gwendal Grignou <gwen...@chromium.org> Add cros_ec_get_event() entry point to retrieve event within functions called by the notifier. Signed-off-by: Gwendal Grignou <gwen...@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> Acked-by:

[rtc-linux] [PATCH v3 4/4] mfd: cros_ec: add RTC as mfd subdevice

2017-02-14 Thread Enric Balletbo i Serra
From: Stephen Barber <smbar...@chromium.org> If the EC supports RTC host commands, expose an RTC device. Signed-off-by: Stephen Barber <smbar...@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> Acked-by: Benson Leung <ble...@chromium.org&

[rtc-linux] [PATCH v3 3/4] rtc: cros-ec: add cros-ec-rtc driver.

2017-02-14 Thread Enric Balletbo i Serra
From: Stephen Barber <smbar...@chromium.org> On platforms with a Chrome OS EC, the EC can function as a simple RTC. Add a basic driver with this functionality. Signed-off-by: Stephen Barber <smbar...@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balle...@colla

[rtc-linux] [PATCH v3 2/4] mfd: cros_ec: Introduce RTC commands and events definitions.

2017-02-14 Thread Enric Balletbo i Serra
From: Stephen Barber <smbar...@chromium.org> The EC can function as a simple RT, this patch adds the RTC related definitions needed by the rtc-cros-ec driver. Signed-off-by: Stephen Barber <smbar...@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com

[rtc-linux] [PATCH v2 1/4] mfd: cros_ec: Add helper for event notifier.

2017-01-19 Thread Enric Balletbo i Serra
From: Gwendal Grignou <gwen...@chromium.org> Add cros_ec_get_event() entry point to retrieve event within functions called by the notifier. Signed-off-by: Gwendal Grignou <gwen...@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> Acked-by:

[rtc-linux] [PATCH v2 2/4] mfd: cros_ec: Introduce RTC commands and events definitions.

2017-01-19 Thread Enric Balletbo i Serra
From: Stephen Barber <smbar...@chromium.org> The EC can function as a simple RT, this patch adds the RTC related definitions needed by the rtc-cros-ec driver. Signed-off-by: Stephen Barber <smbar...@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com

[rtc-linux] [PATCH v2 4/4] mfd: cros_ec: add RTC as mfd subdevice

2017-01-19 Thread Enric Balletbo i Serra
From: Stephen Barber <smbar...@chromium.org> If the EC supports RTC host commands, expose an RTC device. Signed-off-by: Stephen Barber <smbar...@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> --- drivers/platform/chrome/

[rtc-linux] [PATCH 4/4] mfd: cros_ec: add RTC as mfd subdevice

2017-01-11 Thread Enric Balletbo i Serra
From: Stephen Barber <smbar...@chromium.org> If the EC supports RTC host commands, expose an RTC device. Signed-off-by: Stephen Barber <smbar...@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> --- drivers/platform/chrome/

[rtc-linux] [PATCH 7/7] mfd: cros_ec: add RTC as mfd subdevice

2017-03-24 Thread Enric Balletbo i Serra
From: Stephen Barber <smbar...@chromium.org> If the EC supports RTC host commands, expose an RTC device. Signed-off-by: Stephen Barber <smbar...@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> --- drivers/mfd/cros_ec.c | 18

[rtc-linux] [PATCH 1/7] mfd: cros-ec: Fix host command buffer size

2017-03-24 Thread Enric Balletbo i Serra
sponse from the Chrome EC when is connected via SPI. Signed-off-by: Vic Yang <victory...@google.com> Tested-by: Enric Balletbo i Serra --- This patch is a FIX, and I think that would be interesting see it merged in this release cycle. This should go through the MFD tree and can be picked i

[rtc-linux] [PATCH 0/7] mfd: cros-ec: Some fixes and improvements.

2017-03-24 Thread Enric Balletbo i Serra
/17/321 Best regards, Enric Balletbo i Serra (3): iio: cros_ec_sensors: Fix return value to get raw and calibbias data. iio: cros_ec_sensors: Use devm to setup the triggered buffer. mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev. Stephen Barber (3): mfd: cros_ec

[rtc-linux] [PATCH 3/7] iio: cros_ec_sensors: Use devm to setup the triggered buffer.

2017-03-24 Thread Enric Balletbo i Serra
Use resourced managed function devm_iio_triggered_buffer_setup to make error path simpler and be able to get rid of the remove function. Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> --- This is an improvement that can wait to 4.12 merge window, again can be

[rtc-linux] [PATCH 4/7] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev.

2017-03-24 Thread Enric Balletbo i Serra
independent the IIO driver from the character device as also has no sense. Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> --- As pointed by Lee Jones in this thread [1] we should not use the MFD API outside of MFD. For this reason the cros-ec-rtc did not get accept

[rtc-linux] [PATCH 2/7] iio: cros_ec_sensors: Fix return value to get raw and calibbias data.

2017-03-24 Thread Enric Balletbo i Serra
ChromeOS EC Contiguous Sensors driver) Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> --- This is another FIX, so would be interesting see it merged in this release cycle too. Like the above patch can be picked independently of the other patches and should go throu

[rtc-linux] [PATCH 5/7] mfd: cros_ec: Introduce RTC commands and events definitions.

2017-03-24 Thread Enric Balletbo i Serra
From: Stephen Barber <smbar...@chromium.org> The EC can function as a simple RT, this patch adds the RTC related definitions needed by the rtc-cros-ec driver. Signed-off-by: Stephen Barber <smbar...@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com

[rtc-linux] Re: [PATCH v3 4/4] mfd: cros_ec: add RTC as mfd subdevice

2017-03-15 Thread Enric Balletbo i Serra
Hi Lee, On 15/03/17 11:24, Lee Jones wrote: > On Tue, 14 Mar 2017, Enric Balletbo i Serra wrote: >> On 14/03/17 14:59, Lee Jones wrote: >>> On Tue, 14 Feb 2017, Enric Balletbo i Serra wrote: >>> >>>> From: Stephen Barber <smbar...@chromium.org> &

[rtc-linux] Re: [PATCH 1/7] mfd: cros-ec: Fix host command buffer size

2017-04-03 Thread Enric Balletbo i Serra
On 03/04/17 16:30, Lee Jones wrote: > On Mon, 03 Apr 2017, Lee Jones wrote: > >> On Fri, 24 Mar 2017, Enric Balletbo i Serra wrote: >> >>> From: Vic Yang <victory...@google.com> >>> >>> For SPI, we can get up to 32 additional bytes for respon

[rtc-linux] Re: [PATCH 7/7] mfd: cros_ec: add RTC as mfd subdevice

2017-04-03 Thread Enric Balletbo i Serra
On 03/04/17 16:25, Lee Jones wrote: > On Fri, 24 Mar 2017, Enric Balletbo i Serra wrote: > >> From: Stephen Barber <smbar...@chromium.org> >> >> If the EC supports RTC host commands, expose an RTC device. >> >> Signed-off-by: Stephen Barber <s

[rtc-linux] [PATCH v2 5/5] mfd: cros_ec: add RTC as mfd subdevice

2017-04-03 Thread Enric Balletbo i Serra
From: Stephen Barber <smbar...@chromium.org> If the EC supports RTC host commands, expose an RTC device. Signed-off-by: Stephen Barber <smbar...@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> --- Changes since v1: - Use PLATFORM

[rtc-linux] [PATCH v2 2/5] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev.

2017-04-03 Thread Enric Balletbo i Serra
independent the IIO driver from the character device as also has no sense. Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> Acked-by: Jonathan Cameron <ji...@kernel.org> --- As pointed by Lee Jones in this thread [1] we should not use the MFD API outside of MFD. For

[rtc-linux] [PATCH v2 4/5] rtc: cros-ec: add cros-ec-rtc driver.

2017-04-03 Thread Enric Balletbo i Serra
From: Stephen Barber <smbar...@chromium.org> On platforms with a Chrome OS EC, the EC can function as a simple RTC. Add a basic driver with this functionality. Signed-off-by: Stephen Barber <smbar...@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balle...@colla

[rtc-linux] [PATCH v2 3/5] mfd: cros_ec: Introduce RTC commands and events definitions.

2017-04-03 Thread Enric Balletbo i Serra
From: Stephen Barber <smbar...@chromium.org> The EC can function as a simple RT, this patch adds the RTC related definitions needed by the rtc-cros-ec driver. Signed-off-by: Stephen Barber <smbar...@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com

[rtc-linux] [PATCH v2 1/5] mfd: cros-ec: Fix host command buffer size

2017-04-03 Thread Enric Balletbo i Serra
sponse from the Chrome EC when is connected via SPI. Signed-off-by: Vic Yang <victory...@google.com> Tested-by: Enric Balletbo i Serra <enric.balle...@collabora.com> --- This patch is a FIX, and I think that would be interesting see it merged in this release cycle. This should go th

[rtc-linux] Re: [PATCH v2 2/5] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev.

2017-04-20 Thread Enric Balletbo i Serra
On 11/04/17 11:19, Lee Jones wrote: > On Mon, 03 Apr 2017, Enric Balletbo i Serra wrote: > >> The cros_ec_dev driver should be used only to expose the Chrome OS Embedded >> Controller to user-space and should not be used to add MFD devices by >> calling mfd_add_d

[rtc-linux] Re: [PATCH v2 5/5] mfd: cros_ec: add RTC as mfd subdevice

2017-04-20 Thread Enric Balletbo i Serra
Lee, On 11/04/17 11:48, Lee Jones wrote: > On Mon, 03 Apr 2017, Enric Balletbo i Serra wrote: > >> From: Stephen Barber <smbar...@chromium.org> >> >> If the EC supports RTC host commands, expose an RTC device. > > This could be made nicer by checking RTC co

[rtc-linux] [PATCH v3 0/4] mfd: cros-ec: Some fixes and improvements.

2017-07-12 Thread Enric Balletbo i Serra
series as was already picked. - Patch 2/5: Acked-by: Jonathan Cameron <***@kernel.org> [1] https://www.spinics.net/lists/kernel/msg2465099.html [2] https://lkml.org/lkml/2017/3/17/319 [3] https://lkml.org/lkml/2017/3/17/321 Best regards, Enric Balletbo i Serra (1): mfd: cros_ec: G

[rtc-linux] [PATCH v3 2/4] mfd: cros_ec: Introduce RTC commands and events definitions.

2017-07-12 Thread Enric Balletbo i Serra
From: Stephen Barber <smbar...@chromium.org> The EC can function as a simple RT, this patch adds the RTC related definitions needed by the rtc-cros-ec driver. Signed-off-by: Stephen Barber <smbar...@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com

[rtc-linux] [PATCH v3 3/4] rtc: cros-ec: add cros-ec-rtc driver.

2017-07-12 Thread Enric Balletbo i Serra
From: Stephen Barber <smbar...@chromium.org> On platforms with a Chrome OS EC, the EC can function as a simple RTC. Add a basic driver with this functionality. Signed-off-by: Stephen Barber <smbar...@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balle...@colla

[rtc-linux] [PATCH v3 1/4] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev.

2017-07-12 Thread Enric Balletbo i Serra
independent the IIO driver from the character device as also has no sense. Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> Acked-by: Jonathan Cameron <ji...@kernel.org> --- .../iio/common/cros_ec_sensors/cros_ec_sensors.c | 8 - .../common/cro

[rtc-linux] [PATCH v3 4/4] mfd: cros_ec: add RTC as mfd subdevice

2017-07-12 Thread Enric Balletbo i Serra
From: Stephen Barber <smbar...@chromium.org> If the EC supports RTC host commands, expose an RTC device. Signed-off-by: Stephen Barber <smbar...@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> --- drivers/mfd/cros_ec.c | 18

[rtc-linux] [PATCH v4 1/2] mfd: cros_ec: Introduce RTC commands and events definitions.

2017-11-10 Thread Enric Balletbo i Serra
From: Stephen Barber <smbar...@chromium.org> The EC can function as a simple RT, this patch adds the RTC related definitions needed by the rtc-cros-ec driver. Signed-off-by: Stephen Barber <smbar...@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com

[rtc-linux] [PATCH v4 2/2] rtc: cros-ec: add cros-ec-rtc driver.

2017-11-10 Thread Enric Balletbo i Serra
From: Stephen Barber <smbar...@chromium.org> On platforms with a Chrome OS EC, the EC can function as a simple RTC. Add a basic driver with this functionality. Signed-off-by: Stephen Barber <smbar...@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balle...@colla