[rtc-linux] Re: [PATCH 2/2] time: alarmtimer: Add the trcepoints for alarmtimer

2016-09-20 Thread Thomas Gleixner
On Sun, 18 Sep 2016, Baolin Wang wrote: > +DECLARE_EVENT_CLASS(alarm_setting, What is alarm_setting? Without looking at the DEFINE_EVENT which uses this I cannot decode the meaning. > + TP_STRUCT__entry( > + __field(unsigned char, second) > + __field(unsigned char,

[rtc-linux] Re: [PATCH 1/2] rtc: Add some dummy static inline functions

2016-09-20 Thread Baolin Wang
Hi, On 21 September 2016 at 05:36, Thomas Gleixner wrote: > On Sun, 18 Sep 2016, Baolin Wang wrote: > >> The patch 2 in this patchset adding tracepoints for alarmtimers will build >> failed on S390 platform, due to S390 defconfig did not define CONFIG_RTC_LIB >> macro to

[rtc-linux] Re: [PATCH 2/2] time: alarmtimer: Add the trcepoints for alarmtimer

2016-09-20 Thread Baolin Wang
On 21 September 2016 at 06:27, Thomas Gleixner wrote: > On Sun, 18 Sep 2016, Baolin Wang wrote: >> +DECLARE_EVENT_CLASS(alarm_setting, > > What is alarm_setting? Without looking at the DEFINE_EVENT which uses this > I cannot decode the meaning. Will rename it. > >> +