[rtc-linux] Re: [PATCH v2] rtc: cmos: remove all __exit_p annotations
On Tue, Oct 18, 2016 at 04:16:39PM +0200, Alexandre Belloni wrote: > Hi, > > On 18/10/2016 at 13:55:53 +0200, Corentin Labbe wrote : > > Change since v1: > > - restored __exit for module_exit function > > > > ---8<--- > > I don't think this is the proper scissor symbol for git. At least, it is > no recognized by patchwork and messes your patch. > > > From c04a24acebee4b4432afa7a2a7d4cfe114cc9a40 Mon Sep 17 00:00:00 2001 > > From: Corentin Labbe > > Date: Mon, 17 Oct 2016 14:17:49 +0200 > > Subject: [PATCH v2] rtc: cmos: remove all __exit_p annotations > > > > I got the following stack trace under qemu: > > [...] > > When cmos_set_alarm() is called dev is NULL and so trigger the deref via > > cmos->irq > > > > The problem comes from that the device is removed but no remove function > > are called due to _exit_p(). > > > > This patch remove all _exit_p() annotation. > > > > Signed-off-by: Corentin Labbe > > --- > > > The changelog should go here. > > > drivers/rtc/rtc-cmos.c | 10 +- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > Sorry, could I just resent it with PATCH RESENT v2 ? or does I need to bump it to v3. Regards -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[rtc-linux] Re: [PATCH v2] rtc: cmos: remove all __exit_p annotations
On 18/10/2016 at 16:24:53 +0200, LABBE Corentin wrote : > On Tue, Oct 18, 2016 at 04:16:39PM +0200, Alexandre Belloni wrote: > > Hi, > > > > On 18/10/2016 at 13:55:53 +0200, Corentin Labbe wrote : > > > Change since v1: > > > - restored __exit for module_exit function > > > > > > ---8<--- > > > > I don't think this is the proper scissor symbol for git. At least, it is > > no recognized by patchwork and messes your patch. > > > > > From c04a24acebee4b4432afa7a2a7d4cfe114cc9a40 Mon Sep 17 00:00:00 2001 > > > From: Corentin Labbe > > > Date: Mon, 17 Oct 2016 14:17:49 +0200 > > > Subject: [PATCH v2] rtc: cmos: remove all __exit_p annotations > > > > > > I got the following stack trace under qemu: > > > > [...] > > > When cmos_set_alarm() is called dev is NULL and so trigger the deref via > > > cmos->irq > > > > > > The problem comes from that the device is removed but no remove function > > > are called due to _exit_p(). > > > > > > This patch remove all _exit_p() annotation. > > > > > > Signed-off-by: Corentin Labbe > > > --- > > > > > > The changelog should go here. > > > > > drivers/rtc/rtc-cmos.c | 10 +- > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > Sorry, could I just resent it with PATCH RESENT v2 ? or does I need to bump > it to v3. > Resending v2 is fine -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[rtc-linux] Re: [PATCH v2] rtc: cmos: remove all __exit_p annotations
Hi, On 18/10/2016 at 13:55:53 +0200, Corentin Labbe wrote : > Change since v1: > - restored __exit for module_exit function > > ---8<--- I don't think this is the proper scissor symbol for git. At least, it is no recognized by patchwork and messes your patch. > From c04a24acebee4b4432afa7a2a7d4cfe114cc9a40 Mon Sep 17 00:00:00 2001 > From: Corentin Labbe > Date: Mon, 17 Oct 2016 14:17:49 +0200 > Subject: [PATCH v2] rtc: cmos: remove all __exit_p annotations > > I got the following stack trace under qemu: [...] > When cmos_set_alarm() is called dev is NULL and so trigger the deref via > cmos->irq > > The problem comes from that the device is removed but no remove function > are called due to _exit_p(). > > This patch remove all _exit_p() annotation. > > Signed-off-by: Corentin Labbe > --- The changelog should go here. > drivers/rtc/rtc-cmos.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
