Re: [PATCH] bsps/sparc: Fix BSS initialization

2014-05-14 Thread Daniel Hellstrom
On 05/14/2014 10:31 AM, Sebastian Huber wrote: On 2014-05-14 09:37, Daniel Hellstrom wrote: Hello Sebastian, I think the patch is correct, however I would rather see that you use g4 instead of g2 to increment, that way you don't need the move either. Ok, see follow up patch. Ok, thanks.

Re: [PATCH] bsps/sparc: Fix BSS initialization

2014-05-14 Thread Sebastian Huber
On 2014-05-14 09:37, Daniel Hellstrom wrote: Hello Sebastian, I think the patch is correct, however I would rather see that you use g4 instead of g2 to increment, that way you don't need the move either. Ok, see follow up patch. Looking in the area of the code that you patch, it seems as if

Re: [PATCH] bsps/sparc: Fix BSS initialization

2014-05-14 Thread Daniel Hellstrom
Hello Sebastian, I think the patch is correct, however I would rather see that you use g4 instead of g2 to increment, that way you don't need the move either. Looking in the area of the code that you patch, it seems as if this code hasn't been run. I have a TODO since long to go over this code,

[PATCH] bsps/sparc: Fix BSS initialization

2014-05-13 Thread Sebastian Huber
Use __bss_start available via %g4 to clear the BSS section. The usage of _edata resulted in a copy of [_edata, __bss_start) from ROM to RAM and then a clear to zero of this area. Clear now only [__bss_start, _end). --- c/src/lib/libbsp/sparc/shared/start/start.S |3 +-- 1 files changed, 1 in