Re: [PATCH 1/7] bsps/sparc: Make local functions for amba plug&play static.

2014-03-13 Thread Joel Sherrill
No comment? Looks OK except I wish we had spotted not being when it was first merged. Can you please install it to bsp/. That goes for other .h files specific to the BSP. We try to keep from polluting the top of the INCLUDE directory since this namespace is owned by POSIX and other standards.

Re: [PATCH 1/7] bsps/sparc: Make local functions for amba plug&play static.

2014-03-13 Thread Gedare Bloom
OK On Thu, Mar 13, 2014 at 10:19 AM, Daniel Cederman wrote: > --- > c/src/lib/libbsp/sparc/shared/amba/ambapp.c | 12 ++-- > c/src/lib/libbsp/sparc/shared/amba/ambapp_freq.c |2 +- > c/src/lib/libbsp/sparc/shared/amba/ambapp_names.c |1 + > c/src/lib/libbsp/sparc/shared/