Re: [RDT-Dev] Two severe bugs in HEAD
Thomas, all, On 4/4/07, Christopher Williams [EMAIL PROTECTED] wrote: Thomas, Funny you mention this... On 4/4/07, Thomas Corbat [EMAIL PROTECTED] wrote: 2. When creating a new ruby class the file is created correctly but it is empty and an error occures: Creation of element failed. And an exception is thrown. Both errors occure under Windows (Vista) and Linux aswell. I'll have to take a look at this one today if I have time. OK, I managed to fix this one as well (and improve it a bit too). It shouldn't throw errors anymore, it should convert the class name from CamelCase to camel_case.rb for file names, and it now successfully opens the file in an editor after the wizard completes. Thanks, Chris -- http://cwilliams.textdriven.com - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ Rubyeclipse-development mailing list Rubyeclipse-development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rubyeclipse-development
Re: [RDT-Dev] Two severe bugs in HEAD
Thomas, Funny you mention this... On 4/4/07, Thomas Corbat [EMAIL PROTECTED] wrote: Hello I've encountered two inconvenient bugs in the HEAD too: 1. When writing a comment at the end of a line the carret position is set before every character which is entered. For example when typing #comment it results in tnemmoc#. When having a white space or any other characters behind the carret it works correctly. I just ran into and fixed this problem. The new stuff in trunk should work. 2. When creating a new ruby class the file is created correctly but it is empty and an error occures: Creation of element failed. And an exception is thrown. Both errors occure under Windows (Vista) and Linux aswell. I'll have to take a look at this one today if I have time. OK, so Friday release may not happen. Argh. If not, then I say we aim for Tuesday when Markus is back from vacation... Thanks, Chris - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ Rubyeclipse-development mailing list Rubyeclipse-development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rubyeclipse-development
Re: [RDT-Dev] Two severe bugs in HEAD
Great. I can confirm that the comments now work as expected. It's almost driven me crazy as right now I'm improving the refactorings to retain the comments which results in writing many of them for testing... Christopher Williams wrote: Thomas, Funny you mention this... On 4/4/07, *Thomas Corbat* [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: Hello I've encountered two inconvenient bugs in the HEAD too: 1. When writing a comment at the end of a line the carret position is set before every character which is entered. For example when typing #comment it results in tnemmoc#. When having a white space or any other characters behind the carret it works correctly. I just ran into and fixed this problem. The new stuff in trunk should work. 2. When creating a new ruby class the file is created correctly but it is empty and an error occures: Creation of element failed. And an exception is thrown. Both errors occure under Windows (Vista) and Linux aswell. I'll have to take a look at this one today if I have time. OK, so Friday release may not happen. Argh. If not, then I say we aim for Tuesday when Markus is back from vacation... Thanks, Chris - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Rubyeclipse-development mailing list Rubyeclipse-development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rubyeclipse-development - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Rubyeclipse-development mailing list Rubyeclipse-development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rubyeclipse-development
Re: [RDT-Dev] Two severe bugs in HEAD
murphee, I just ran a quick smoke test on launching a Test::Unit testcase and I didn't see the problem you're mentioning. Can you send along the file (and make sure you're using the latest from svn). Thanks, Chris On 3/17/07, Werner Schuster (murphee) [EMAIL PROTECTED] wrote: howdy, there seem to be some problems in the current head: - Test:Unit launches seem to be missing IRubyLaunchConfigurationConstants.ATTR_FILE_NAME attributes; This causes the launch to fail and a error dialog Main type not specified to pop up; I guess the org.rubypeople.rdt.testunit.launcher.TestUnitMainTab needs to set this attribute to the filename in the launch object; (it does that, but only for the CONTAINER attribute); - I attached a file that can't be opened with the Ruby editor, it causes this exception (see below); I presume there's some bug in the SyntaxHighlighting code, but I don't have time to look into this right now; java.lang.IllegalArgumentException: Argument not valid at org.eclipse.swt.SWT.error(SWT.java:3462) at org.eclipse.swt.SWT.error(SWT.java:3401) at org.eclipse.swt.SWT.error(SWT.java:3372) at org.eclipse.swt.custom.StyledText.setStyleRanges(StyledText.java:7735) at org.eclipse.swt.custom.StyledText.setStyleRanges(StyledText.java:7829) at org.eclipse.jface.text.TextViewer.applyTextPresentation(TextViewer.java :4405) at org.eclipse.jface.text.TextViewer.changeTextPresentation(TextViewer.java :4457) at org.eclipse.jface.text.presentation.PresentationReconciler.applyTextRegionCollection (PresentationReconciler.java:578) at org.eclipse.jface.text.presentation.PresentationReconciler.processDamage( PresentationReconciler.java:567) at org.eclipse.jface.text.presentation.PresentationReconciler.access$3( PresentationReconciler.java:563) at org.eclipse.jface.text.presentation.PresentationReconciler$InternalListener.inputDocumentChanged (PresentationReconciler.java:119) at org.eclipse.jface.text.TextViewer.fireInputDocumentChanged(TextViewer.java :2660) at org.eclipse.jface.text.TextViewer.setDocument(TextViewer.java:2709) at org.eclipse.jface.text.source.SourceViewer.setDocument(SourceViewer.java :518) at org.eclipse.jface.text.source.projection.ProjectionViewer.setDocument( ProjectionViewer.java:370) at org.eclipse.jface.text.source.SourceViewer.setDocument(SourceViewer.java :473) at org.eclipse.ui.texteditor.AbstractTextEditor.initializeSourceViewer( AbstractTextEditor.java:3454) at org.eclipse.ui.texteditor.AbstractTextEditor.createPartControl( AbstractTextEditor.java:3018) at org.eclipse.ui.texteditor.StatusTextEditor.createPartControl( StatusTextEditor.java:53) at org.eclipse.ui.texteditor.AbstractDecoratedTextEditor.createPartControl( AbstractDecoratedTextEditor.java:373) at org.rubypeople.rdt.internal.ui.rubyeditor.RubyAbstractEditor.createPartControl (RubyAbstractEditor.java:327) at org.rubypeople.rdt.internal.ui.rubyeditor.RubyEditor.createPartControl( RubyEditor.java:276) at org.eclipse.ui.internal.EditorReference.createPartHelper( EditorReference.java:662) at org.eclipse.ui.internal.EditorReference.createPart(EditorReference.java :421) at org.eclipse.ui.internal.WorkbenchPartReference.getPart( WorkbenchPartReference.java:586) at org.eclipse.ui.internal.EditorReference.getEditor(EditorReference.java :257) at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditorBatched( WorkbenchPage.java:2598) at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java :2524) at org.eclipse.ui.internal.WorkbenchPage.access$12(WorkbenchPage.java:2516) at org.eclipse.ui.internal.WorkbenchPage$10.run(WorkbenchPage.java :2501) at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java :67) at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2496) at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2480) at org.eclipse.ui.actions.OpenWithMenu.openEditor(OpenWithMenu.java :334) at org.eclipse.ui.actions.OpenWithMenu.access$0(OpenWithMenu.java:326) at org.eclipse.ui.actions.OpenWithMenu$2.handleEvent(OpenWithMenu.java:190) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1097) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java :3238) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2905) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2264) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2228) at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2103) at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:457) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java :289) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java :452) at
Re: [RDT-Dev] Two severe bugs in HEAD
Christopher Williams wrote: murphee, I just ran a quick smoke test on launching a Test::Unit testcase and I didn't see the problem you're mentioning. Can you send along the file (and make sure you're using the latest from svn). Yes, I'm using the latest version from svn. What does your smoke test look like? I created a new Test::Unit launch (in the LaunchConfiguration dialog) and ran that - from stepping through the code, I found the problem in: org.rubypeople.rdt.launching.RubyLaunchDelegate.launch(ILaunchConfiguration configuration, String mode, ILaunch launch, IProgressMonitor monitor) in line 51: String mainTypeName = verifyFileToLaunch(configuration); This returns null, because: TestUnitLaunchConfigurationDelegate .getFileToLaunch(ILaunchConfiguration configuration) String mainType = configuration.getAttribute( IRubyLaunchConfigurationConstants.ATTR_FILE_NAME,(String) null); returns null, because the LaunchConfiguration tab hasn't set the IRubyLaunchConfigurationConstants.ATTR_FILE_NAME value. Do you get this behavior? I fixed it (for me) by setting the IRubyLaunchConfigurationConstants.ATTR_FILE_NAME in the setDefaults method in the LaunchConfiguration tab; murphee - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Rubyeclipse-development mailing list Rubyeclipse-development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rubyeclipse-development
