Re: [Rails-core] Delegate default value option

2013-12-16 Thread Amiel Martin
I like this idea and would use it. -Amiel http://carnesmedia.com On Fri, Dec 13, 2013 at 2:44 PM, Scott Johnson 7.scot...@gmail.com wrote: I find I often use delegate and many nil guards in my facades. Adding a default_value option to delegate would simplify this, but I am interested how

Re: [Rails-core] Delegate default value option

2013-12-16 Thread Scott Johnson
Thanks. I will work up a pull request and see if I can get it added. On Mon, Dec 16, 2013 at 11:37 AM, Amiel Martin am...@carnesmedia.comwrote: I like this idea and would use it. -Amiel http://carnesmedia.com On Fri, Dec 13, 2013 at 2:44 PM, Scott Johnson 7.scot...@gmail.comwrote: I

Re: [Rails-core] Delegate default value option

2013-12-16 Thread Rafael Mendonça França
What is the advantage over? def name person.name || end I am really against adding new options to delegate method since all that it does is define methods like this in the class. Rafael Mendonça França http://twitter.com/rafaelfranca https://github.com/rafaelfranca On Mon, Dec 16, 2013 at

Re: [Rails-core] Delegate default value option

2013-12-16 Thread Matt Jones
On Dec 13, 2013, at 5:44 PM, Scott Johnson wrote: I find I often use delegate and many nil guards in my facades. Adding a default_value option to delegate would simplify this, but I am interested how others feel about it. Implementation would look something like: class PersonFacade

Re: [Rails-core] Delegate default value option

2013-12-16 Thread Scott Johnson
This is why I wanted to ask the group before making the pull request. As for Rafael's question -- it is no different from writing the methods out, but either is delegate. I just found that many times where I would have used delegate I ended up writing out the individual methods only to add || =

Re: [Rails-core] Delegate default value option

2013-12-16 Thread Rafael Mendonça França
We already rejected this feature before. See https://github.com/rails/rails/pull/11908 Rafael Mendonça França http://twitter.com/rafaelfranca https://github.com/rafaelfranca On Mon, Dec 16, 2013 at 6:20 PM, Scott Johnson 7.scot...@gmail.com wrote: This is why I wanted to ask the group before

Re: [Rails-core] UrlHelper: Extracting url_for to separate module

2013-12-16 Thread Pier-Olivier Thibault
url_for is not a trivial thing, it's intertwined with many aspect of rails. I agree that it's not trivial to use url_for to link dynamically different engine's routing. I think I understand your frustration with the routing system and rails::engine. On Monday, December 16, 2013 1:11:38 PM