[Rails-core] ActiveJob allow passing options to underlying library

2015-02-09 Thread John Negron
ActiveJob is a great addition to Rails. Many supported backends like DelayedJob support other options than what is being passed into the enqueue adapter methods. It would be great if the set method could delegate options into the queue adapters. For example, DelayedJob has priority set at the

Re: [Rails-core] find_by inconsistent return message

2015-02-09 Thread John Mileham
What about the security ramifications of logging potentially sensitive information? IDs can be sensitive, but often far less than other fields. There are legitimate use cases for using find_by on values that you'd prefer not to be logged or known by the end user. Making more-informative error

Re: [Rails-core] find_by inconsistent return message

2015-02-09 Thread Matt Jones
On Feb 8, 2015, at 11:07 AM, Иван Бишевац ivan.bise...@gmail.com wrote: User.find(1) for no record with gives: def test_error_message begin User.find(1) rescue ActiveRecord::RecordNotFound = e message = e.message end assert_equal message, Couldn't find User with