[Rails-core] [ActiveJob] PR #24921 (testing recursively queued jobs)

2016-09-22 Thread rchekaluk
Hello! ActiveJob PR https://github.com/rails/rails/pull/24921 has been reviewed and is nearly ready for merging (awaiting final feedback from the Rails Team). Can this be moved along? (I'm motivated to create additional ActiveJob PRs, but would like to see closure on this one first). Thanks

Re: [Rails-core] [Feature] Add support HashWithIndifferentAccess to Hash#extract!

2016-09-22 Thread richard schneeman
HashWithIndifferentAccess is EXTREMELY expensive. For some background I did a write up on Hashie, another object that inherits from Hash  http://www.schneems.com/2014/12/15/hashie-considered-harmful.html Several of the problems that apply to hashie also apply to HWIA. Basically any subclass of

[Rails-core] [Feature] Add support HashWithIndifferentAccess to Hash#extract!

2016-09-22 Thread Andrey Molchanov
Hello there! I propose to add support for class objects *HashWithIndifferentAccess* to method *Hash#extract!*: before: def extract!(*keys) keys.each_with_object(self.class.new) { |key, result| result[key] = delete(key) if has_key?(key) } end after: def extract!(*keys) keys.map! { |key|