Re: [Rails-core] ActionController::TestCase controller construction

2012-07-29 Thread Aaron Patterson
On Sun, Jul 29, 2012 at 02:49:55PM -0700, David Chelimsky wrote: > > Perfect. That's what I would expect. Will `controller_class` ever > > return something that can't be constructed via `new`? > > > > Not by rspec, but I can't account for end users doing silly things :) Yes, and I presume end

Re: [Rails-core] ActionController::TestCase controller construction

2012-07-29 Thread David Chelimsky
On Sunday, July 29, 2012 5:22:05 PM UTC-4, Aaron Patterson wrote: > > On Sun, Jul 29, 2012 at 01:47:34PM -0700, David Chelimsky wrote: > > On Sunday, July 29, 2012 4:29:59 PM UTC-4, Aaron Patterson wrote: > > > > > > On Sun, Jul 29, 2012 at 11:54:33AM -0400, Matt Jones wrote: > > > > > > > > O

Re: [Rails-core] ActionController::TestCase controller construction

2012-07-29 Thread Aaron Patterson
On Sun, Jul 29, 2012 at 01:47:34PM -0700, David Chelimsky wrote: > On Sunday, July 29, 2012 4:29:59 PM UTC-4, Aaron Patterson wrote: > > > > On Sun, Jul 29, 2012 at 11:54:33AM -0400, Matt Jones wrote: > > > > > > On Jul 28, 2012, at 11:44 PM, Aaron Patterson wrote: > > > > > > > In the case a d

Re: [Rails-core] ActionController::TestCase controller construction

2012-07-29 Thread David Chelimsky
On Sunday, July 29, 2012 4:29:59 PM UTC-4, Aaron Patterson wrote: > > On Sun, Jul 29, 2012 at 11:54:33AM -0400, Matt Jones wrote: > > > > On Jul 28, 2012, at 11:44 PM, Aaron Patterson wrote: > > > > > In the case a developer has not constructed a controller, the setup > > > method of ActionCon

Re: [Rails-core] ActionController::TestCase controller construction

2012-07-29 Thread Aaron Patterson
On Sun, Jul 29, 2012 at 11:54:33AM -0400, Matt Jones wrote: > > On Jul 28, 2012, at 11:44 PM, Aaron Patterson wrote: > > > In the case a developer has not constructed a controller, the setup > > method of ActionController::TestCase will attempt to construct a > > controller object. If it cannot

Re: [Rails-core] ActionController::TestCase controller construction

2012-07-29 Thread Matt Jones
On Jul 28, 2012, at 11:44 PM, Aaron Patterson wrote: > In the case a developer has not constructed a controller, the setup > method of ActionController::TestCase will attempt to construct a > controller object. If it cannot construct a controller object, it > silently fails. > > I added a warni

[Rails-core] ActionController::TestCase controller construction

2012-07-28 Thread Aaron Patterson
In the case a developer has not constructed a controller, the setup method of ActionController::TestCase will attempt to construct a controller object. If it cannot construct a controller object, it silently fails. I added a warning in this case, and I'd like to eventually deprecate the behavior.