Re: [Rails-core] Backport of keyword parameters for controller tests for Rails 4?

2016-06-29 Thread Justin Coyne
I've created a module to mix into my tests when using Rails 4 that backports the new API. Feel free to grab it: https://github.com/projectblacklight/blacklight/pull/1419/commits/59436b48828c96a013a207fab079d82d4bc2c793#diff-33612259a5fa283a3bc7ee0a2d0fc653R2 -Justin On Thursday, January 7,

Re: [Rails-core] Backport of keyword parameters for controller tests for Rails 4?

2016-01-07 Thread Prem Sichanugrist
I think that might be a good idea. Do you mind creating an issue and ping @sikachu on it? Or, do you want to take a crack at it? I might be able to look at this tomorrow. -Prem > On Jan 7, 2016, at 11:23 AM, Markus D. wrote: > > +1 Would really ease transition to

Re: [Rails-core] Backport of keyword parameters for controller tests for Rails 4?

2016-01-07 Thread Rafael Mendonça França
I don't think it is necessary. You can still use the same syntax with Rails 4 and Rails 5, you will only see deprecations warnings, and I believe it is acceptable in this case. On Thu, Jan 7, 2016 at 4:33 PM Prem Sichanugrist wrote: > I think that might be a good idea. > >

[Rails-core] Backport of keyword parameters for controller tests for Rails 4?

2015-06-11 Thread Victor Costan
I'm trying to add Rails 5 support to an engine which (among other things) has a generator for controller tests. I've ran into the keyword arguments deprecation warning at the bottom of this e-mail, and I'm in a bind now. If I use keyword arguments to get rid of the warnings, I lose Rails 4