Thank you.
I will aim for submitting a PR over the coming weekend.
On Mon, Aug 10, 2015 at 1:18 PM, Rafael Mendonça França <
rafaelmfra...@gmail.com> wrote:
> I think it is worth to experiment yes, I don't want to decline anything
> without seeing the code and how it would feel. I can see advant
I think it is worth to experiment yes, I don't want to decline anything
without seeing the code and how it would feel. I can see advantages of
doing that.
On Mon, Aug 10, 2015 at 2:11 PM wrote:
> Rafael,
>
> I made 3 strong arguments in response to your point about capybara. I
> would have appr
Rafael,
I made 3 strong arguments in response to your point about capybara. I
would have appreciated a response explaining if any of my reasoning is
wrong here.
This is not a difficult PR and I still feel the case for it is strong but I
don't want to start working on it while I'm waiting to
3) rails-api (
https://github.com/rails/rails/blob/master/actionpack/lib/action_controller/api.rb)
is merged into master (though not into 4.2-stable). "ApplicationController
< ActionController::API" would would be a very reasonable use case for
having no need for capybara. As this is going to par
1) By the same logic, almost all Rails applications use devise, and bcrypt
is a dependency of devise.
2) capybara is not typically a dependency in production
On Tue, Jul 14, 2015 at 11:29 AM, Rafael Mendonça França <
rafaelmfra...@gmail.com> wrote:
> Nokogiri is needed for tests and I don't thin
Nokogiri is needed for tests and I don't think tests are often used, at
least they should. I still don't see any reason for doing this even more
because almost all Rails applications use capybara and nokogiri is also a
capybara dependency.
On Tue, Jul 14, 2015 at 10:47 AM wrote:
> Thank you for
Thank you for the feedback. Thank you especially to Carlos for pointing
out that I could just include ActiveSupport without ActionView.
I could have left out the personal anecdote--Ryan makes a good point that
the real issue is that nokogiri should not be a dependency when it is
needed by only
