Re: [Rails-core] Significant change should be better explained in the Changelog regarding non ERB view partials

2016-05-09 Thread Rodrigo Rosenfeld Rosas
Or maybe we should automatically flag .js and .htm(l) extensions as html safe after using the raw handler, as they are common extensions expected to be used as partials... Em 9 de mai de 2016 8:45 AM, "Rodrigo Rosenfeld Rosas" escreveu: I understand the reasons why it's

Re: [Rails-core] Significant change should be better explained in the Changelog regarding non ERB view partials

2016-05-08 Thread Rafael Mendonça França
Hi, no worries. I can think in a better wording open a PR and ping you on it. Yes, the change is intentional and it is not html safe by default by definition. The whole idea of this change is to avoid people to rendering unsafe responses as safe by mistake. See

Re: [Rails-core] Significant change should be better explained in the Changelog regarding non ERB view partials

2016-05-08 Thread Rodrigo Rosenfeld Rosas
Hi Rafael, thanks for your response. My wife went through a surgery on Friday and is under recovery for a few days and I'm alone with the babies during the weekend. I'll try to find some time to create such PR tomorrow. But, before I do that, I'd like to ask: is this incompatible change

Re: [Rails-core] Significant change should be better explained in the Changelog regarding non ERB view partials

2016-05-06 Thread Rafael Mendonça França
That makes sense. Thank you for pointing out. Do you have a suggestion how to improve it? Could you open a pull request? On sex, 6 de mai de 2016 at 06:46 Rodrigo Rosenfeld Rosas < rr.ro...@gmail.com> wrote: > Here is the relevant section in the changelog, I think: > >

[Rails-core] Significant change should be better explained in the Changelog regarding non ERB view partials

2016-05-06 Thread Rodrigo Rosenfeld Rosas
Here is the relevant section in the changelog, I think: https://github.com/rails/rails/blob/v5.0.0.beta4/actionview/CHANGELOG.md "Change the default template handler from ERB to Raw. Files without a template handler in their extension will be rendered using the raw handler instead of ERB.