[Rails-core] Re: Rails 2.3 HTTP parameter extraction order

2011-01-18 Thread leivoset
Done:

https://rails.lighthouseapp.com/projects/8994/tickets/6311-fix-formhelpercheck_box-documentation-in-23

On Jan 17, 12:12 pm, Xavier Noria f...@hashref.com wrote:
 On Mon, Jan 17, 2011 at 9:09 PM, leivoset leivo...@gmail.com wrote:
  Is there any way this doc patch could be applied to the 2.3 branch? I
  spent hours trying to figure out what was going on after an upgrade to
  2.3 because the documentation was invalid and there was nothing
  mentioning this change in the release notes...

 If someone prepares a patch against 2.3 and opens a LH ticket with it
 I'll apply it. Please submit the link to this thread so that I see it
 for sure.

-- 
You received this message because you are subscribed to the Google Groups Ruby 
on Rails: Core group.
To post to this group, send email to rubyonrails-core@googlegroups.com.
To unsubscribe from this group, send email to 
rubyonrails-core+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/rubyonrails-core?hl=en.



Re: [Rails-core] Re: Rails 2.3 HTTP parameter extraction order

2011-01-18 Thread Xavier Noria
On Wed, Jan 19, 2011 at 1:02 AM, leivoset leivo...@gmail.com wrote:

 Done:

 https://rails.lighthouseapp.com/projects/8994/tickets/6311-fix-formhelpercheck_box-documentation-in-23

Excellent, applied. And welcome! :)

http://contributors.rubyonrails.org/contributors/johnathan-ritzi/commits

-- 
You received this message because you are subscribed to the Google Groups Ruby 
on Rails: Core group.
To post to this group, send email to rubyonrails-core@googlegroups.com.
To unsubscribe from this group, send email to 
rubyonrails-core+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/rubyonrails-core?hl=en.



[Rails-core] Re: Rails 2.3 HTTP parameter extraction order

2011-01-17 Thread Xavier Noria
On Mon, Jan 17, 2011 at 9:09 PM, leivoset leivo...@gmail.com wrote:

 Is there any way this doc patch could be applied to the 2.3 branch? I
 spent hours trying to figure out what was going on after an upgrade to
 2.3 because the documentation was invalid and there was nothing
 mentioning this change in the release notes...

If someone prepares a patch against 2.3 and opens a LH ticket with it
I'll apply it. Please submit the link to this thread so that I see it
for sure.

-- 
You received this message because you are subscribed to the Google Groups Ruby 
on Rails: Core group.
To post to this group, send email to rubyonrails-core@googlegroups.com.
To unsubscribe from this group, send email to 
rubyonrails-core+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/rubyonrails-core?hl=en.



[Rails-core] Re: Rails 2.3 HTTP parameter extraction order

2011-01-17 Thread leivoset
Is there any way this doc patch could be applied to the 2.3 branch? I
spent hours trying to figure out what was going on after an upgrade to
2.3 because the documentation was invalid and there was nothing
mentioning this change in the release notes...

On Mar 22 2009, 4:04 am, Xavier Noria f...@hashref.com wrote:
 On Sun, Mar 22, 2009 at 7:56 AM, tekwiz twarl...@gmail.com wrote:
  In the docs for ActionView::Helpers::FormHelper#check_box, when
  discussing why the method adds a hidden input tag _after_ the checkbox
  tag, it says

   ...Railsparametersextractionalways gets the first occurrence of
  any given key...

  I'm not sure this is still the case.

 Indeed it changed in2.3but unfortunately the patch didn't update the
 docs. We noticed this a few days ago, they are correct now in edge.

-- 
You received this message because you are subscribed to the Google Groups Ruby 
on Rails: Core group.
To post to this group, send email to rubyonrails-core@googlegroups.com.
To unsubscribe from this group, send email to 
rubyonrails-core+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/rubyonrails-core?hl=en.



[Rails-core] Re: Rails 2.3 HTTP parameter extraction order

2009-03-22 Thread Xavier Noria

On Sun, Mar 22, 2009 at 7:56 AM, tekwiz twarl...@gmail.com wrote:

 In the docs for ActionView::Helpers::FormHelper#check_box, when
 discussing why the method adds a hidden input tag _after_ the checkbox
 tag, it says

  ...Rails parameters extraction always gets the first occurrence of
 any given key...

 I'm not sure this is still the case.

Indeed it changed in 2.3 but unfortunately the patch didn't update the
docs. We noticed this a few days ago, they are correct now in edge.

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups Ruby 
on Rails: Core group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to 
rubyonrails-core+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/rubyonrails-core?hl=en
-~--~~~~--~~--~--~---