Re: [rules-users] OptaPlanner: score corruption when using insertLogical with custom objects

2013-08-04 Thread pvandenbrink
You're welcome, good to hear that it's fixed already! -- View this message in context: http://drools.46999.n3.nabble.com/OptaPlanner-score-corruption-when-using-insertLogical-with-custom-objects-tp4024932p4025306.html Sent from the Drools: User forum mailing list archive at Nabble.com.

Re: [rules-users] OptaPlanner: score corruption when using insertLogical with custom objects

2013-08-03 Thread Geoffrey De Smet
This time a genuine bug was reproduced and it's fixed for 6.0.0.CR2 (thanks to Mario). Thanks for reporting pvandenbrink :) On 25-07-13 14:57, pvandenbrink wrote: ge0ffrey wrote Yes, please reopen the jira issue if you're able to reproduce it with 6.0.0.Beta5 or higher. Done, I've modified

Re: [rules-users] OptaPlanner: score corruption when using insertLogical with custom objects

2013-07-25 Thread Geoffrey De Smet
On 24-07-13 17:05, pvandenbrink wrote: Thanks for looking into it, and you're right. Looks like I made an error in the reproducer project, sorry... The original code didn't have this equals/hashcode problem. After fixing this in the reproducer, the example schedule works fine though, so I'll

Re: [rules-users] OptaPlanner: score corruption when using insertLogical with custom objects

2013-07-25 Thread pvandenbrink
ge0ffrey wrote Yes, please reopen the jira issue if you're able to reproduce it with 6.0.0.Beta5 or higher. Done, I've modified the dataset, so the issue's reproducible again in 6.0.0.Beta5 and 6.0.0.SNAPSHOT, with the corrected equals/hashcode for FamilyStart. -- View this message in

Re: [rules-users] OptaPlanner: score corruption when using insertLogical with custom objects

2013-07-24 Thread Geoffrey De Smet
Turns out this is a user problem in the equals and hashcode of FamilyStart, not a bug in Drools or OptaPlanner :) @Override public boolean equals(Object other) { if ((this == other)) return true; if (!(other instanceof FamilyStart))

Re: [rules-users] OptaPlanner: score corruption when using insertLogical with custom objects

2013-07-24 Thread pvandenbrink
ge0ffrey wrote Turns out this is a user problem in the equals and hashcode of FamilyStart, not a bug in Drools or OptaPlanner :) @Override public boolean equals(Object other) { if ((this == other)) return true; if (!(other instanceof

Re: [rules-users] OptaPlanner: score corruption when using insertLogical with custom objects

2013-07-19 Thread pvandenbrink
Ok, I've created a small reproducer and attached it to this issue: https://issues.jboss.org/browse/PLANNER-182 -- View this message in context: http://drools.46999.n3.nabble.com/OptaPlanner-score-corruption-when-using-insertLogical-with-custom-objects-tp4024932p4025055.html Sent from the

Re: [rules-users] OptaPlanner: score corruption when using insertLogical with custom objects

2013-07-19 Thread Geoffrey De Smet
Thanks. The zip looks good and isolated (= usable for me). I might look into it after PLANNER-160 is done next week. On 19-07-13 11:25, pvandenbrink wrote: Ok, I've created a small reproducer and attached it to this issue: https://issues.jboss.org/browse/PLANNER-182 -- View this message

Re: [rules-users] OptaPlanner: score corruption when using insertLogical with custom objects

2013-07-17 Thread pvandenbrink
ge0ffrey wrote Do you have this issue in 5.4 too? E.g.: the 5.4 equivalent of full assert (TRACE) does not detect score corruption? I've tried this and actually, yes, it happens with TRACE in 5.4 as well. So it's not an issue introduced by the upgrade to Beta5, then. ge0ffrey wrote Maybe

Re: [rules-users] OptaPlanner: score corruption when using insertLogical with custom objects

2013-07-17 Thread Geoffrey De Smet
On 17-07-13 11:59, pvandenbrink wrote: ge0ffrey wrote Do you have this issue in 5.4 too? E.g.: the 5.4 equivalent of full assert (TRACE) does not detect score corruption? I've tried this and actually, yes, it happens with TRACE in 5.4 as well. So it's not an issue introduced by the upgrade

Re: [rules-users] OptaPlanner: score corruption when using insertLogical with custom objects

2013-07-17 Thread pvandenbrink
ge0ffrey wrote The 7 one probably got inserted with it didn't reach to 5 yet. That was a good logicalInsertion. The issue is, why didn't it get retracted when a move made changes so it did reach to 5? I've added a printline in the rules xml file before the insertLogical. At one point shortly

Re: [rules-users] OptaPlanner: score corruption when using insertLogical with custom objects

2013-07-17 Thread Geoffrey De Smet
On 17-07-13 13:02, pvandenbrink wrote: ge0ffrey wrote The 7 one probably got inserted with it didn't reach to 5 yet. That was a good logicalInsertion. The issue is, why didn't it get retracted when a move made changes so it did reach to 5? I've added a printline in the rules xml file before

Re: [rules-users] OptaPlanner: score corruption when using insertLogical with custom objects

2013-07-17 Thread pvandenbrink
ge0ffrey wrote On 17-07-13 13:02, pvandenbrink wrote: ge0ffrey wrote The 7 one probably got inserted with it didn't reach to 5 yet. That was a good logicalInsertion. The issue is, why didn't it get retracted when a move made changes so it did reach to 5? I've added a printline in the rules

[rules-users] OptaPlanner: score corruption when using insertLogical with custom objects

2013-07-16 Thread pvandenbrink
Hi, I've been using Drools Planner with success for a while for our Conversation planning tool. It's used by schools to plan conversations between teachers and parents of schoolgoing children. Recently I checked on the new developments on Drools (the current version we're using in production is

Re: [rules-users] OptaPlanner: score corruption when using insertLogical with custom objects

2013-07-16 Thread Geoffrey De Smet
On 16-07-13 16:24, pvandenbrink wrote: Hi, I've been using Drools Planner with success for a while for our Conversation planning tool. It's used by schools to plan conversations between teachers and parents of schoolgoing children. Great to hear :) Sounds like an interesting use case story.