Re: [rust-dev] Code review checklist

2014-01-21 Thread Brian Anderson
Thanks. This is a good idea. On 01/19/2014 04:52 AM, Flaper87 wrote: Hey, I've been doing reviews for a bit and I just realized we, as community, don't have a review checklist that all reviewers should go through. I thought that it could be useful to have a wiki page describing the review pr

Re: [rust-dev] Improving rustc error messages

2014-01-21 Thread Tony Arcieri
On Tue, Jan 21, 2014 at 9:55 PM, Patrick Walton wrote: > I think we need some specific examples. I personally think that between > the colored output, printing of the erroneous lines, spelling corrections, > suggestions of `.clone()` and so forth, rustc actually has some of the best > diagnostics

Re: [rust-dev] Improving rustc error messages

2014-01-21 Thread Patrick Walton
On 1/21/14 9:48 PM, Tony Arcieri wrote: I think the biggest thing I've struggled with learning Rust is what I will call, for lack of a better phrase, "shit rustc says". Reading Steve Klabnik's tutorial and some blog posts about earlier versions of rust, it's clear that the error messages have imp

Re: [rust-dev] Improving rustc error messages

2014-01-21 Thread Tony Arcieri
I see there's some work underway of this nature ;) https://github.com/mozilla/rust/pull/11718 On Tue, Jan 21, 2014 at 9:48 PM, Tony Arcieri wrote: > I think the biggest thing I've struggled with learning Rust is what I will > call, for lack of a better phrase, "shit rustc says". Reading Steve

[rust-dev] Improving rustc error messages

2014-01-21 Thread Tony Arcieri
I think the biggest thing I've struggled with learning Rust is what I will call, for lack of a better phrase, "shit rustc says". Reading Steve Klabnik's tutorial and some blog posts about earlier versions of rust, it's clear that the error messages have improved dramatically since earlier versions,

Re: [rust-dev] Lifetime required to outlive itself

2014-01-21 Thread Scott Lawrence
Yup, that was pretty much it. (I suspected something like that might be happening.) Thanks! To future generations of confused souls: when the impl is parameterized, the function probably doesn't need to be. On Wed, 22 Jan 2014, Huon Wilson wrote: On 22/01/14 12:41, Scott Lawrence wrote: Thi

Re: [rust-dev] Lifetime required to outlive itself

2014-01-21 Thread Huon Wilson
On 22/01/14 12:41, Scott Lawrence wrote: This code compiles successfully: http://ix.io/a34 . I believe this behavior is correct. Just so it's clear what this code does: f() takes a `&mut int` and adds it to an array - the idea is that all of the `&mut int` can be changed at some later time. Nat

[rust-dev] Lifetime required to outlive itself

2014-01-21 Thread Scott Lawrence
This code compiles successfully: http://ix.io/a34 . I believe this behavior is correct. Just so it's clear what this code does: f() takes a `&mut int` and adds it to an array - the idea is that all of the `&mut int` can be changed at some later time. Naturally, there's some fancy lifetime juggli

Re: [rust-dev] should fail to compile or not?

2014-01-21 Thread Igor Karablin
Yes, this is really cleared all mystery, thanks for your explanation Alex! On Wed, Jan 22, 2014 at 5:02 AM, Alex Crichton wrote: > Rust has the idea of "implicit copyability", a property of a type > formalized by the Pod trait. An implicitly copyable type is either a > primitive, or a structure

Re: [rust-dev] should fail to compile or not?

2014-01-21 Thread Alex Crichton
Rust has the idea of "implicit copyability", a property of a type formalized by the Pod trait. An implicitly copyable type is either a primitive, or a structure/enum which is built from implicitly copyable types (plus some extra rules in play here). When you add a destructor (implementation of the

[rust-dev] should fail to compile or not?

2014-01-21 Thread Igor Karablin
Hello, I'm learning rust and trying to understand why rust allows me to compile this piece of code. When Drop impl is uncommented - rustc complains about 'use of moved value', which is ok i think. My question is - why it compiles code when Drop is not implemented for Inner struct? If its behaves a

Re: [rust-dev] Rust to JS (minor changes)

2014-01-21 Thread Bilal Husain
I have added basic let destructuring so that the `lexer.rs` transpiles completely and it works for the HEAD[1] at the moment (I am working on last year's copy). Earlier, few statements in `mod test` block were not supported. I will now work on accuracy and functionality of the generated code, so t

Re: [rust-dev] Rust-ci updates (project categories and documentation)

2014-01-21 Thread Hans Jørgen Hoel
Thanks for the feedback.That is indeed a concern. I'm already using temporary per project credentials with limited policies. I'll add some text about actually having to generate the docs yourself :) Hans Jørgen On 21 January 2014 10:18, Kang Seonghoon wrote: > Great! I really appreciate a new

Re: [rust-dev] Rust-ci updates (project categories and documentation)

2014-01-21 Thread Kang Seonghoon
Great! I really appreciate a new project listing. Maybe you should emphasize that you need to run `rustdoc` yourself to get the generated docs uploaded to the server ;) I have a question, or rather, a possible security issue with the artifact uploading though, especially given the following script