[Ryu-devel] [PATCH] halve the number of recv and header parsing by simplifying _recv_loop

2013-02-12 Thread YAMAMOTO Takashi
cbench results before the change: cbench RESULT: 16 switches 15 tests min/max/avg/stdev = 8257.99/8485.97/8348.71/70.46 responses/s cbench -t RESULT: 16 switches 15 tests min/max/avg/stdev = 8050.82/20660.79/14935.69/3820.58 responses/s after: cbench RESULT: 16 switches 15 tests min/max/avg/stde

Re: [Ryu-devel] [PATCH v3] controller/ofp_handler: improve version negotiation

2013-02-12 Thread YAMADA Hideki
(2013/02/13 12:06), Isaku Yamahata wrote: > - fix string concatenation. Needs surrounding paren. > - more version checks > - make hello_failed private. (adding "_" prefix) > > Signed-off-by: Isaku Yamahata > --- > ryu/controller/ofp_handler.py | 90 > -

[Ryu-devel] [PATCH] controller: fix send_q draining

2013-02-12 Thread YAMAMOTO Takashi
when stopping the sender thread, ensure that no one is going to block on send_q. otherwise a ryu app who wants to do send_msg on the datapath can block on the queue forever if the queue is full. Signed-off-by: YAMAMOTO Takashi --- ryu/controller/controller.py | 15 +++ 1 file change

Re: [Ryu-devel] [PATCH v3] controller/ofp_handler: improve version negotiation

2013-02-12 Thread FUJITA Tomonori
On Wed, 13 Feb 2013 12:06:19 +0900 Isaku Yamahata wrote: > - fix string concatenation. Needs surrounding paren. > - more version checks > - make hello_failed private. (adding "_" prefix) > > Signed-off-by: Isaku Yamahata > --- > ryu/controller/ofp_handler.py | 90 > +

Re: [Ryu-devel] [PATCH 0/4] minor fixes for rpm package

2013-02-12 Thread Isaku Yamahata
On Wed, Feb 13, 2013 at 08:54:04AM +0900, FUJITA Tomonori wrote: > On Tue, 12 Feb 2013 23:38:29 +0900 > Isaku Yamahata wrote: > > > Subject: [PATCH 2/2] LICENCE: change end-of-line code CRLF to LF > > > >> wrong-file-end-of-line-encoding > > > > rpmlint prefers unix style than dos > > converted

[Ryu-devel] [PATCH v3] controller/ofp_handler: improve version negotiation

2013-02-12 Thread Isaku Yamahata
- fix string concatenation. Needs surrounding paren. - more version checks - make hello_failed private. (adding "_" prefix) Signed-off-by: Isaku Yamahata --- ryu/controller/ofp_handler.py | 90 - 1 file changed, 71 insertions(+), 19 deletions(-) diff --

[Ryu-devel] [PATCH] of1.2: fix OFPQueueProp parser

2013-02-12 Thread KONDOH Tasuku
- add OFP_QUEUE_PROP_HEADER_SIZE to offset of argument of propreties class. Signed-off-by: KONDOH Tasuku --- ryu/ofproto/ofproto_v1_2_parser.py|1 + ryu/tests/unit/ofproto/test_parser_v12.py | 110 ++--- 2 files changed, 55 insertions(+), 56 deletions(-) dif

Re: [Ryu-devel] [PATCH] quantum_adapter: exception when VM deletion

2013-02-12 Thread FUJITA Tomonori
On Wed, 13 Feb 2013 08:26:51 +0900 Isaku Yamahata wrote: >> Traceback (most recent call last): >> File "/usr/lib/python2.7/dist-packages/gevent/greenlet.py", line 390, in >> run >> result = self._run(*self.args, **self.kwargs) >> File "/opt/stack/ryu/ryu/base/app_manager.py", line 86, in

Re: [Ryu-devel] [PATCH 0/4] minor fixes for rpm package

2013-02-12 Thread FUJITA Tomonori
On Tue, 12 Feb 2013 23:38:29 +0900 Isaku Yamahata wrote: > Subject: [PATCH 2/2] LICENCE: change end-of-line code CRLF to LF > >> wrong-file-end-of-line-encoding > > rpmlint prefers unix style than dos > converted by sed -i 's/\r//g' LICENSE > > Signed-off-by: Isaku Yamahata > --- > LICENSE |

Re: [Ryu-devel] [PATCH] of: fix hello version error printing

2013-02-12 Thread FUJITA Tomonori
On Wed, 13 Feb 2013 08:14:48 +0900 Isaku Yamahata wrote: > On Sat, Feb 09, 2013 at 01:46:00PM +0900, FUJITA Tomonori wrote: >> > diff --git a/ryu/controller/ofp_handler.py b/ryu/controller/ofp_handler.py >> > index add0301..05ac79b 100644 >> > --- a/ryu/controller/ofp_handler.py >> > +++ b/ryu/co

[Ryu-devel] [PATCH] quantum_adapter: exception when VM deletion

2013-02-12 Thread Isaku Yamahata
> Traceback (most recent call last): > File "/usr/lib/python2.7/dist-packages/gevent/greenlet.py", line 390, in run > result = self._run(*self.args, **self.kwargs) > File "/opt/stack/ryu/ryu/base/app_manager.py", line 86, in _event_loop > handler(ev) > File "/opt/stack/ryu/ryu/app/qua

Re: [Ryu-devel] [PATCH] of: fix hello version error printing

2013-02-12 Thread Isaku Yamahata
On Sat, Feb 09, 2013 at 01:46:00PM +0900, FUJITA Tomonori wrote: > > diff --git a/ryu/controller/ofp_handler.py b/ryu/controller/ofp_handler.py > > index add0301..05ac79b 100644 > > --- a/ryu/controller/ofp_handler.py > > +++ b/ryu/controller/ofp_handler.py > > @@ -44,7 +44,7 @@ class OFPHandler(ap

Re: [Ryu-devel] [PATCH 0/4] minor fixes for rpm package

2013-02-12 Thread Isaku Yamahata
On Tue, Feb 12, 2013 at 08:23:54PM +0900, FUJITA Tomonori wrote: > On Tue, 12 Feb 2013 17:10:38 +0900 > Isaku Yamahata wrote: > > > There are several issues during building rpm package. > > This patch series fixes them. > > > > Isaku Yamahata (4): > > LICENCE: change end-of-line code CRLF to L

Re: [Ryu-devel] getting error while running simple_switch.py

2013-02-12 Thread FUJITA Tomonori
On Tue, 12 Feb 2013 11:12:46 +0100 Jeremias Blendin wrote: > while Ryu supports OpenFlow 1.0, 1.2 and 1.3, the simple_switch.py example > works with OpenFlow 1.0 only (search for v1_0 in the source code for > details). > As LINC switch uses OpenFlow 1.3 by default, and does not support OpenFlow >

Re: [Ryu-devel] [PATCH 0/4] minor fixes for rpm package

2013-02-12 Thread FUJITA Tomonori
On Tue, 12 Feb 2013 17:10:38 +0900 Isaku Yamahata wrote: > There are several issues during building rpm package. > This patch series fixes them. > > Isaku Yamahata (4): > LICENCE: change end-of-line code CRLF to LF > doc: eliminate sphinx warnings > doc: man pages for ryu-manager and ryu-c

Re: [Ryu-devel] getting error while running simple_switch.py

2013-02-12 Thread Jeremias Blendin
Hi, while Ryu supports OpenFlow 1.0, 1.2 and 1.3, the simple_switch.py example works with OpenFlow 1.0 only (search for v1_0 in the source code for details). As LINC switch uses OpenFlow 1.3 by default, and does not support OpenFlow 1.0, you get that "closed because of bad_initial_message" output.

[Ryu-devel] getting error while running simple_switch.py

2013-02-12 Thread Gandhimathi Velusamy
Hi, I installed Ryu and thought of trying the simple_switch.py : When I run this code first and then If I start the LINC switch, i am getting the following error in the LINC console (linc@roadrunner)1> 02:04:08.514 [info] Created port: {1,[{interface,"tap-linc-port1"},{ip,"10.0.0.1"}]} 02:04:08.535

[Ryu-devel] [PATCH 6/6] stop requiring gflags

2013-02-12 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- setup.cfg | 2 +- tools/pip-requires | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/setup.cfg b/setup.cfg index ac6ba19..2452758 100644 --- a/setup.cfg +++ b/setup.cfg @@ -6,7 +6,7 @@ source-dir = doc/source [bdist_rpm] Release

[Ryu-devel] [PATCH 4/6] update a sample and documentation

2013-02-12 Thread YAMAMOTO Takashi
try to sync the documentation with the reality at least about gflags/cfg changes. Signed-off-by: YAMAMOTO Takashi --- doc/source/parameters.rst | 17 + doc/source/step_by_step.rst | 9 + doc/source/using_with_openstack.rst | 2 +- etc/ryu/ryu.conf

[Ryu-devel] [PATCH 5/6] fix a typo in the help message of quantum_controller_addr

2013-02-12 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/flags.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/flags.py b/ryu/flags.py index a875d17..1275530 100644 --- a/ryu/flags.py +++ b/ryu/flags.py @@ -41,6 +41,6 @@ CONF.register_cli_opts([ help='auth strategy for c

[Ryu-devel] [PATCH 2/6] use openstack.common.cfg instead of gflags

2013-02-12 Thread YAMAMOTO Takashi
make most of modules use openstack.common.cfg instead of gflags caveats: no config file compatibility is provided. (flagfile vs ini file) Signed-off-by: YAMAMOTO Takashi --- bin/ryu-manager| 30 ++--- ryu/app/quantum_adapter.py | 28 +++--

[Ryu-devel] [PATCH 3/6] adjust import order in ryu-manager and add a comment.

2013-02-12 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- bin/ryu-manager | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/bin/ryu-manager b/bin/ryu-manager index d53906b..1e8d3aa 100755 --- a/bin/ryu-manager +++ b/bin/ryu-manager @@ -20,6 +20,15 @@ import gevent from gevent import

[Ryu-devel] [PATCH 0/6] switch from python-gflags to openstack cfg

2013-02-12 Thread YAMAMOTO Takashi
openstack cfg.py is more flexible wrt schema modifications. eg. it allows introducing options at module import time. YAMAMOTO Takashi (6): import cfg.py from oslo-incubator use openstack.common.cfg instead of gflags adjust import order in ryu-manager and add a comment. update a sample and

[Ryu-devel] [PATCH 4/4] tests: make run_tests.py, test_lib.py executable as it includes #!

2013-02-12 Thread Isaku Yamahata
rpmlint requires it as follows. > ryu.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/ryu/tests/run_tests.py 0644L /usr/bin/env > ryu.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/ryu/tests/test_lib.py 0644L /usr/bin/env > This text file contains a sheba

[Ryu-devel] [PATCH 1/4] LICENCE: change end-of-line code CRLF to LF

2013-02-12 Thread Isaku Yamahata
> wrong-file-end-of-line-encoding Signed-off-by: Isaku Yamahata --- LICENSE | 404 +++ 1 file changed, 202 insertions(+), 202 deletions(-) diff --git a/LICENSE b/LICENSE index 75b5248..d645695 100644 --- a/LICENSE +++ b/LICENSE @@ -1,

[Ryu-devel] [PATCH 3/4] doc: man pages for ryu-manager and ryu-client

2013-02-12 Thread Isaku Yamahata
In order to quieten rpmlint > ryu.noarch: W: no-manual-page-for-binary ryu-manager > Each executable in standard binary directories should have a man page. > > ryu.noarch: W: no-manual-page-for-binary ryu-client > Each executable in standard binary directories should have a man page. Signed-off-by

[Ryu-devel] [PATCH 0/4] minor fixes for rpm package

2013-02-12 Thread Isaku Yamahata
There are several issues during building rpm package. This patch series fixes them. Isaku Yamahata (4): LICENCE: change end-of-line code CRLF to LF doc: eliminate sphinx warnings doc: man pages for ryu-manager and ryu-client tests: make run_tests.py, test_lib.py executable as it includes #

[Ryu-devel] [PATCH 2/4] doc: eliminate sphinx warnings

2013-02-12 Thread Isaku Yamahata
This patch eliminates the following sphinx warnings. > ryu/doc/source/parameters.rst:47: ERROR: Unexpected indentation. > ryu/doc/source/step_by_step.rst:1: WARNING: malformed hyperlink target. > ryu/doc/source/step_by_step.rst:164: ERROR: Inconsistent literal block > quoting. > ryu/doc/source/st