[Ryu-devel] [PATCH 2/3] TLS: test cli options consistently in the same line

2013-03-17 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/controller/controller.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/controller/controller.py b/ryu/controller/controller.py index c753f01..7c62804 100644 --- a/ryu/controller/controller.py +++ b/ryu/controller/controller.py @@

[Ryu-devel] [PATCH 3/3] TLS: use a full spelling of a cli option

2013-03-17 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- doc/source/tls.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/source/tls.rst b/doc/source/tls.rst index fb2ae2c..9388378 100644 --- a/doc/source/tls.rst +++ b/doc/source/tls.rst @@ -60,7 +60,7 @@ Run Ryu with CA files:: % ry

[Ryu-devel] [PATCH 1/3] TLS: update an example output

2013-03-17 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- doc/source/tls.rst | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/doc/source/tls.rst b/doc/source/tls.rst index 642e93b..fb2ae2c 100644 --- a/doc/source/tls.rst +++ b/doc/source/tls.rst @@ -67,12 +67,14 @@ You can see someth

Re: [Ryu-devel] ryu.controller.controller.Datapath: handler list and state

2013-03-17 Thread Yoshihiro Kaneko
2013/3/18 FUJITA Tomonori : > On Mon, 11 Mar 2013 19:09:01 +0900 > Yoshihiro Kaneko wrote: > >> I suppose that the list of handler to be called for the OFP message >> should be kept even if the state is changed in a handler. >> Is this correct? >> >> diff --git a/ryu/controller/controller.py b/ryu

Re: [Ryu-devel] Some random(?) errors

2013-03-17 Thread Isaku Yamahata
On Mon, Mar 18, 2013 at 09:59:46AM +0800, Can Zhang wrote: > Hello, Hello. > I encounter the errors below quite often recently: > > Traceback (most recent call last): > File "build/bdist.macosx-10.8-intel/egg/gevent/greenlet.py", line 390, in > run > result = self._run(*self.args, **

Re: [Ryu-devel] [PATCH 3/3] topology: support link discovery

2013-03-17 Thread Isaku Yamahata
On Thu, Mar 14, 2013 at 07:16:07PM +0900, YAMADA Hideki wrote: > event.py: add link events. > switches.py: add link discovery (only of1.0). > dumper.py: add handler for link events. > > TODO: support other OpenFlow version. > > Signed-off-by: YAMADA Hideki > --- > bin/ryu-manager |

Re: [Ryu-devel] [PATCH 2/3] topology: switch discovering module

2013-03-17 Thread Isaku Yamahata
Comments inlined. On Thu, Mar 14, 2013 at 07:16:06PM +0900, YAMADA Hideki wrote: > This is an alternative of dpset, which supports event passing. > > event.py: event class > switches.py: switch(datapath) discovery app using ofp_event > dumper.py: test and example app using switch discovery event

[Ryu-devel] Some random(?) errors

2013-03-17 Thread Can Zhang
Hello, I encounter the errors below quite often recently: Traceback (most recent call last): File "build/bdist.macosx-10.8-intel/egg/gevent/greenlet.py", line 390, in run result = self._run(*self.args, **self.kwargs) File "/Library/Python/2.7/site-packages/ryu-1.7-py2.7.egg/ryu/contr

Re: [Ryu-devel] [PATCH] app_manager: prefix RyuApp internal methods with '_'

2013-03-17 Thread YAMAMOTO Takashi
> On Tue, 12 Mar 2013 14:20:41 +0900 > YAMAMOTO Takashi wrote: > >> according to FUJITA Tomonori, these are internal methods. >> prefix them with '_' to make it clear and avoid further abuses. >> >> Signed-off-by: YAMAMOTO Takashi >> --- >> ryu/app/gre_tunnel.py| 4 +++- >> ryu/base/a

Re: [Ryu-devel] [PATCH] add a ryuapp to provide python interactive console for debugging

2013-03-17 Thread YAMAMOTO Takashi
> On Mon, 11 Mar 2013 14:18:26 +0900 > YAMAMOTO Takashi wrote: > >> Signed-off-by: YAMAMOTO Takashi >> --- >> ryu/app/debug_console.py | 37 + >> 1 file changed, 37 insertions(+) >> create mode 100644 ryu/app/debug_console.py > > For what we want this? i w

Re: [Ryu-devel] Private VLAN flows

2013-03-17 Thread FUJITA Tomonori
On Fri, 15 Mar 2013 00:55:22 + Bright Dadson wrote: > I am currently trying to add a flow to simulate vlan on pre-determine ports > on the switch. My question is, Is it possible to use Ryu to add flows > without using a match on ingress port, i.e adding a flow with vlan tags > without using I

Re: [Ryu-devel] [PATCH] add a ryuapp to provide python interactive console for debugging

2013-03-17 Thread FUJITA Tomonori
On Mon, 11 Mar 2013 14:18:26 +0900 YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi > --- > ryu/app/debug_console.py | 37 + > 1 file changed, 37 insertions(+) > create mode 100644 ryu/app/debug_console.py For what we want this? --

Re: [Ryu-devel] [PATCH] app_manager: prefix RyuApp internal methods with '_'

2013-03-17 Thread FUJITA Tomonori
On Tue, 12 Mar 2013 14:20:41 +0900 YAMAMOTO Takashi wrote: > according to FUJITA Tomonori, these are internal methods. > prefix them with '_' to make it clear and avoid further abuses. > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/app/gre_tunnel.py| 4 +++- > ryu/base/app_manager.py

Re: [Ryu-devel] [PATCH] group quantum related options

2013-03-17 Thread FUJITA Tomonori
On Wed, 13 Mar 2013 13:51:48 +0900 YAMAMOTO Takashi wrote: > caveats: no config file backward compat > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/app/quantum_adapter.py | 24 > ryu/flags.py | 22 +- > 2 files changed, 25 insertions(

Re: [Ryu-devel] [PATCH] vsctl: fix timeout

2013-03-17 Thread FUJITA Tomonori
On Wed, 13 Mar 2013 15:18:21 +0900 YAMAMOTO Takashi wrote: > - run_command's timeout argument is named 'timeout_msec', but > all callers seem to pass the value in second. so rename > the argument to 'timeout_sec'. > > - gevent.Timeout takes a timeout value in second. > remove a conversion

Re: [Ryu-devel] [PATCH] tunnel_port_updater: g/c _LOCK

2013-03-17 Thread FUJITA Tomonori
On Tue, 12 Mar 2013 14:28:33 +0900 YAMAMOTO Takashi wrote: > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/app/tunnel_port_updater.py | 3 --- > 1 file changed, 3 deletions(-) Applied. -- Everyone hates slow websites

Re: [Ryu-devel] ryu.controller.controller.Datapath: handler list and state

2013-03-17 Thread FUJITA Tomonori
On Mon, 11 Mar 2013 19:09:01 +0900 Yoshihiro Kaneko wrote: > I suppose that the list of handler to be called for the OFP message > should be kept even if the state is changed in a handler. > Is this correct? > > diff --git a/ryu/controller/controller.py b/ryu/controller/controller.py > index c75

Re: [Ryu-devel] [PATCH] packet lib: fix icmpv6.nd parser

2013-03-17 Thread FUJITA Tomonori
On Mon, 11 Mar 2013 19:04:55 +0900 HIYAMA Manabu wrote: > > Signed-off-by: HIYAMA Manabu > --- > ryu/lib/packet/icmpv6.py |3 +- > ryu/tests/unit/packet/test_icmpv6.py | 339 > ++ > 2 files changed, 341 insertions(+), 1 deletion(-) > create mo

Re: [Ryu-devel] [PATCH 0/3] add firewall Ryu application

2013-03-17 Thread Isaku Yamahata
I haven't looked details yet, but some general comment. - pep8 please Or you seem to use old version of pep8 shipped by distro. Please use latest pep8 - Please consistent indentation Maybe it's a matter of taste, but please be consistent in at least single file. thanks On Fri, Mar 15, 20