On Sun, Apr 07, 2013 at 10:54:03PM -0700, Yue Chen wrote:
> Hi Yamahata-san,
>
> Thanks for your quick answer last time! I got the VM image working with GRE
> tunnels between the OVSs.
>
> However, in order to fully benefit from Ryu Controller's ability to do L2
> separation using OpenFlow, I'd
Oops this is the correct one.
>From 8082774e9528f411e5b4436c19e661b7cd676a36 Mon Sep 17 00:00:00 2001
Message-Id:
<8082774e9528f411e5b4436c19e661b7cd676a36.1365485476.git.yamah...@valinux.co.jp>
In-Reply-To:
References:
From: Isaku Yamahata
Date: Tue, 9 Apr 2013 14:13:47 +0900
Subject: [PATCH
On Thu, Apr 04, 2013 at 06:48:12PM -0700, Shivaram Mysore wrote:
> Hello,
Hello.
> I did some real hack to get some version of OFConfig working with Ryu to get
> over the SSH Host Fingerprint issue as reported in the previous email. But, I
> am not sure how to effectively use this ?
I sent the
Cc: Shivaram Mysore
Signed-off-by: Isaku Yamahata
---
ryu/tests/integrated/test_of_config.py | 96
1 file changed, 96 insertions(+)
diff --git a/ryu/tests/integrated/test_of_config.py
b/ryu/tests/integrated/test_of_config.py
index 2e46c6e..a7d5815 100644
---
This test can fail with unknow hosts as follows.
Since this is a OF-config test/sample, known host check is not essential.
Disable the check to avoid non-essential problem for easy test.
> ryu $ PYTHONPATH=. ./bin/ryu-manager --verbose
> ryu/tests/integrated/test_of_config.py
> loading app ryu/te
They are necessary for OF-config support.
Cc: Shivaram Mysore
Signed-off-by: Isaku Yamahata
---
setup.py |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/setup.py b/setup.py
index 297c89d..f1e0757 100644
--- a/setup.py
+++ b/setup.py
@@ -45,7 +45,7 @@ classifiers = [
if
This patch series fixes the issues of OF-config reported by
Shivaram Mysore
Isaku Yamahata (3):
setup.py: install xsd files
tests/integrated/test_of_config: disable known host check
tests/integrated/test_of_config: comment on how to run
ryu/tests/integrated/test_of_config.py | 99 ++
Those methods are legacy when lldp.py was written for dpkt.
They don't make sense. remove them.
Cc: "can."
Signed-off-by: Isaku Yamahata
---
ryu/lib/packet/lldp.py |9 -
1 file changed, 9 deletions(-)
diff --git a/ryu/lib/packet/lldp.py b/ryu/lib/packet/lldp.py
index f82e00a..d913c
> W: 78,0:LLDPBasicTLV.__init__: Unused argument 'args'
> W: 78,0:LLDPBasicTLV.__init__: Unused argument 'kwargs'
> W:109,4:lldp.__init__: __init__ method from base class 'PacketBase' is not
> called
Cc: "can."
Signed-off-by: Isaku Yamahata
---
ryu/lib/packet/lldp.py |4 +++-
1 file change
On Mon, 08 Apr 2013 13:30:04 +0200
blacksheeep wrote:
>
> Hello,
> sorry for problems with the patch submission. Hope it works now.
>
> I updated the code for the match_tuple() function:
> It installs the match for the network src/dst if the mask is valid, else
> the nw src/dst is ignored.
> My
On Mon, 8 Apr 2013 19:39:28 +0900
Isaku Yamahata wrote:
> On Mon, Apr 08, 2013 at 06:08:57PM +0800, can. wrote:
>> FYI, I initially found this bug when parse the packets:
>>
>> pkt = packet.Packet(data)
>> for p in pkt.protocols:
>> print p
>> something_else()
>>
>> if remove __
On Mon, 8 Apr 2013 17:56:28 +0800
"can." wrote:
> The patch seems to be missed since I don't receive any responses. So I send
> this mail as a reminder.
Oops, I missed it. With this, I got:
fujita@rouen:~/git/ryu$ ./run_tests.sh -p
Running pep8 ...
ryu/ofproto/nx_match.py:747:43: E251 no spaces
Hello,
Possible my mail client didn't work last time. At least my gmail showed the
mail wrong formated.
I swapped the mail client and now it should work. Sorry for wrong mails...
>From 85974e5ded85dd6f9e0592d32ffc949c4df3eab0 Mon Sep 17 00:00:00 2001
From: blacksheeep
Date: Mon, 8 Apr 2013 13:03
Hello,
sorry for problems with the patch submission. Hope it works now.
I updated the code for the match_tuple() function:
It installs the match for the network src/dst if the mask is valid, else
the nw src/dst is ignored.
My last patch had an error there, sorry.
Changes:
FIX: match_tuple() func
On Mon, Apr 08, 2013 at 06:08:57PM +0800, can. wrote:
> FYI, I initially found this bug when parse the packets:
>
> pkt = packet.Packet(data)
> for p in pkt.protocols:
> print p
> something_else()
>
> if remove __str__() entirely, would the print work correctly?
Yes, it works. It
On Mon, Apr 08, 2013 at 05:26:05PM +0900, FUJITA Tomonori wrote:
> On Mon, 8 Apr 2013 16:39:55 +0900
> Isaku Yamahata wrote:
>
> > Later some applications uses those arguments.
>
> What are arguments? Why configurations don't work?
Okay, I'll drop this patch.
--
yamahata
Hello,
The patch seems to be missed since I don't receive any responses. So I send
this mail as a reminder.
2013/4/2 can.
> Then how about this:
>
>
> From 3e29f270b921ed871d9cbc8b80d275c9fe19e96f Mon Sep 17 00:00:00 2001
> From: Can Zhang
> Date: Tue, 2 Apr 2013 11:45:20 +0800
> Subject
On Mon, Apr 08, 2013 at 05:24:37PM +0900, FUJITA Tomonori wrote:
> On Mon, 8 Apr 2013 16:39:54 +0900
> Isaku Yamahata wrote:
>
> > Later RyuApp instances will be created/deleted dynamically.
> > For that sake, the single instance of AppManager is necessary.
>
> Why the feature is necessary?
>
On Mon, Apr 08, 2013 at 05:24:00PM +0900, FUJITA Tomonori wrote:
> On Mon, 8 Apr 2013 16:39:57 +0900
> Isaku Yamahata wrote:
>
> > Since ether+ip case is most often used, introduce a convenience function
> > for that.
>
> Not sure about. If you live in real environments, mostly vlan is
> always
FYI, I initially found this bug when parse the packets:
pkt = packet.Packet(data)
for p in pkt.protocols:
print p
something_else()
if remove __str__() entirely, would the print work correctly?
2013/4/8 Isaku Yamahata
> On Sun, Apr 07, 2013 at 04:06:22PM +0800, Can Zhang wrot
On Mon, Apr 08, 2013 at 05:22:41PM +0900, FUJITA Tomonori wrote:
> On Mon, 8 Apr 2013 16:39:53 +0900
> Isaku Yamahata wrote:
>
> > There is a race between RyuApp instantiation and starting its thread.
> > In order to mitigate a race, split RyuApp initialization into creation of
>
> To mitigate
On Mon, 8 Apr 2013 16:39:55 +0900
Isaku Yamahata wrote:
> Later some applications uses those arguments.
What are arguments? Why configurations don't work?
--
Minimize network downtime and maximize team effectiveness.
On Mon, 8 Apr 2013 16:39:54 +0900
Isaku Yamahata wrote:
> Later RyuApp instances will be created/deleted dynamically.
> For that sake, the single instance of AppManager is necessary.
Why the feature is necessary?
--
Mi
On Mon, 8 Apr 2013 16:39:57 +0900
Isaku Yamahata wrote:
> Since ether+ip case is most often used, introduce a convenience function
> for that.
Not sure about. If you live in real environments, mostly vlan is
always used.
-
On Mon, 8 Apr 2013 16:39:53 +0900
Isaku Yamahata wrote:
> There is a race between RyuApp instantiation and starting its thread.
> In order to mitigate a race, split RyuApp initialization into creation of
To mitigate a race simply leads to disaster. Needs to fix it. Please
explain the details.
On Sun, Apr 07, 2013 at 04:06:22PM +0800, Can Zhang wrote:
> Signed-off-by: Can Zhang
> ---
> ryu/lib/packet/lldp.py | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ryu/lib/packet/lldp.py b/ryu/lib/packet/lldp.py
> index f82e00a..e6d77ba 100644
> --- a/ryu/lib/packet/lldp.py
> +++ b/ryu/
Please refer the followings
https://github.com/osrg/ryu/wiki/OpenStack
https://github.com/osrg/ryu/wiki/configuration_openstack_grizzly_with_ryu
https://github.com/osrg/ryu/wiki/RYU-Openstack-Grizzly-environment-HOWTO
thanks,
On Sun, Apr 07, 2013 at 04:36:49PM +0800, zheng mi wrote:
> I have inst
They are exported events and classes.
Signed-off-by: Isaku Yamahata
---
ryu/services/vrrp/event.py | 227
1 file changed, 227 insertions(+)
create mode 100644 ryu/services/vrrp/event.py
diff --git a/ryu/services/vrrp/event.py b/ryu/services/vrrp/ev
Introduce VRRP router class which handles VRRP.
Signed-off-by: Isaku Yamahata
---
ryu/services/vrrp/router.py | 545 +++
1 file changed, 545 insertions(+)
create mode 100644 ryu/services/vrrp/router.py
diff --git a/ryu/services/vrrp/router.py b/ryu/serv
test code for VRRP which handles multiple VRRP routers
Signed-off-by: Isaku Yamahata
---
ryu/tests/integrated/test_vrrp_multi.py | 188 +++
1 file changed, 188 insertions(+)
create mode 100644 ryu/tests/integrated/test_vrrp_multi.py
diff --git a/ryu/tests/integrate
API for VRRP service exported to other RyuApp.
Signed-off-by: Isaku Yamahata
---
ryu/services/vrrp/api.py | 45 +
1 file changed, 45 insertions(+)
create mode 100644 ryu/services/vrrp/api.py
diff --git a/ryu/services/vrrp/api.py b/ryu/services/vrrp
Signed-off-by: Isaku Yamahata
---
ryu/tests/integrated/test_vrrp.py | 134 +
1 file changed, 134 insertions(+)
create mode 100644 ryu/tests/integrated/test_vrrp.py
diff --git a/ryu/tests/integrated/test_vrrp.py
b/ryu/tests/integrated/test_vrrp.py
new file m
Sample router code.
Real router app can use this code as template in order to support VRRP.
Signed-off-by: Isaku Yamahata
---
ryu/services/vrrp/sample_router.py | 423
1 file changed, 423 insertions(+)
create mode 100644 ryu/services/vrrp/sample_router.py
Signed-off-by: Isaku Yamahata
---
ryu/services/vrrp/manager.py | 154 ++
1 file changed, 154 insertions(+)
create mode 100644 ryu/services/vrrp/manager.py
diff --git a/ryu/services/vrrp/manager.py b/ryu/services/vrrp/manager.py
new file mode 100644
index
Signed-off-by: Isaku Yamahata
---
ryu/lib/packet/vrrp.py | 543
1 file changed, 543 insertions(+)
create mode 100644 ryu/lib/packet/vrrp.py
diff --git a/ryu/lib/packet/vrrp.py b/ryu/lib/packet/vrrp.py
new file mode 100644
index 000..18c7a57
Introduce class that manages switch interface on which
VRRP works.
Signed-off-by: Isaku Yamahata
---
ryu/services/vrrp/monitor.py | 261 ++
1 file changed, 261 insertions(+)
create mode 100644 ryu/services/vrrp/monitor.py
diff --git a/ryu/services/vrrp/
It will be used later by VRRP service.
Signed-off-by: Isaku Yamahata
---
ryu/services/vrrp/utils.py | 76
1 file changed, 76 insertions(+)
create mode 100644 ryu/services/vrrp/utils.py
diff --git a/ryu/services/vrrp/utils.py b/ryu/services/vrrp/ut
Signed-off-by: Isaku Yamahata
---
ryu/ofproto/inet.py |1 +
1 file changed, 1 insertion(+)
diff --git a/ryu/ofproto/inet.py b/ryu/ofproto/inet.py
index d3da819..d0ce694 100644
--- a/ryu/ofproto/inet.py
+++ b/ryu/ofproto/inet.py
@@ -25,4 +25,5 @@ IPPROTO_AH = 51
IPPROTO_ICMPV6 = 58
IPPROTO_
Signed-off-by: Isaku Yamahata
---
ryu/services/__init__.py | 15 +++
ryu/services/vrrp/__init__.py | 15 +++
2 files changed, 30 insertions(+)
create mode 100644 ryu/services/__init__.py
create mode 100644 ryu/services/vrrp/__init__.py
diff --git a/ryu/services
Signed-off-by: Isaku Yamahata
---
ryu/tests/unit/packet/test_vrrp.py | 335
1 file changed, 335 insertions(+)
create mode 100644 ryu/tests/unit/packet/test_vrrp.py
diff --git a/ryu/tests/unit/packet/test_vrrp.py
b/ryu/tests/unit/packet/test_vrrp.py
new fil
a sample application which dumps VRRP events
Signed-off-by: Isaku Yamahata
---
ryu/services/vrrp/dumper.py | 154 +++
1 file changed, 154 insertions(+)
create mode 100644 ryu/services/vrrp/dumper.py
diff --git a/ryu/services/vrrp/dumper.py b/ryu/service
allow RyuManager to create/destroy RyuApp instances dynamically
and register/unregister event observer dynamically.
Signed-off-by: Isaku Yamahata
---
ryu/base/app_manager.py | 122 ---
1 file changed, 93 insertions(+), 29 deletions(-)
diff --git a/ry
Signed-off-by: Isaku Yamahata
---
ryu/lib/packet/ipv6.py |5 +
1 file changed, 5 insertions(+)
diff --git a/ryu/lib/packet/ipv6.py b/ryu/lib/packet/ipv6.py
index 5380fb2..f7b8e9b 100644
--- a/ryu/lib/packet/ipv6.py
+++ b/ryu/lib/packet/ipv6.py
@@ -22,6 +22,11 @@ from . import tcp
from r
Signed-off-by: Isaku Yamahata
---
ryu/lib/packet/ipv4.py |5 +
1 file changed, 5 insertions(+)
diff --git a/ryu/lib/packet/ipv4.py b/ryu/lib/packet/ipv4.py
index daf4265..4f48e93 100644
--- a/ryu/lib/packet/ipv4.py
+++ b/ryu/lib/packet/ipv4.py
@@ -23,6 +23,11 @@ from . import tcp
from r
There is a race between RyuApp instantiation and starting its thread.
In order to mitigate a race, split RyuApp initialization into creation of
instance and starting thread.
Introduce RyuApp.start() method to start threads.
Signed-off-by: Isaku Yamahata
---
ryu/base/app_manager.py |8 +++
Later some applications uses those arguments.
Signed-off-by: Isaku Yamahata
---
ryu/base/app_manager.py |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ryu/base/app_manager.py b/ryu/base/app_manager.py
index aece004..95fc0b7 100644
--- a/ryu/base/app_manager.py
+++ b/r
Later RyuApp instances will be created/deleted dynamically.
For that sake, the single instance of AppManager is necessary.
Signed-off-by: Isaku Yamahata
---
bin/ryu-manager |2 +-
ryu/base/app_manager.py |9 +
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a
This patch series adds VRRP service. The patch series is organized as follows
- 1-5: general clean up and improvement
- 6-10: VRRP packet parser/serializer
- 11-21: VRRP implemetation
Sample code is also included to show how to user VRRP service.
thanks,
Isaku Yamahata (21):
base/app_manager:
Since ether+ip case is most often used, introduce a convenience function
for that.
Signed-off-by: Isaku Yamahata
---
ryu/lib/packet/arp.py |9 +
1 file changed, 9 insertions(+)
diff --git a/ryu/lib/packet/arp.py b/ryu/lib/packet/arp.py
index 3cef38d..76a848c 100644
--- a/ryu/lib/pac
49 matches
Mail list logo
