W:225,24:AppManager.instantiate_apps: Redefining built-in 'list'
Signed-off-by: Isaku Yamahata
---
ryu/base/app_manager.py |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ryu/base/app_manager.py b/ryu/base/app_manager.py
index 173e35c..9709657 100644
--- a/ryu/base/app
It's bad practise to catch all exception unconditionally.
Use more specific exception.
pylint
> W: 39,4: No exception type(s) specified
Signed-off-by: Isaku Yamahata
---
ryu/ofproto/__init__.py |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ryu/ofproto/__init__.py b/ryu/
Signed-off-by: Isaku Yamahata
---
ryu/bundle/os_gre.py | 37 +
1 file changed, 37 insertions(+)
create mode 100644 ryu/bundle/os_gre.py
diff --git a/ryu/bundle/os_gre.py b/ryu/bundle/os_gre.py
new file mode 100644
index 000..4b3
--- /dev/null
+++ b/
Later ryu-manager call this method to wait for app loop.
Otherwise ryu-manager exits without waiting for apps.
Signed-off-by: Isaku Yamahata
Conflicts:
ryu/base/app_manager.py
---
ryu/base/app_manager.py |7 +++
1 file changed, 7 insertions(+)
diff --git a/ryu/base/app_manager.
Signed-off-by: Isaku Yamahata
---
ryu/app/simple_switch.py | 14 ++
1 file changed, 14 insertions(+)
diff --git a/ryu/app/simple_switch.py b/ryu/app/simple_switch.py
index 0397bc4..7a49f28 100644
--- a/ryu/app/simple_switch.py
+++ b/ryu/app/simple_switch.py
@@ -13,6 +13,10 @@
# Se
Signed-off-by: Isaku Yamahata
---
bin/ryu-manager | 55 +--
1 file changed, 5 insertions(+), 50 deletions(-)
diff --git a/bin/ryu-manager b/bin/ryu-manager
index 62188de..7afbeec 100755
--- a/bin/ryu-manager
+++ b/bin/ryu-manager
@@ -16,70 +1
The flags.py is the centralized place to handle options.
Register all cli options in flags.py. Later startup routine import flags.py
to register cli options.
Signed-off-by: Isaku Yamahata
---
ryu/flags.py | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git
Signed-off-by: Isaku Yamahata
--
Change v2 -> v3:
- accept positional argument
---
ryu/base/main.py | 100 ++
1 file changed, 100 insertions(+)
create mode 100644 ryu/base/main.py
diff --git a/ryu/base/main.py b/ryu/base/main.py
new file mode
Now RyuApp is able to load bundle, a collection of RyuApp, and accept
class object directly.
Later this feature will simplifies ryu start up.
Signed-off-by: Isaku Yamahata
---
ryu/base/app_manager.py | 106 +++
1 file changed, 89 insertions(+), 17 del
move registration of quantum adapter into quantum adapter module.
Good for modularization.
Signed-off-by: Isaku Yamahata
---
ryu/app/quantum_adapter.py | 23 +++
ryu/flags.py | 26 --
2 files changed, 27 insertions(+), 22 deletions(-)
which will be used by later patch.
Signed-off-by: Isaku Yamahata
---
ryu/utils.py |6 ++
1 file changed, 6 insertions(+)
diff --git a/ryu/utils.py b/ryu/utils.py
index d5b4479..323aa9e 100644
--- a/ryu/utils.py
+++ b/ryu/utils.py
@@ -37,6 +37,12 @@ def import_module(modname):
retur
This patch series introduce bundle, a group of RyuApp.
It simplifies ryu startup.
For example
python ryu/bundle/os_gre.py
ryu-manager ryu/bundle/os_gre.py
python ryu/bundle/os_gre.py --verbose ryu/app/debug/console.py
instead of
./bin/ryu-manager ryu/app/gre_tunnel.py \
Protocols can mow be accesed as packet[n].
Signed-off-by: Shaun Crampton
---
ryu/lib/packet/packet.py | 12
1 file changed, 12 insertions(+)
diff --git a/ryu/lib/packet/packet.py b/ryu/lib/packet/packet.py
index 84e5bf8..2ef08c1 100644
--- a/ryu/lib/packet/packet.py
+++ b/ryu/li
I resent the patch using "git send-email" and sendmail. Hopefully it will
get through this time.
-Shaun
On 01/06/2013 05:17, "FUJITA Tomonori"
wrote:
>I really like improvement for Ryu packet library!
>
>However, like your other patches, it's mal-formed. Can you please
>resend?
>
>On Fri, 24 Ma
2013/6/5 Isaku Yamahata :
> Looks good. Thank you for quick respin.
> Can you please send the patch to ryu-devel?
>
> thanks,
>
I missed the answer-all-button...zzz
>
> For consistency and OF-wire stringify, please use cls_meter_band_xxx.
> i.e.
> cls.cls_meter_band_type = type_
>
On Wed, Jun 05, 2013 at 01:57:34PM +0900, watanabe.fumitaka wrote:
>
> Signed-off-by: WATANABE Fumitaka
> ---
> ryu/lib/packet/packet_base.py | 18 ++
> 1 file changed, 18 insertions(+)
>
> diff --git a/ryu/lib/packet/packet_base.py b/ryu/lib/packet/packet_base.py
> index b0ae
Why not _STR_CONVERT be class attribute instead of instance attribute?
thanks,
On Wed, Jun 05, 2013 at 01:58:19PM +0900, watanabe.fumitaka wrote:
> Add an individual conversion process to ethernet.py and ipv4.py
>
> Individual conversion is needed to the variable it cannot be
> understood that d
Hi. It's already fixed by change set of
95963e3cedeb9b7371770414037654e675f325ff
which is same to your proposal.
Please switch to Ryu 2.0 release or use the git repository.
thanks,
On Wed, Jun 05, 2013 at 03:25:45PM +0300, Oren Spector wrote:
> Hi,
>
>
>
> Thanks for the fix. It works fine.
Thank you for update.
Basically looks good except some comments inlined.
On Wed, Jun 05, 2013 at 03:25:41PM +0200, Philipp Aeschlimann wrote:
> Hey
>
> Here we go with the MeterMod messages, still todo is:
>
> - parsers methods for DSCP and experimenter
> - OFPMeterConfigStats should parse all
Hey
Here we go with the MeterMod messages, still todo is:
- parsers methods for DSCP and experimenter
- OFPMeterConfigStats should parse all MeterBandTypes, not only common header
- THX for all comments in advance
>From 3fca86530024f3b7d2429a72609981e606398085 Mon Sep 17 00:00:00 2001
From: Aesc
Hi,
Thanks for the fix. It works fine.
I encountered another problem related to OpenFlow 1.3. My application waits
for the PORT_STATUS event. When connecting to an OpenFlow 1.0 client it
works fine, but when connecting to an OpenFlow 1.3 client the following
error occurs:
Traceback (mos
Signed-off-by: Isaku Yamahata
---
ryu/bundle/os_gre.py | 37 +
1 file changed, 37 insertions(+)
create mode 100644 ryu/bundle/os_gre.py
diff --git a/ryu/bundle/os_gre.py b/ryu/bundle/os_gre.py
new file mode 100644
index 000..4b3
--- /dev/null
+++ b/
Now RyuApp is able to load bundle, a collection of RyuApp, and accept
class object directly.
Later this feature will simplifies ryu start up.
Signed-off-by: Isaku Yamahata
---
ryu/base/app_manager.py | 106 +++
1 file changed, 89 insertions(+), 17 del
Signed-off-by: Isaku Yamahata
---
bin/ryu-manager | 51 ---
1 file changed, 4 insertions(+), 47 deletions(-)
diff --git a/bin/ryu-manager b/bin/ryu-manager
index 62188de..7ea0193 100755
--- a/bin/ryu-manager
+++ b/bin/ryu-manager
@@ -16,31 +16,10
Signed-off-by: Isaku Yamahata
---
ryu/base/main.py | 91 ++
1 file changed, 91 insertions(+)
create mode 100644 ryu/base/main.py
diff --git a/ryu/base/main.py b/ryu/base/main.py
new file mode 100644
index 000..a414d01
--- /dev/null
+++ b
W:225,24:AppManager.instantiate_apps: Redefining built-in 'list'
Signed-off-by: Isaku Yamahata
---
ryu/base/app_manager.py |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ryu/base/app_manager.py b/ryu/base/app_manager.py
index 173e35c..9709657 100644
--- a/ryu/base/app
It's bad practise to catch all exception unconditionally.
Use more specific exception.
pylint
> W: 39,4: No exception type(s) specified
Signed-off-by: Isaku Yamahata
---
ryu/ofproto/__init__.py |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ryu/ofproto/__init__.py b/ryu/
Later ryu-manager call this method to wait for app loop.
Otherwise ryu-manager exits without waiting for apps.
Signed-off-by: Isaku Yamahata
Conflicts:
ryu/base/app_manager.py
---
ryu/base/app_manager.py |7 +++
1 file changed, 7 insertions(+)
diff --git a/ryu/base/app_manager.
This patch series introduce bundle, a group of RyuApp.
It simplifies ryu startup.
For example
python ryu/bundle/os_gre.py
or
ryu-manager ryu/bundle/os_gre.py
instead of
./bin/ryu-manager ryu/app/gre_tunnel.py \
ryu/app/quantum_adapter.py \
ryu/app/r
Signed-off-by: Isaku Yamahata
---
ryu/app/simple_switch.py | 14 ++
1 file changed, 14 insertions(+)
diff --git a/ryu/app/simple_switch.py b/ryu/app/simple_switch.py
index 0397bc4..7a49f28 100644
--- a/ryu/app/simple_switch.py
+++ b/ryu/app/simple_switch.py
@@ -13,6 +13,10 @@
# Se
which will be used by later patch.
Signed-off-by: Isaku Yamahata
---
ryu/utils.py |6 ++
1 file changed, 6 insertions(+)
diff --git a/ryu/utils.py b/ryu/utils.py
index d5b4479..323aa9e 100644
--- a/ryu/utils.py
+++ b/ryu/utils.py
@@ -37,6 +37,12 @@ def import_module(modname):
retur
Signed-off-by: YAMAMOTO Takashi
---
ryu/ofproto/ofproto_v1_3_parser.py | 452 +++--
1 file changed, 230 insertions(+), 222 deletions(-)
diff --git a/ryu/ofproto/ofproto_v1_3_parser.py
b/ryu/ofproto/ofproto_v1_3_parser.py
index 86991d7..4150307 100644
--- a/ryu/o
Signed-off-by: YAMAMOTO Takashi
---
ryu/ofproto/ofproto_v1_2_parser.py| 390 +++---
ryu/tests/unit/ofproto/test_parser_v12.py | 108 -
2 files changed, 253 insertions(+), 245 deletions(-)
diff --git a/ryu/ofproto/ofproto_v1_2_parser.py
b/ryu/ofproto/ofpr
Signed-off-by: YAMAMOTO Takashi
---
ryu/ofproto/ofproto_v1_3_parser.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/ryu/ofproto/ofproto_v1_3_parser.py
b/ryu/ofproto/ofproto_v1_3_parser.py
index 524994d..86991d7 100644
--- a/ryu/ofproto/ofproto_v1_3_parser.py
+++ b/ryu/ofproto/ofproto_v1_
Signed-off-by: YAMAMOTO Takashi
---
ryu/ofproto/nx_match.py | 6 ++
1 file changed, 6 insertions(+)
diff --git a/ryu/ofproto/nx_match.py b/ryu/ofproto/nx_match.py
index be65eb5..40c98df 100644
--- a/ryu/ofproto/nx_match.py
+++ b/ryu/ofproto/nx_match.py
@@ -114,6 +114,8 @@ class FlowWildcard
35 matches
Mail list logo
