[Ryu-devel] [PATCH v2] app/rest_firewall: add API for VLAN configuration

2013-06-12 Thread watanabe.fumitaka
add REST-API for VLAN configuration of rest_firewall application. it implements handling each vlan groups separately. This update(v1->v2) contains the following change. make function of conversion of cookie and ruleID for easily understanding. Signed-off-by: WATANABE Fumitaka --- ryu/app/re

Re: [Ryu-devel] [PATCH 11/18] of12: json representation

2013-06-12 Thread Isaku Yamahata
On Thu, Jun 13, 2013 at 01:33:46PM +0900, YAMAMOTO Takashi wrote: > >> def parser(cls, datapath, version, msg_type, msg_len, xid, buf): > >> @@ -195,7 +200,7 @@ class OFPSwitchFeatures(MsgBase): > >> msg.n_buffers, > >> msg.n_tables, > >> msg.capabilities, > >> -

Re: [Ryu-devel] [PATCH 12/18] of12 OFPMatch: make length private

2013-06-12 Thread Isaku Yamahata
On Wed, Jun 12, 2013 at 07:44:12PM +0900, YAMAMOTO Takashi wrote: > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/ofproto/ofproto_v1_2_parser.py | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/ryu/ofproto/ofproto_v1_2_parser.py > b/ryu/ofproto/ofproto_v1_2

Re: [Ryu-devel] [PATCH 11/18] of12: json representation

2013-06-12 Thread YAMAMOTO Takashi
>> def parser(cls, datapath, version, msg_type, msg_len, xid, buf): >> @@ -195,7 +200,7 @@ class OFPSwitchFeatures(MsgBase): >> msg.n_buffers, >> msg.n_tables, >> msg.capabilities, >> - msg.reserved) = struct.unpack_from( >> + msg._reserved) = stru

Re: [Ryu-devel] [PATCH 11/18] of12: json representation

2013-06-12 Thread Isaku Yamahata
On Wed, Jun 12, 2013 at 07:44:11PM +0900, YAMAMOTO Takashi wrote: > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/ofproto/ofproto_v1_2.py| 12 ++ > ryu/ofproto/ofproto_v1_2_parser.py | 246 > + > 2 files changed, 180 insertions(+), 78 deletions(-) >

Re: [Ryu-devel] [PATCH 09/18] json representation of of-wire classes

2013-06-12 Thread Isaku Yamahata
On Wed, Jun 12, 2013 at 07:44:09PM +0900, YAMAMOTO Takashi wrote: > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/ofproto/ofproto_parser.py | 151 > +- > 1 file changed, 149 insertions(+), 2 deletions(-) > > diff --git a/ryu/ofproto/ofproto_parser.py b/r

Re: [Ryu-devel] [PATCH 01/18] datapath_connection_factory deal with None datapath.id

2013-06-12 Thread Isaku Yamahata
On Wed, Jun 12, 2013 at 07:44:01PM +0900, YAMAMOTO Takashi wrote: > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/controller/controller.py | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/ryu/controller/controller.py b/ryu/controller/controller.py > index 66d

Re: [Ryu-devel] Question : OpenFlow Error (type=1, code=7)

2013-06-12 Thread Isaku Yamahata
On Wed, Jun 12, 2013 at 10:28:36PM +0900, imeat u wrote: > Hi, > > > > What do you want to achieve? > > I'm sorry I couldn't express myself properly. You mean Ryu plugin? devstack runs ryu-manager for you. So you should not run simple_switch.py. thanks, > > I want to let "Ping command" succ

Re: [Ryu-devel] how to write into flow table of LINC switch

2013-06-12 Thread Gandhimathi Velusamy
Hi YAMAMOTO Takashi, Now I am able to get fields on the flow table entries whatever I used for matching. Thank you so much. Gandhi On 12 June 2013 02:02, YAMAMOTO Takashi wrote: > hi, > > please don't drop ML Cc. > > i meant something like this. > https://github.com/FlowForwarding/LINC-Sw

[Ryu-devel] Send custom-event from AppOne to AppTwo

2013-06-12 Thread Philipp Aeschlimann
Hey there Whats the right way to implement a custom-Event between two app's? That's the way I have done this: ### file: ryu/app/app_one.py ### import ryu.app.AppOne ... class EventAppOne(event.EventBase): def __init__ ... ... class AppOne(app_manager.RyuApp): def __init__ ...

[Ryu-devel] Ryu app/cli.py question

2013-06-12 Thread David Ganor
Hi, I'm trying to run the app/cli.py application. I've found 2 versions of the file: an older one supporting telnet and a newer one supporting ssh. I've also created the required logger.py, management.py, plogger.py and call_via_pipe.py files. They both run, but when trying to connect the server

Re: [Ryu-devel] Question : OpenFlow Error (type=1, code=7)

2013-06-12 Thread imeat u
Hi, > What do you want to achieve? I'm sorry I couldn't express myself properly. I want to let "Ping command" succeed. o Network Node # ip netns exec qdhcp-d7b85689-cc2e-4420-bc54-1927ee3a3be2 ping 172.17.0.3 PING 172.17.0.3 (172.17.0.3) 56(84) bytes of data. From 172.17.0.2 icmp_s

[Ryu-devel] [PATCH 03/18] of13: add missing itertools import

2013-06-12 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/ofproto/ofproto_v1_3_parser.py | 1 + 1 file changed, 1 insertion(+) diff --git a/ryu/ofproto/ofproto_v1_3_parser.py b/ryu/ofproto/ofproto_v1_3_parser.py index f8221f2..12c41df 100644 --- a/ryu/ofproto/ofproto_v1_3_parser.py +++ b/ryu/ofproto/ofproto_v1_

[Ryu-devel] [PATCH 06/18] of12 OFPMatch: consistently use None to represent "no mask"

2013-06-12 Thread YAMAMOTO Takashi
instead of UINTxx_MAX, [], a lack of the "mask" attribute, etc remove automatic-mask functionality. it's caller's responsibility to ensure (value & mask) == value now. Signed-off-by: YAMAMOTO Takashi --- ryu/ofproto/ofproto_v1_2_parser.py| 110 ++ ryu/tests/u

[Ryu-devel] [PATCH 10/18] of-wire json: adapt OF1.0

2013-06-12 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi Signed-off-by: YAMAMOTO Takashi --- ryu/ofproto/ofproto_v1_0_parser.py | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_0_parser.py b/ryu/ofproto/ofproto_v1_0_parser.py index 8bca9e9..f647d0c 100644 --- a/ryu/

[Ryu-devel] [PATCH 16/18] of-wire json: a program to generate test data for unit tests

2013-06-12 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/tests/unit/ofproto/mkdata/Makefile | 5 + ryu/tests/unit/ofproto/mkdata/rebar.config | 3 +++ ryu/tests/unit/ofproto/mkdata/src/er.app.src | 8 +++ ryu/tests/unit/ofproto/mkdata/src/x.erl | 31 4 files c

[Ryu-devel] [PATCH 07/18] ofctl_v1_2.actions_to_str: ignore unknown instructions

2013-06-12 Thread YAMAMOTO Takashi
avoid crashing when the switch happens to have flows with non OFPInstructionActions instructions. Signed-off-by: YAMAMOTO Takashi --- ryu/lib/ofctl_v1_2.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ryu/lib/ofctl_v1_2.py b/ryu/lib/ofctl_v1_2.py index 0789bf6..d08bb21 100644 --- a/ryu

[Ryu-devel] [PATCH 09/18] json representation of of-wire classes

2013-06-12 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/ofproto/ofproto_parser.py | 151 +- 1 file changed, 149 insertions(+), 2 deletions(-) diff --git a/ryu/ofproto/ofproto_parser.py b/ryu/ofproto/ofproto_parser.py index 73a6d9e..e88802e 100644 --- a/ryu/ofproto/ofprot

[Ryu-devel] [PATCH 15/18] of-wire json: unit test

2013-06-12 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/tests/unit/ofproto/test_parser.py | 105 ++ 1 file changed, 105 insertions(+) create mode 100644 ryu/tests/unit/ofproto/test_parser.py diff --git a/ryu/tests/unit/ofproto/test_parser.py b/ryu/tests/unit/ofproto/test_parse

[Ryu-devel] [PATCH 13/18] test_parser_v12 abuse this to test to_jsondict and from_jsondict

2013-06-12 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/tests/unit/ofproto/test_parser_v12.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/ryu/tests/unit/ofproto/test_parser_v12.py b/ryu/tests/unit/ofproto/test_parser_v12.py index 550a47b..57fe78c 100644 --- a/ryu/tests/unit/ofproto/test_par

[Ryu-devel] [PATCH 05/18] of13: prefix private attributes of OFPMatch with _

2013-06-12 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/ofproto/ofproto_v1_3_parser.py | 452 +++-- 1 file changed, 230 insertions(+), 222 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_3_parser.py b/ryu/ofproto/ofproto_v1_3_parser.py index 12c41df..c54205b 100644 --- a/ryu/o

[Ryu-devel] [PATCH 04/18] of12: prefix private attributes of OFPMatch with _

2013-06-12 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/ofproto/ofproto_v1_2_parser.py| 390 +++--- ryu/tests/unit/ofproto/test_parser_v12.py | 108 - 2 files changed, 253 insertions(+), 245 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_2_parser.py b/ryu/ofproto/ofpr

[Ryu-devel] [PATCH 14/18] of12 json: update tests

2013-06-12 Thread YAMAMOTO Takashi
some internal members were renamed. (OFPSwitchFeatures, OFPPacketOut) Signed-off-by: YAMAMOTO Takashi --- ryu/tests/unit/ofproto/test_parser_v12.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ryu/tests/unit/ofproto/test_parser_v12.py b/ryu/tests/unit/ofproto/test_par

[Ryu-devel] [PATCH 00/18] RFC: OFPxxx jsonify

2013-06-12 Thread YAMAMOTO Takashi
this is an updated RFC patch set for OFPxxx <-> json conversion. this includes some not-so-related patches posted here but not merged yet. i'd like to ask comments about esp. unit test parts. (the last several patches) changes from the previous one: - adapt the major part of OF1.2. - unit tests

[Ryu-devel] [PATCH 01/18] datapath_connection_factory deal with None datapath.id

2013-06-12 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/controller/controller.py | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/ryu/controller/controller.py b/ryu/controller/controller.py index 66d50a3..60943b7 100644 --- a/ryu/controller/controller.py +++ b/ryu/controller/contr

[Ryu-devel] [PATCH 17/18] of-wire json: generated data for unit test

2013-06-12 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/tests/unit/ofproto/data/ofp_desc_stats_reply.packet | Bin 0 -> 1072 bytes ryu/tests/unit/ofproto/data/ofp_packet_out.packet | Bin 0 -> 138 bytes 2 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 ryu/tests/unit/ofproto/data/ofp_de

[Ryu-devel] [PATCH 11/18] of12: json representation

2013-06-12 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/ofproto/ofproto_v1_2.py| 12 ++ ryu/ofproto/ofproto_v1_2_parser.py | 246 + 2 files changed, 180 insertions(+), 78 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_2.py b/ryu/ofproto/ofproto_v1_2.py index 27fc6

[Ryu-devel] [PATCH 18/18] of-wire json: expected results

2013-06-12 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- .../unit/ofproto/data/ofp_desc_stats_reply.packet.json| 14 ++ ryu/tests/unit/ofproto/data/ofp_packet_out.packet.json| 15 +++ 2 files changed, 29 insertions(+) create mode 100644 ryu/tests/unit/ofproto/data/ofp_desc_stats_repl

[Ryu-devel] [PATCH 12/18] of12 OFPMatch: make length private

2013-06-12 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/ofproto/ofproto_v1_2_parser.py | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_2_parser.py b/ryu/ofproto/ofproto_v1_2_parser.py index d13d044..6c0cead 100644 --- a/ryu/ofproto/ofproto_v1_2_parser.py

[Ryu-devel] [PATCH 02/18] nx_match: some comments

2013-06-12 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/ofproto/nx_match.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ryu/ofproto/nx_match.py b/ryu/ofproto/nx_match.py index be65eb5..40c98df 100644 --- a/ryu/ofproto/nx_match.py +++ b/ryu/ofproto/nx_match.py @@ -114,6 +114,8 @@ class FlowWildcard

[Ryu-devel] [PATCH 08/18] rest_firewall: stop using ofproto_v1_2_parser.UINTxxx_MAX

2013-06-12 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/app/rest_firewall.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ryu/app/rest_firewall.py b/ryu/app/rest_firewall.py index e67ccd5..f007489 100644 --- a/ryu/app/rest_firewall.py +++ b/ryu/app/rest_firewall.py @@ -105,9 +105,

Re: [Ryu-devel] how to write into flow table of LINC switch

2013-06-12 Thread YAMAMOTO Takashi
hi, please don't drop ML Cc. i meant something like this. https://github.com/FlowForwarding/LINC-Switch/pull/89 YAMAMOTO Takashi > hi, > >> {ofp_message,4,flow_mod,1564942082,{ofp_flow_mod,<<0,0,0,0,0,0,0,0>>,<<0,0,0,0,0,0,0,0>>,0,add,0,0,126,65535,any,any,[],{ofp_match,[{ofp_field,openflow_ba