Re: [Ryu-devel] [PATCH v2 0/5] add conversion tostring to packet library

2013-06-13 Thread watanabe.fumitaka
hi, > i moved the code around for non-ofproto users in my tree. > https://github.com/yamt/ryu/blob/stringify6/ryu/lib/stringify.py I will use stringify.py Is there any schedule which contributeds patch to ryu-devel? thanks. (2013/06/13 17:45), YAMAMOTO Takashi wrote: > hi, > >> this upd

Re: [Ryu-devel] Send custom-event from AppOne to AppTwo

2013-06-13 Thread Isaku Yamahata
The vrrp patch series would be a good example. http://thread.gmane.org/gmane.network.ryu.devel/2557 thanks, On Wed, Jun 12, 2013 at 04:18:17PM +0200, Philipp Aeschlimann wrote: > Hey there > > Whats the right way to implement a custom-Event between two app's? > That's the way I have done this:

Re: [Ryu-devel] [PATCH v2 0/5] add conversion tostring to packet library

2013-06-13 Thread Isaku Yamahata
Unit test please. At least basic one. thanks, On Thu, Jun 13, 2013 at 05:34:24PM +0900, watanabe.fumitaka wrote: > add conversion to string of all member variable of each packet library. > this patch is > Based heavily on commit 2ef1107: ryu/ofproto/ofproto_parser.py by YAMAMOTO > Takashi. > >

Re: [Ryu-devel] [PATCH v2 4/5] ofproto/ofproto_parser: add string conversion

2013-06-13 Thread Isaku Yamahata
Is this needed for of-wire stringification? If no, please use inheritance and move the common code under lib. Is it necessary for STR_CONVERT to be public? If possible, please make it private. i.e. prepend '_' prefix. thanks, On Thu, Jun 13, 2013 at 05:35:40PM +0900, watanabe.fumitaka wrote: > S

Re: [Ryu-devel] [PATCH v2 0/5] add conversion tostring to packet library

2013-06-13 Thread Isaku Yamahata
dhcp, icmpv6 and lldp needs to be addressed. On Thu, Jun 13, 2013 at 05:34:24PM +0900, watanabe.fumitaka wrote: > add conversion to string of all member variable of each packet library. > this patch is > Based heavily on commit 2ef1107: ryu/ofproto/ofproto_parser.py by YAMAMOTO > Takashi. > > S

Re: [Ryu-devel] Question : OpenFlow Error (type=1, code=7)

2013-06-13 Thread Yoshihiro Kaneko
Hello, Why do you want to use simple_switch? simple_switch cannot use with Quantum Ryu plugin. I recommend use of gre_tunnel or simple_vlan. Thanks, Kaneko 2013/6/13 Isaku Yamahata : > On Wed, Jun 12, 2013 at 10:28:36PM +0900, imeat u wrote: >> Hi, >> >> >> > What do you want to achieve? >> >>

Re: [Ryu-devel] [PATCH v2 0/5] add conversion tostring to packet library

2013-06-13 Thread YAMAMOTO Takashi
hi, > this update(v1->v2) contains following change. > use of ofproto_parser.StringifyMixin class. i moved the code around for non-ofproto users in my tree. https://github.com/yamt/ryu/blob/stringify6/ryu/lib/stringify.py YAMAMOTO Takashi -

[Ryu-devel] [PATCH v2 3/5] lib/packet/packet: use of tostring function

2013-06-13 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/packet.py |9 + 1 file changed, 9 insertions(+) diff --git a/ryu/lib/packet/packet.py b/ryu/lib/packet/packet.py index d6aeed7..fb69e7c 100644 --- a/ryu/lib/packet/packet.py +++ b/ryu/lib/packet/packet.py @@ -125,3 +125,12 @@ class

[Ryu-devel] [PATCH v2 4/5] ofproto/ofproto_parser: add string conversion

2013-06-13 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/ofproto/ofproto_parser.py |5 + 1 file changed, 5 insertions(+) diff --git a/ryu/ofproto/ofproto_parser.py b/ryu/ofproto/ofproto_parser.py index 73a6d9e..86c00d0 100644 --- a/ryu/ofproto/ofproto_parser.py +++ b/ryu/ofproto/ofproto_parser.py @@ -62

[Ryu-devel] [PATCH v2 5/5] lib/packet/ethernet and ipv4: add an individual conversion

2013-06-13 Thread watanabe.fumitaka
Add an individual conversion process to ethernet.py and ipv4.py Individual conversion is needed to the variable it cannot be understood that does not conversion, like MAC address or IP address. and it is required for other packet libraries. Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/

[Ryu-devel] [PATCH v2 2/5] lib/packet/icmp: inherit StringifyMixin

2013-06-13 Thread watanabe.fumitaka
To inherit StringifyMixin is required for other packet libraries like icmpv6.echo which does not inherit PacketBase, too. Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/icmp.py |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ryu/lib/packet/icmp.py b/ryu/lib/pack

[Ryu-devel] [PATCH v2 1/5] lib/packet/packet_base: inherit StringifyMixin

2013-06-13 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/packet_base.py |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ryu/lib/packet/packet_base.py b/ryu/lib/packet/packet_base.py index b0aeca0..ee573da 100644 --- a/ryu/lib/packet/packet_base.py +++ b/ryu/lib/packet/pack

[Ryu-devel] [PATCH v2 0/5] add conversion tostring to packet library

2013-06-13 Thread watanabe.fumitaka
add conversion to string of all member variable of each packet library. this patch is Based heavily on commit 2ef1107: ryu/ofproto/ofproto_parser.py by YAMAMOTO Takashi. Sample of an output. ethernet(src='ff:ff:ff:ff:ff:ff',ethertype='0x0806',dst='ff:ff:ff:ff:ff:ff') ipv4(src='131.151.32.21'