[Ryu-devel] [PATCH v4 0/2] add router Ryu application

2013-06-19 Thread watanabe.fumitaka
This update(v3->v4) contains the following changes. icmp.py: Update document of some attributes. Drop unused attribute. rest_router.py: Improvement of a functional assignment about RouterController, Router and VlanRouter class. Improvement of the thread leak. Add sleep proces

[Ryu-devel] [PATCH v4 1/2] add ICMP sub encoder/decoder class

2013-06-19 Thread watanabe.fumitaka
Add ICMP sub encoder/decoder class for Destination Unreachable Message. and, add parser to TimeExceeded class. Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/icmp.py | 117 +--- 1 file changed, 111 insertions(+), 6 deletions(-) diff --git a/ryu

Re: [Ryu-devel] l2_switch_v1_3.py takes time to ping the other VM

2013-06-19 Thread Isaku Yamahata
Added linc-dev to Cc to as l2_switch_v1_3.py is in LINC repo. thanks, On Wed, Jun 19, 2013 at 02:06:35PM -0500, Gandhimathi Velusamy wrote: > Hi, > I am working on LINC testbed set-up. If I use the of_controller_v4.erl, which > is available in the scripts folder of LINC-Switch, the Ping command w

Re: [Ryu-devel] [PATCH] lib/packet/vrrp: wrong ipv4 address detection

2013-06-19 Thread FUJITA Tomonori
On Thu, 20 Jun 2013 13:41:12 +0900 Isaku Yamahata wrote: > On Thu, Jun 20, 2013 at 07:07:25AM +0900, FUJITA Tomonori wrote: >> On Wed, 12 Jun 2013 12:28:33 +0900 >> Isaku Yamahata wrote: >> >> > On 32bit environment integer representation of ipv4 address can be >> > python int or long. Some uni

Re: [Ryu-devel] [PATCH] lib/packet/vrrp: wrong ipv4 address detection

2013-06-19 Thread Isaku Yamahata
On Thu, Jun 20, 2013 at 07:07:25AM +0900, FUJITA Tomonori wrote: > On Wed, 12 Jun 2013 12:28:33 +0900 > Isaku Yamahata wrote: > > > On 32bit environment integer representation of ipv4 address can be > > python int or long. Some unit tests failed. > > On the other hand 64 bit environment it is int

Re: [Ryu-devel] [PATCH 08/19] ofctl_v1_2.actions_to_str: ignore unknown instructions

2013-06-19 Thread FUJITA Tomonori
On Tue, 18 Jun 2013 16:35:32 +0900 YAMAMOTO Takashi wrote: > avoid crashing when the switch happens to have flows with > non OFPInstructionActions instructions. > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/lib/ofctl_v1_2.py | 3 +++ > 1 file changed, 3 insertions(+) Applied. -

Re: [Ryu-devel] [PATCH] lib/packet/vrrp: wrong ipv4 address detection

2013-06-19 Thread FUJITA Tomonori
On Wed, 12 Jun 2013 12:28:33 +0900 Isaku Yamahata wrote: > On 32bit environment integer representation of ipv4 address can be > python int or long. Some unit tests failed. > On the other hand 64 bit environment it is int. > And some clean up. > > FAIL: Failure: AssertionError () > > Traceback (

Re: [Ryu-devel] [PATCH 07/19] of12 OFPMatch: consistently use None to represent "no mask"

2013-06-19 Thread FUJITA Tomonori
On Tue, 18 Jun 2013 16:35:31 +0900 YAMAMOTO Takashi wrote: > instead of UINTxx_MAX, [], a lack of the "mask" attribute, etc > > remove automatic-mask functionality. > it's caller's responsibility to ensure (value & mask) == value now. Can we preserve the above? It would be always better not to b

Re: [Ryu-devel] [PATCH 01/19] datapath_connection_factory deal with None datapath.id

2013-06-19 Thread FUJITA Tomonori
On Tue, 18 Jun 2013 16:35:25 +0900 YAMAMOTO Takashi wrote: > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/controller/controller.py | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) Applied. -- This SF.n

Re: [Ryu-devel] [PATCH 05/19] of12: prefix private attributes of OFPMatch with _

2013-06-19 Thread FUJITA Tomonori
On Tue, 18 Jun 2013 16:35:29 +0900 YAMAMOTO Takashi wrote: > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/ofproto/ofproto_v1_2_parser.py| 390 > +++--- > ryu/tests/unit/ofproto/test_parser_v12.py | 108 - > 2 files changed, 253 insertions(+), 245 delet

Re: [Ryu-devel] [PATCH 02/19] nx_match: some comments

2013-06-19 Thread FUJITA Tomonori
On Tue, 18 Jun 2013 16:35:26 +0900 YAMAMOTO Takashi wrote: > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/ofproto/nx_match.py | 6 ++ > 1 file changed, 6 insertions(+) Applied, however, I think that we should remove incomplete match_tuple() > diff --git a/ryu/ofproto/nx_match.py b/ryu/

Re: [Ryu-devel] [PATCH 06/19] of13: prefix private attributes of OFPMatch with _

2013-06-19 Thread FUJITA Tomonori
On Tue, 18 Jun 2013 16:35:30 +0900 YAMAMOTO Takashi wrote: > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/ofproto/ofproto_v1_3_parser.py | 452 > +++-- > 1 file changed, 230 insertions(+), 222 deletions(-) Applied, thanks. It would be nice if you can add test

Re: [Ryu-devel] Sending MeterMod messages

2013-06-19 Thread FUJITA Tomonori
On Wed, 19 Jun 2013 11:24:59 +0200 Philipp Aeschlimann wrote: > This is a second patch for the MeterMod messages to apply a Meter to a flow. > > >From 9aab054fea03e94a5b8e64f345ab9cc26ba5e91b Mon Sep 17 00:00:00 2001 > From: Aeschlimann Philipp > Date: Wed, 19 Jun 2013 11:19:07 +0200 > Subject:

Re: [Ryu-devel] [PATCH] quantum_adapter: check if quantum_controller_addr is valid

2013-06-19 Thread FUJITA Tomonori
On Tue, 18 Jun 2013 17:50:50 +0900 Isaku Yamahata wrote: > With this, more understandable error will be produced. > Otherwise it results in mysterious error like > > transaction error: {"details":"Table Bridge column controller row > 69da7121-51fa-4d6e-ad24-18ff9c857b87 references nonexistent r

Re: [Ryu-devel] [PATCH] packet lib: avoid exception for bogus protocol header parsing

2013-06-19 Thread FUJITA Tomonori
On Mon, 17 Jun 2013 20:58:55 +0900 FUJITA Tomonori wrote: > > Signed-off-by: FUJITA Tomonori > --- > ryu/lib/packet/packet.py | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) Applied. -- This SF

Re: [Ryu-devel] [PATCH 01/10] of12: fix OFPExperimenter parser

2013-06-19 Thread FUJITA Tomonori
On Wed, 19 Jun 2013 15:09:13 +0900 YAMAMOTO Takashi wrote: > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/ofproto/ofproto_v1_2_parser.py | 1 + > 1 file changed, 1 insertion(+) Applied all, thanks a lot! -- This SF.

[Ryu-devel] l2_switch_v1_3.py takes time to ping the other VM

2013-06-19 Thread Gandhimathi Velusamy
Hi, I am working on LINC testbed set-up. If I use the of_controller_v4.erl, which is available in the scripts folder of LINC-Switch, the Ping command works immediately. But if I use Ryu controller with l2_switch_v1_3.py, it takes time for Ping to work. As soon as the Ping command is issued from VM1

Re: [Ryu-devel] Sending MeterMod messages

2013-06-19 Thread Philipp Aeschlimann
This is a second patch for the MeterMod messages to apply a Meter to a flow. >From 9aab054fea03e94a5b8e64f345ab9cc26ba5e91b Mon Sep 17 00:00:00 2001 From: Aeschlimann Philipp Date: Wed, 19 Jun 2013 11:19:07 +0200 Subject: [PATCH] Added InstructionMeter Signed-off-by: Philipp Aeschlimann --- ry

Re: [Ryu-devel] Send custom-event from AppOne to AppTwo

2013-06-19 Thread Philipp Aeschlimann
Hey Isaku Yes I see, the events are in a separated file. Whenever you throw an event or listen to one, you will have something like this in your code: from ryu.services.vrrp import event as vrrp_event ev.__class__ attribute and obsersers dict in get_observers in the app_manager will have a value

Re: [Ryu-devel] [Question] How to get the statistic information (e.g., packet_counter) from openvswitch

2013-06-19 Thread Bo HU (Haku Ko)
Hi Kei Thanks for your kind response. It works well. What I did is just to combine the codes on the site you introduced with "simple_switch.py". Our next step is to control the flow by considering the traffic information such as the number of packets. Many thanks, Bo (2013/06/18 21:11), OHMUR