[Ryu-devel] [PATCH v5 2/3] packet lib to string: add __str__ to base

2013-08-04 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/packet.py |4 1 file changed, 4 insertions(+) diff --git a/ryu/lib/packet/packet.py b/ryu/lib/packet/packet.py index f80948a..785a28b 100644 --- a/ryu/lib/packet/packet.py +++ b/ryu/lib/packet/packet.py @@ -127,3 +127,7 @@ class Packet

[Ryu-devel] [PATCH v5 3/3] packet lib to string: unit tests

2013-08-04 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/tests/unit/packet/test_dhcp.py | 111 +++ ryu/tests/unit/packet/test_icmp.py | 67 + ryu/tests/unit/packet/test_icmpv6.py | 75 ++ ryu/tests/unit/packet/test_ipv6.py | 65 + ryu/tests/unit/packet/test_lldp.p

[Ryu-devel] [PATCH v5 0/3] packet lib to string

2013-08-04 Thread watanabe.fumitaka
Changes v4 -> v5 - Not adding individual string conversion process because it was solved by 'ryu.lib.addrconv' patch. Add conversion to string of all member variable of each packet library. --- ryu/lib/packet/dhcp.py |6 +- ryu/lib/packet/icmp.py |7 +- r

[Ryu-devel] [PATCH v5 1/3] packet lib to string: inherits StringifyMixin

2013-08-04 Thread watanabe.fumitaka
Some class inherits stringify.StringifyMixin and, remove class variable 'tlvs' (not used as class variable and interferes to string) from lldp.lldp Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/dhcp.py|6 -- ryu/lib/packet/icmp.py|7 --- ryu/lib/packet/icm

Re: [Ryu-devel] AttributeError in DPSet with OpenFlow 1.3

2013-08-04 Thread Satoshi Kobayashi
Hi, I tried the patch. I checked that the exception was not raised. P.S. There is a method which reformed it now because DPSet is regacy? Thanks! Satoshi 2013/8/2 FUJITA Tomonori > On Fri, 2 Aug 2013 14:41:51 +0900 > Satoshi Kobayashi wrote: > > > Hi, > > > > I tried OpenFlow 1.3 on my appli

Re: [Ryu-devel] linking error in RYU

2013-08-04 Thread Isaku Yamahata
Basically looks good. some comments inlined. And can you please send the updated patch with your signed-off-by? On Fri, Aug 02, 2013 at 10:21:20AM -0400, Glenn McGuire wrote: > I've been using the latest RYU source from GIT, and building my own python > eggs. When launching ryu-manager, I get th

Re: [Ryu-devel] [PATCH 30/36] packet.vrrp: comment

2013-08-04 Thread YAMAMOTO Takashi
> On Fri, 2 Aug 2013 16:36:29 +0900 > YAMAMOTO Takashi wrote: > >> >> Signed-off-by: YAMAMOTO Takashi >> --- >> ryu/lib/packet/vrrp.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ryu/lib/packet/vrrp.py b/ryu/lib/packet/vrrp.py >> index 772d913..747d0c4 100644

Re: [Ryu-devel] [PATCH 00/36] updated vrrp patches

2013-08-04 Thread FUJITA Tomonori
On Fri, 2 Aug 2013 16:35:59 +0900 YAMAMOTO Takashi wrote: > this set is an updated version of vrrp service. > > changes from the previous: > - update after the recent api changes > - test improvements > - bug fixes > > a few patches are not directly related to the rest of the set >