[Ryu-devel] [PATCH v2] add STP application

2013-09-09 Thread watanabe.fumitaka
Changes v1 -> v2 - change a variable name into meaningful name. This application provides the simple example of spanning tree. "stplib" module controls exchange of BPDU packets and each bridge's port status(relay or block of frames). The module sends "EventTopologyChange" event when the topolo

Re: [Ryu-devel] Do we have API which exchanges information between modules?

2013-09-09 Thread Satoshi Kobayashi
Hi YAMAMOTO-san, 2013/9/10 YAMAMOTO Takashi > hi, > > > Hi all, > > > > I would like to write a application with which modules cooperate. Do we > > have the good approach which implements it? > > > > I checked that hub.Queue was added to _CONTEXTS of RyuApp and an object > > could be exchanged b

Re: [Ryu-devel] Do we have API which exchanges information between modules?

2013-09-09 Thread YAMAMOTO Takashi
hi, > Hi all, > > I would like to write a application with which modules cooperate. Do we > have the good approach which implements it? > > I checked that hub.Queue was added to _CONTEXTS of RyuApp and an object > could be exchanged between modules. However, the layer is too low. I think > that

[Ryu-devel] [PATCH 0/5] add some documentation

2013-09-09 Thread YAMAMOTO Takashi
this set includes some patches i posted last week. this is after OFPPort.name utf-8 changes. YAMAMOTO Takashi (5): add some docstring some documentation doc: sprinkle of12 json examples doc: sprinkle of13 json examples document OFPTableFeaturesStatsRequest/OFPTableFeaturesStatsReply do

[Ryu-devel] [PATCH 5/5] document OFPTableFeaturesStatsRequest/OFPTableFeaturesStatsReply

2013-09-09 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- doc/source/ofproto_v1_3_ref.rst| 7 +++ ryu/ofproto/ofproto_v1_3_parser.py | 23 +++ 2 files changed, 30 insertions(+) diff --git a/doc/source/ofproto_v1_3_ref.rst b/doc/source/ofproto_v1_3_ref.rst index d760234..79f207b 100644 ---

[Ryu-devel] [PATCH 2/5] some documentation

2013-09-09 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- doc/source/ofproto_base.rst | 49 + doc/source/ofproto_ref.rst | 1 + 2 files changed, 50 insertions(+) create mode 100644 doc/source/ofproto_base.rst diff --git a/doc/source/ofproto_base.rst b/doc/source/ofproto_

[Ryu-devel] [PATCH 3/5] doc: sprinkle of12 json examples

2013-09-09 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- doc/source/ofproto_v1_2_ref.rst | 187 1 file changed, 187 insertions(+) diff --git a/doc/source/ofproto_v1_2_ref.rst b/doc/source/ofproto_v1_2_ref.rst index ca20eca..9503647 100644 --- a/doc/source/ofproto_v1_2_ref.rst

[Ryu-devel] [PATCH 1/5] add some docstring

2013-09-09 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/lib/stringify.py | 71 +-- ryu/ofproto/ofproto_parser.py | 41 + 2 files changed, 110 insertions(+), 2 deletions(-) diff --git a/ryu/lib/stringify.py b/ryu/lib/stringify.py index a575

[Ryu-devel] [PATCH 4/5] doc: sprinkle of13 json examples

2013-09-09 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- doc/source/ofproto_v1_3_ref.rst | 245 1 file changed, 245 insertions(+) diff --git a/doc/source/ofproto_v1_3_ref.rst b/doc/source/ofproto_v1_3_ref.rst index 3e1a513..d760234 100644 --- a/doc/source/ofproto_v1_3_ref.rst

[Ryu-devel] Do we have API which exchanges information between modules?

2013-09-09 Thread Satoshi Kobayashi
Hi all, I would like to write a application with which modules cooperate. Do we have the good approach which implements it? I checked that hub.Queue was added to _CONTEXTS of RyuApp and an object could be exchanged between modules. However, the layer is too low. I think that is not user friendly.

Re: [Ryu-devel] [PATCH] add STP application

2013-09-09 Thread YAMAMOTO Takashi
> +# ofproto_v1_0_parser.OFPPhyPort data > +self.data = data can you use a more meaningful name than "data"? for example "ofport". YAMAMOTO Takashi -- How ServiceNow helps IT people transform IT departmen

[Ryu-devel] [PATCH 3/4] rest_firewall: remove of an unnecessary comma of json response

2013-09-09 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/app/rest_firewall.py |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ryu/app/rest_firewall.py b/ryu/app/rest_firewall.py index 1ca6cad..13de0ac 100644 --- a/ryu/app/rest_firewall.py +++ b/ryu/app/rest_firewall.py @@ -802,7 +802,8 @

[Ryu-devel] [PATCH 4/4] rest_firewall: remove of unused constant values

2013-09-09 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/app/rest_firewall.py |2 -- 1 file changed, 2 deletions(-) diff --git a/ryu/app/rest_firewall.py b/ryu/app/rest_firewall.py index 13de0ac..f8e4198 100644 --- a/ryu/app/rest_firewall.py +++ b/ryu/app/rest_firewall.py @@ -130,8 +130,6 @@ from ryu.ofprot

[Ryu-devel] [PATCH 0/4] rest_firewall: bug fix of handling an empty dict and some changes

2013-09-09 Thread watanabe.fumitaka
WATANABE Fumitaka (4): rest_firewall: bug fix of handling an empty dict rest_firewall: remove of a redundant code rest_firewall: remove of an unnecessary comma of json response rest_firewall: remove of unused constant values ryu/app/rest_firewall.py | 47 +++-

[Ryu-devel] [PATCH 2/4] rest_firewall: remove of a redundant code

2013-09-09 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/app/rest_firewall.py | 40 1 file changed, 4 insertions(+), 36 deletions(-) diff --git a/ryu/app/rest_firewall.py b/ryu/app/rest_firewall.py index 0a23e03..1ca6cad 100644 --- a/ryu/app/rest_firewall.py +++ b/ryu/

[Ryu-devel] [PATCH 1/4] rest_firewall: bug fix of handling an empty dict

2013-09-09 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/app/rest_firewall.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/app/rest_firewall.py b/ryu/app/rest_firewall.py index b8919e9..0a23e03 100644 --- a/ryu/app/rest_firewall.py +++ b/ryu/app/rest_firewall.py @@ -452,7 +452,7 @@

[Ryu-devel] [PATCH] of10: change OFPMatch to support ipv4 src and dst mask when wildcards are omitted in __init__

2013-09-09 Thread FUJITA Tomonori
From: Yuichi Sudo an example: match = OFPMatch( dl_type = 0x0800, nw_src = ipv4_bytes_to_int(ipv4_to_bin("192.168.0.1")), nw_src_mask = 24 ) Signed-off-by: FUJITA Tomonori --- ryu/ofproto/ofproto_v1_0_parser.py | 9 + 1 file changed, 5

[Ryu-devel] [PATCH v2] Support old style class

2013-09-09 Thread Satoshi Kobayashi
Since __base__ does not exist in old style class, it becomes an error. Signed-off-by: Satoshi Kobayashi --- ryu/base/app_manager.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ryu/base/app_manager.py b/ryu/base/app_manager.py index c666f2c..b39d6cc 100644 --- a/ryu/

Re: [Ryu-devel] [PATCH] Support old style class

2013-09-09 Thread Satoshi Kobayashi
I noticed that this patch is not essential. Really required is whether the context extends RyuApp. 2013/9/9 Satoshi Kobayashi > Since __base__ does not exist in old style class, it becomes an error. > --- > ryu/base/app_manager.py |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >

Re: [Ryu-devel] Proposal: Advanced WSGI API

2013-09-09 Thread YAMAMOTO Takashi
hi, > Hi, > > (I retransmit it because the transmission did not reach well) > > Currently, HTTP routing and implementation are separated. Example: > > -- > class SampleApiApp(app_manager.RyuApp): > \x85. > def __init__(self, *args, **kwargs): > \x85.

Re: [Ryu-devel] [PATCH v2 0/3] lib: lacplib: support OpenFlow1.2/1.3 and so on

2013-09-09 Thread YAMAMOTO Takashi
looks good to me. thanks. YAMAMOTO Takashi > Changes v1 -> v2: > > - change an argument of _add_flow_vx_x from msg to datapath > > > itoyuichi (3): > lib: lacplib: support OpenFlow1.2/1.3 > lib: lacplib: add underscore to a protected member > lib: lacplib: correct comments > > ryu/lib

[Ryu-devel] [PATCH] Support old style class

2013-09-09 Thread Satoshi Kobayashi
Since __base__ does not exist in old style class, it becomes an error. --- ryu/base/app_manager.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ryu/base/app_manager.py b/ryu/base/app_manager.py index c666f2c..2e6336f 100644 --- a/ryu/base/app_manager.py +++ b/ryu/base/

[Ryu-devel] [PATCH 2/2] simple_switch: simplify

2013-09-09 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/app/simple_switch.py | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/ryu/app/simple_switch.py b/ryu/app/simple_switch.py index 0397bc4..400092c 100644 --- a/ryu/app/simple_switch.py +++ b/ryu/app/simple_switch.py @@ -43,13 +43,8 @@

[Ryu-devel] [PATCH 1/2] simple_switch_12: reduce difference from simple_switch_13

2013-09-09 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/app/simple_switch_12.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/app/simple_switch_12.py b/ryu/app/simple_switch_12.py index 62b5bf9..27a643c 100644 --- a/ryu/app/simple_switch_12.py +++ b/ryu/app/simple_switch_12.py @@ -38,7

[Ryu-devel] Fwd: Ryu's Packet Library Performance.

2013-09-09 Thread Omid Alipourfard
Hello Yamamoto, I will try to explain my problem with the current code in Ryu: When you parse a packet, MAC and IP fields get translated into EUI-64 and dotted format for "no reason". This has a huge impact on performance when you have a large number of packets (As it's obvious in the benchmark c