Re: [Ryu-devel] [PATCH v2 0/3] lib: lacplib: support OpenFlow1.2/1.3 and so on

2013-09-13 Thread FUJITA Tomonori
On Mon, 09 Sep 2013 15:33:13 +0900 Yuichi Ito wrote: > Changes v1 -> v2: > > - change an argument of _add_flow_vx_x from msg to datapath > > > itoyuichi (3): > lib: lacplib: support OpenFlow1.2/1.3 > lib: lacplib: add underscore to a protected member > lib: lacplib: correct comments > >

Re: [Ryu-devel] [PATCH] Simpler API to assemble a packet

2013-09-13 Thread FUJITA Tomonori
On Thu, 5 Sep 2013 19:25:55 +0900 Satoshi Kobayashi wrote: > For example: > > (Current) > e = ethernet.ethernet(…) > i = ipv4.ipv4(…) > u = udp.udp(…) > pkt = packet.Packet() > pkt.add_protocols(e) > pkt.add_protocols(i) > pkt.add_protocols(u) > > (New) > e = ethernet.ethernet(…) > i = ipv4.ip

Re: [Ryu-devel] OFPActionSetField issues - OFPT_FLOW_MOD with incorrect length 116

2013-09-13 Thread FUJITA Tomonori
On Thu, 12 Sep 2013 20:49:45 -0400 Nitin Sharma wrote: > Here are the actions/instructions I am trying to set using , > > me.ofproto.OFPIT_APPLY_ACTIONS > > [OFPActionOutput(len=16,max_len=0,port=5,type=0), > OFPActionSetField(eth_dst='00:25:90:9b:b8:47')] > > [OFPInstructionActions(actions=[O

Re: [Ryu-devel] [PATCH 1/4] tweak packet_data_generator

2013-09-13 Thread FUJITA Tomonori
On Fri, 13 Sep 2013 12:24:30 +0900 YAMAMOTO Takashi wrote: > to reproduce a problem reported by Nitin Sharma on ryu-devel. > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/tests/packet_data_generator/src/x3.erl | 7 ++- > ryu/tests/packet_data_generator/src/x4.erl | 7 ++- > 2 files cha

Re: [Ryu-devel] [PATCH 1/5] add some docstring

2013-09-13 Thread FUJITA Tomonori
On Tue, 10 Sep 2013 14:52:01 +0900 YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi > --- > ryu/lib/stringify.py | 71 > +-- > ryu/ofproto/ofproto_parser.py | 41 + > 2 files changed, 110 insertions(+), 2 deletio

Re: [Ryu-devel] [PATCH 0/4] rest_firewall: bug fix of handling an empty dict and some changes

2013-09-13 Thread FUJITA Tomonori
On Tue, 10 Sep 2013 11:28:22 +0900 "watanabe.fumitaka" wrote: > WATANABE Fumitaka (4): > rest_firewall: bug fix of handling an empty dict > rest_firewall: remove of a redundant code > rest_firewall: remove of an unnecessary comma of json response > rest_firewall: remove of unused constant

Re: [Ryu-devel] [PATCH] doc: update icmpv6

2013-09-13 Thread FUJITA Tomonori
On Tue, 3 Sep 2013 22:50:03 -0300 Ygor Amaral wrote: > Signed-off-by: Ygor Amaral > --- > ryu/lib/packet/icmpv6.py | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Applied, thanks! -- How ServiceNow helps

Re: [Ryu-devel] [PATCH 00/16] assume UTF-8 for some of-wire fields

2013-09-13 Thread FUJITA Tomonori
On Wed, 4 Sep 2013 16:04:25 +0900 YAMAMOTO Takashi wrote: > this set introduces an assumption that some of of-wire "name" fields > are utf-8 encoded and changes json representation accordingly. > (ie. no base64) > > YAMAMOTO Takashi (16): > stringify: add 'utf-8' type > of10: assume OFPPhyP

Re: [Ryu-devel] [PATCH] of10: change OFPMatch to support ipv4 src and dst mask when wildcards are omitted in __init__

2013-09-13 Thread FUJITA Tomonori
On Tue, 10 Sep 2013 10:54:07 +0900 FUJITA Tomonori wrote: > From: Yuichi Sudo > > an example: >match = OFPMatch( > dl_type = 0x0800, > nw_src = ipv4_bytes_to_int(ipv4_to_bin("192.168.0.1")), >nw_src_mask = 24 > ) > > Signed-off-by: FUJITA Tomon

Re: [Ryu-devel] [PATCH v2] Support old style class

2013-09-13 Thread FUJITA Tomonori
On Tue, 10 Sep 2013 10:20:26 +0900 Satoshi Kobayashi wrote: > Since __base__ does not exist in old style class, it becomes an error. > > Signed-off-by: Satoshi Kobayashi > --- > ryu/base/app_manager.py |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks. --

Re: [Ryu-devel] [PATCH 2/2] simple_switch: simplify

2013-09-13 Thread FUJITA Tomonori
On Mon, 9 Sep 2013 17:12:49 +0900 YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi > --- > ryu/app/simple_switch.py | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/ryu/app/simple_switch.py b/ryu/app/simple_switch.py > index 0397bc4..400092c 100644 > ---

Re: [Ryu-devel] [PATCH] ryu-manager: copyright notice

2013-09-13 Thread FUJITA Tomonori
On Wed, 11 Sep 2013 15:43:28 +0900 YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi > --- > bin/ryu-manager | 15 +++ > 1 file changed, 15 insertions(+) Applied, not sure it's worth claim though.

Re: [Ryu-devel] [PATCH 1/3] ofproto: remove some assertions

2013-09-13 Thread FUJITA Tomonori
On Mon, 2 Sep 2013 12:09:52 +0900 YAMAMOTO Takashi wrote: > remove some assertions which merely prevent serializing an object > multiple times. > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/ofproto/ofproto_parser.py | 5 - > ryu/ofproto/ofproto_v1_0_parser.py

Re: [Ryu-devel] [PATCH 1/2] simple_switch_12: reduce difference from simple_switch_13

2013-09-13 Thread FUJITA Tomonori
On Mon, 9 Sep 2013 17:12:48 +0900 YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi > --- > ryu/app/simple_switch_12.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied. -- How ServiceNow helps

Re: [Ryu-devel] Multithread dispatching of a event in RyuApp

2013-09-13 Thread Satoshi Kobayashi
Self comment: Because it can substitute generating new greenthread in an event, it is not somewhat intuitive but may not be so important. 2013/9/13 Satoshi Kobayashi > Hi all, > > I noticed that RyuApp dispatched an event in singlethread. But it can not > work the cooperation of threads between